From b69cba1aba174da4b1f368db54cf632e685cb80b Mon Sep 17 00:00:00 2001
From: Seth Alves <seth.alves@gmail.com>
Date: Sat, 25 Apr 2015 10:50:18 -0700
Subject: [PATCH] respond to code-review

---
 interface/src/Application.cpp                      | 1 -
 interface/src/ui/ApplicationOverlay.cpp            | 1 -
 libraries/gpu/src/gpu/GLBackendOutput.cpp          | 1 -
 libraries/gpu/src/gpu/GLBackendTexture.cpp         | 3 +--
 libraries/networking/src/DataServerAccountInfo.cpp | 3 +--
 libraries/render-utils/src/Model.cpp               | 1 -
 6 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp
index 565aa07332..95700f3257 100644
--- a/interface/src/Application.cpp
+++ b/interface/src/Application.cpp
@@ -1058,7 +1058,6 @@ void Application::keyPressEvent(QKeyEvent* event) {
         bool isShifted = event->modifiers().testFlag(Qt::ShiftModifier);
         bool isMeta = event->modifiers().testFlag(Qt::ControlModifier);
         bool isOption = event->modifiers().testFlag(Qt::AltModifier);
-        // bool isKeypad = event->modifiers().testFlag(Qt::KeypadModifier);
         switch (event->key()) {
                 break;
             case Qt::Key_L:
diff --git a/interface/src/ui/ApplicationOverlay.cpp b/interface/src/ui/ApplicationOverlay.cpp
index 9978a05dac..bf93a3e7d2 100644
--- a/interface/src/ui/ApplicationOverlay.cpp
+++ b/interface/src/ui/ApplicationOverlay.cpp
@@ -257,7 +257,6 @@ void ApplicationOverlay::displayOverlayTexture() {
     if (_alpha == 0.0f) {
         return;
     }
-    // auto glCanvas = Application::getInstance()->getGLWidget();
     glMatrixMode(GL_PROJECTION);
     glPushMatrix(); {
         glLoadIdentity();
diff --git a/libraries/gpu/src/gpu/GLBackendOutput.cpp b/libraries/gpu/src/gpu/GLBackendOutput.cpp
index e03ab43962..2529070b18 100755
--- a/libraries/gpu/src/gpu/GLBackendOutput.cpp
+++ b/libraries/gpu/src/gpu/GLBackendOutput.cpp
@@ -24,7 +24,6 @@ GLBackend::GLFramebuffer* GLBackend::syncGPUObject(const Framebuffer& framebuffe
     GLFramebuffer* object = Backend::getGPUObject<GLBackend::GLFramebuffer>(framebuffer);
 
     // If GPU object already created and in sync
-    // bool needUpdate = false;
     if (object) {
         return object;
     } else if (framebuffer.isEmpty()) {
diff --git a/libraries/gpu/src/gpu/GLBackendTexture.cpp b/libraries/gpu/src/gpu/GLBackendTexture.cpp
index 4bb16ba0b8..da39ab16fa 100755
--- a/libraries/gpu/src/gpu/GLBackendTexture.cpp
+++ b/libraries/gpu/src/gpu/GLBackendTexture.cpp
@@ -177,8 +177,7 @@ public:
                         break;
                         }
                     case gpu::NUM_TYPES: { // quiet compiler
-                        assert(false);
-                        break;
+                        Q_UNREACHABLE();
                     }
                     }
                     break;
diff --git a/libraries/networking/src/DataServerAccountInfo.cpp b/libraries/networking/src/DataServerAccountInfo.cpp
index b58af5e4e7..44e8dbef90 100644
--- a/libraries/networking/src/DataServerAccountInfo.cpp
+++ b/libraries/networking/src/DataServerAccountInfo.cpp
@@ -35,8 +35,7 @@ DataServerAccountInfo::DataServerAccountInfo() :
 
 }
 
-DataServerAccountInfo::DataServerAccountInfo(const DataServerAccountInfo& otherInfo) {
-    QObject(),
+DataServerAccountInfo::DataServerAccountInfo(const DataServerAccountInfo& otherInfo) : QObject() {
     _accessToken = otherInfo._accessToken;
     _username = otherInfo._username;
     _xmppPassword = otherInfo._xmppPassword;
diff --git a/libraries/render-utils/src/Model.cpp b/libraries/render-utils/src/Model.cpp
index bcdba0dd42..be2ccdb60e 100644
--- a/libraries/render-utils/src/Model.cpp
+++ b/libraries/render-utils/src/Model.cpp
@@ -111,7 +111,6 @@ void Model::RenderPipelineLib::addRenderPipeline(Model::RenderKey key,
     slotBindings.insert(gpu::Shader::Binding(std::string("emissiveMap"), 3));
 
     gpu::ShaderPointer program = gpu::ShaderPointer(gpu::Shader::createProgram(vertexShader, pixelShader));
-    // bool makeResult =
     gpu::Shader::makeProgram(*program, slotBindings);