From adeedc88d3c882255ba2428736bc098032a0fb68 Mon Sep 17 00:00:00 2001 From: dante ruiz Date: Mon, 10 Jun 2019 14:38:01 -0700 Subject: [PATCH 1/2] add launcher error page --- launchers/darwin/src/DownloadDomainContent.m | 2 +- launchers/darwin/src/DownloadInterface.m | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/launchers/darwin/src/DownloadDomainContent.m b/launchers/darwin/src/DownloadDomainContent.m index 7b0247a6f4..f0b625c3e2 100644 --- a/launchers/darwin/src/DownloadDomainContent.m +++ b/launchers/darwin/src/DownloadDomainContent.m @@ -54,7 +54,7 @@ -(void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didCompleteWithError:(NSError *)error { NSLog(@"completed; error: %@", error); + [[Launcher sharedLauncher] displayErrorPage]; } - @end diff --git a/launchers/darwin/src/DownloadInterface.m b/launchers/darwin/src/DownloadInterface.m index b957197567..bcc07f6377 100644 --- a/launchers/darwin/src/DownloadInterface.m +++ b/launchers/darwin/src/DownloadInterface.m @@ -66,6 +66,7 @@ -(void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didCompleteWithError:(NSError *)error { NSLog(@"completed; error: %@", error); + [[Launcher sharedLauncher] displayErrorPage]; } From fc1f7615f48936becf29827078f0a3faebe0a8e9 Mon Sep 17 00:00:00 2001 From: dante ruiz Date: Tue, 11 Jun 2019 16:30:21 -0700 Subject: [PATCH 2/2] fix errors --- launchers/darwin/src/DownloadDomainContent.m | 4 +++- launchers/darwin/src/DownloadInterface.m | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/launchers/darwin/src/DownloadDomainContent.m b/launchers/darwin/src/DownloadDomainContent.m index f0b625c3e2..65878db356 100644 --- a/launchers/darwin/src/DownloadDomainContent.m +++ b/launchers/darwin/src/DownloadDomainContent.m @@ -54,7 +54,9 @@ -(void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didCompleteWithError:(NSError *)error { NSLog(@"completed; error: %@", error); - [[Launcher sharedLauncher] displayErrorPage]; + if (error) { + [[Launcher sharedLauncher] displayErrorPage]; + } } @end diff --git a/launchers/darwin/src/DownloadInterface.m b/launchers/darwin/src/DownloadInterface.m index bcc07f6377..7a8abf2e0a 100644 --- a/launchers/darwin/src/DownloadInterface.m +++ b/launchers/darwin/src/DownloadInterface.m @@ -66,7 +66,9 @@ -(void)URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didCompleteWithError:(NSError *)error { NSLog(@"completed; error: %@", error); - [[Launcher sharedLauncher] displayErrorPage]; + if (error) { + [[Launcher sharedLauncher] displayErrorPage]; + } }