From 0b472a9f0273d024162c64d8c3cb09c90e1ae09e Mon Sep 17 00:00:00 2001
From: Ken Cooke <ken@highfidelity.io>
Date: Sat, 16 Feb 2019 11:19:18 -0800
Subject: [PATCH] Protect against lost counter underflow in networking stats
---
libraries/networking/src/SequenceNumberStats.cpp | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libraries/networking/src/SequenceNumberStats.cpp b/libraries/networking/src/SequenceNumberStats.cpp
index e11fcf22d4..a451701502 100644
--- a/libraries/networking/src/SequenceNumberStats.cpp
+++ b/libraries/networking/src/SequenceNumberStats.cpp
@@ -142,8 +142,10 @@ SequenceNumberStats::ArrivalInfo SequenceNumberStats::sequenceNumberReceived(qui
if (wantExtraDebugging) {
qCDebug(networking) << "found it in _missingSet";
}
- _stats._lost--;
- _stats._recovered++;
+ if (_stats._lost > 0) {
+ _stats._lost--;
+ _stats._recovered++;
+ }
} else {
// this late seq num is not in our missing set. it is possibly a duplicate, or possibly a late
// packet that should have arrived before our first received packet. we'll count these