From b08bb93ff739c13636dab49c72db07cf886cbdfb Mon Sep 17 00:00:00 2001 From: Andrew Meadows Date: Thu, 13 Jun 2019 10:53:55 -0700 Subject: [PATCH] add comment about why WebEntityRenderer::onRemoveFromSceneTyped() --- libraries/entities-renderer/src/RenderableWebEntityItem.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/entities-renderer/src/RenderableWebEntityItem.cpp b/libraries/entities-renderer/src/RenderableWebEntityItem.cpp index 3334a958f3..5b5fc08460 100644 --- a/libraries/entities-renderer/src/RenderableWebEntityItem.cpp +++ b/libraries/entities-renderer/src/RenderableWebEntityItem.cpp @@ -470,6 +470,8 @@ void WebEntityRenderer::handlePointerEventAsMouse(const PointerEvent& event) { } void WebEntityRenderer::onRemoveFromSceneTyped(const TypedEntityPointer& entity) { + // HACK: destroyWebSurface() here to avoid a crash on shutdown. + // TODO: fix the real problem: EntityRenderer<>::dtor never called on shutdown for smart-pointer resource leak. destroyWebSurface(); }