Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-09 15:29:32 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

EntityList -> re-focus the rename field rather then re-selecting the text fully

Browse source 
EntityProperties -> ignore selection updates when nothing is changed and window is focused
This commit is contained in:
Thijs Wenker 2019-03-14 01:08:11 +01:00
parent 5e09103d9f
commit aeb56ff22a
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
scripts/system/html/js/entityList.js
View file

@ -459,7 +459,7 @@ function loaded() {
isRenameFieldBeingMoved = true; isRenameFieldBeingMoved = true;
document.body.appendChild(elRenameInput); document.body.appendChild(elRenameInput);
// keep the focus // keep the focus
elRenameInput.select(); elRenameInput.focus();
} }
} }
@ -475,7 +475,7 @@ function loaded() {
elCell.innerHTML = ""; elCell.innerHTML = "";
elCell.appendChild(elRenameInput); elCell.appendChild(elRenameInput);
// keep the focus // keep the focus
elRenameInput.select(); elRenameInput.focus();
isRenameFieldBeingMoved = false; isRenameFieldBeingMoved = false;
} }

7
scripts/system/html/js/entityProperties.js
View file

@ -3325,6 +3325,13 @@ function loaded() {
} }
let hasSelectedEntityChanged = lastEntityID !== '"' + selectedEntityProperties.id + '"'; let hasSelectedEntityChanged = lastEntityID !== '"' + selectedEntityProperties.id + '"';
if (!hasSelectedEntityChanged && document.hasFocus()) {
// in case the selection has not changed and we still have focus on the properties page,
// we will ignore the event.
return;
}
let doSelectElement = !hasSelectedEntityChanged; let doSelectElement = !hasSelectedEntityChanged;
// the event bridge and json parsing handle our avatar id string differently. // the event bridge and json parsing handle our avatar id string differently.