fix parent grab dropping and cullig flickering

libraries/entities-renderer/src/RenderableEntityItem.cpp

@@ -363,12 +363,18 @@ bool EntityRenderer::needsRenderUpdateFromEntity(const EntityItemPointer& entity
     return false;
 }
 
-void EntityRenderer::updateModelTransform() {
+void EntityRenderer::updateModelTransformAndBound() {
     bool success = false;
     auto newModelTransform = _entity->getTransformToCenter(success);
     if (success) {
         _modelTransform = newModelTransform;
     }
+
+    success = false;
+    auto bound = _entity->getAABox(success);
+    if (success) {
+        _bound = bound;
+    }
 }
 
 void EntityRenderer::doRenderUpdateSynchronous(const ScenePointer& scene, Transaction& transaction, const EntityItemPointer& entity) {
@@ -380,15 +386,7 @@ void EntityRenderer::doRenderUpdateSynchronous(const ScenePointer& scene, Transa
         }
         _prevIsTransparent = transparent;
 
-        bool success = false;
+        updateModelTransformAndBound();
-        auto bound = entity->getAABox(success);
-        if (success) {
-            _bound = bound;
-        }
-        auto newModelTransform = entity->getTransformToCenter(success);
-        if (success) {
-            _modelTransform = newModelTransform;
-        }
 
         _moving = entity->isMovingRelativeToParent();
         _visible = entity->getVisible();

libraries/entities-renderer/src/RenderableEntityItem.h

@@ -97,7 +97,7 @@ protected:
     virtual void doRender(RenderArgs* args) = 0;
 
     bool isFading() const { return _isFading; }
-    void updateModelTransform();
+    void updateModelTransformAndBound();
     virtual bool isTransparent() const { return _isFading ? Interpolate::calculateFadeRatio(_fadeStartTime) < 1.0f : false; }
     inline bool isValidRenderItem() const { return _renderItemID != Item::INVALID_ITEM_ID; }
 

libraries/entities-renderer/src/RenderableParticleEffectEntityItem.cpp

@@ -126,7 +126,7 @@ void ParticleEffectEntityRenderer::doRenderUpdateSynchronousTyped(const ScenePoi
     void* key = (void*)this;
     AbstractViewStateInterface::instance()->pushPostUpdateLambda(key, [this] () {
         withWriteLock([&] {
-            updateModelTransform();
+            updateModelTransformAndBound();
             _renderTransform = getModelTransform();
         });
     });

libraries/entities-renderer/src/RenderableShapeEntityItem.cpp

@@ -106,10 +106,8 @@ void ShapeEntityRenderer::doRenderUpdateSynchronousTyped(const ScenePointer& sce
             _position = entity->getWorldPosition();
             _dimensions = entity->getScaledDimensions();
             _orientation = entity->getWorldOrientation();
-            bool success = false;
+            updateModelTransformAndBound();
-            auto newModelTransform = entity->getTransformToCenter(success);
+            _renderTransform = getModelTransform();
-            _renderTransform = success ? newModelTransform : getModelTransform();
-
             if (_shape == entity::Sphere) {
                 _renderTransform.postScale(SPHERE_ENTITY_SCALE);
             }

libraries/entities-renderer/src/RenderableTextEntityItem.cpp

@@ -70,7 +70,7 @@ void TextEntityRenderer::doRenderUpdateSynchronousTyped(const ScenePointer& scen
     AbstractViewStateInterface::instance()->pushPostUpdateLambda(key, [this, entity] () {
         withWriteLock([&] {
             _dimensions = entity->getScaledDimensions();
-            updateModelTransform();
+            updateModelTransformAndBound();
             _renderTransform = getModelTransform();
         });
     });

libraries/entities-renderer/src/RenderableWebEntityItem.cpp

@@ -206,7 +206,7 @@ void WebEntityRenderer::doRenderUpdateSynchronousTyped(const ScenePointer& scene
 
                 glm::vec2 windowSize = getWindowSize(entity);
                 _webSurface->resize(QSize(windowSize.x, windowSize.y));
-                updateModelTransform();
+                updateModelTransformAndBound();
                 _renderTransform = getModelTransform();
                 _renderTransform.postScale(entity->getScaledDimensions());
             });

scripts/system/controllers/controllerModules/nearParentGrabEntity.js

@@ -173,11 +173,7 @@ Script.include("/~/system/libraries/cloneEntityUtils.js");
                 this.lastUnequipCheckTime = now;
                 if (props.parentID === MyAvatar.SELF_ID) {
                     var sensorScaleFactor = MyAvatar.sensorToWorldScale;
-                    var handPosition = controllerData.controllerLocations[this.hand].position;
+                    if ((props.localPosition > TEAR_AWAY_DISTANCE * sensorScaleFactor)) {
-                    var dist = distanceBetweenPointAndEntityBoundingBox(handPosition, props);
-                    var distance = Vec3.distance(props.position, handPosition);
-                    if ((dist > TEAR_AWAY_DISTANCE) ||
-                        (distance > NEAR_GRAB_RADIUS * sensorScaleFactor)) {
                         this.autoUnequipCounter++;
                     } else {
                         this.autoUnequipCounter = 0;

scripts/system/libraries/controllerDispatcherUtils.js

@@ -130,7 +130,9 @@ DISPATCHER_PROPERTIES = [
     "type",
     "href",
     "cloneable",
-    "cloneDynamic"
+    "cloneDynamic",
+    "localPosition",
+    "localRotation"
 ];
 
 // priority -- a lower priority means the module will be asked sooner than one with a higher priority in a given update step