diff --git a/libraries/animation/src/Rig.cpp b/libraries/animation/src/Rig.cpp index 37d0b19cd6..8b7b0ba916 100644 --- a/libraries/animation/src/Rig.cpp +++ b/libraries/animation/src/Rig.cpp @@ -1972,6 +1972,7 @@ AnimPose Rig::getJointPose(int jointIndex) const { void Rig::copyJointsIntoJointData(QVector& jointDataVec) const { const AnimPose geometryToRigPose(_geometryToRigTransform); + const glm::vec3 geometryToRigScale(geometryToRigPose.scale()); jointDataVec.resize((int)getJointStateCount()); for (auto i = 0; i < jointDataVec.size(); i++) { @@ -1984,9 +1985,10 @@ void Rig::copyJointsIntoJointData(QVector& jointDataVec) const { // translations are in relative frame but scaled so that they are in meters, // instead of model units. - glm::vec3 defaultRelTrans = _geometryOffset.scale() * _animSkeleton->getRelativeDefaultPose(i).trans(); - data.translation = _geometryOffset.scale() * (!_sendNetworkNode ? _internalPoseSet._relativePoses[i].trans() : _networkPoseSet._relativePoses[i].trans()); - data.translationIsDefaultPose = isEqual(data.translation, defaultRelTrans); + glm::vec3 defaultRelTrans = _animSkeleton->getRelativeDefaultPose(i).trans(); + glm::vec3 currentRelTrans = _sendNetworkNode ? _networkPoseSet._relativePoses[i].trans() : _internalPoseSet._relativePoses[i].trans(); + data.translation = geometryToRigScale * currentRelTrans; + data.translationIsDefaultPose = isEqual(currentRelTrans, defaultRelTrans); } else { data.translationIsDefaultPose = true; data.rotationIsDefaultPose = true; @@ -2012,6 +2014,8 @@ void Rig::copyJointsFromJointData(const QVector& jointDataVec) { std::vector rotations; rotations.reserve(numJoints); const glm::quat rigToGeometryRot(glmExtractRotation(_rigToGeometryTransform)); + const glm::vec3 rigToGeometryScale(extractScale(_rigToGeometryTransform)); + for (int i = 0; i < numJoints; i++) { const JointData& data = jointDataVec.at(i); if (data.rotationIsDefaultPose) { @@ -2037,7 +2041,7 @@ void Rig::copyJointsFromJointData(const QVector& jointDataVec) { _internalPoseSet._relativePoses[i].trans() = relativeDefaultPoses[i].trans(); } else { // JointData translations are in scaled relative-frame so we scale back to regular relative-frame - _internalPoseSet._relativePoses[i].trans() = _invGeometryOffset.scale() * data.translation; + _internalPoseSet._relativePoses[i].trans() = rigToGeometryScale * data.translation; } } } diff --git a/libraries/networking/src/udt/PacketHeaders.cpp b/libraries/networking/src/udt/PacketHeaders.cpp index 9eed463d2d..18e439aa77 100644 --- a/libraries/networking/src/udt/PacketHeaders.cpp +++ b/libraries/networking/src/udt/PacketHeaders.cpp @@ -40,7 +40,7 @@ PacketVersion versionForPacketType(PacketType packetType) { case PacketType::AvatarData: case PacketType::BulkAvatarData: case PacketType::KillAvatar: - return static_cast(AvatarMixerPacketVersion::FarGrabJointsRedux); + return static_cast(AvatarMixerPacketVersion::JointTransScaled); case PacketType::MessagesData: return static_cast(MessageDataVersion::TextOrBinaryData); // ICE packets diff --git a/libraries/networking/src/udt/PacketHeaders.h b/libraries/networking/src/udt/PacketHeaders.h index e5efe05ad0..f3bc115410 100644 --- a/libraries/networking/src/udt/PacketHeaders.h +++ b/libraries/networking/src/udt/PacketHeaders.h @@ -296,7 +296,8 @@ enum class AvatarMixerPacketVersion : PacketVersion { FarGrabJoints, MigrateSkeletonURLToTraits, MigrateAvatarEntitiesToTraits, - FarGrabJointsRedux + FarGrabJointsRedux, + JointTransScaled }; enum class DomainConnectRequestVersion : PacketVersion {