From ac8281075b5efbe4e7bae99cf3983fe9c1763202 Mon Sep 17 00:00:00 2001 From: Anthony Thibault Date: Mon, 5 Nov 2018 17:25:00 -0800 Subject: [PATCH] Code review feedback Added comment to explain removal of displayPlugin->resetSensors from Application::resetSensors() --- interface/src/Application.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index fab58428ca..0f2c5390b2 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -6468,10 +6468,13 @@ void Application::copyDisplayViewFrustum(ViewFrustum& viewOut) const { viewOut = _displayViewFrustum; } +// resentSensors() is a bit of vestigial feature. It used to be used for Oculus DK2 to recenter the view around +// the current head orientation. With the introduction of "room scale" tracking we no longer need that particular +// feature. However, we still use this to reset face trackers, eye trackers, audio and to optionally re-load the avatar +// rig and animations from scratch. void Application::resetSensors(bool andReload) { DependencyManager::get()->reset(); DependencyManager::get()->reset(); - //getActiveDisplayPlugin()->resetSensors(); _overlayConductor.centerUI(); getMyAvatar()->reset(true, andReload); QMetaObject::invokeMethod(DependencyManager::get().data(), "reset", Qt::QueuedConnection);