From aad54a0580ff2ba8a6eaae9ba819bf625383a0c1 Mon Sep 17 00:00:00 2001 From: Heather Anderson Date: Wed, 1 Apr 2020 02:44:52 -0700 Subject: [PATCH] renaming more of the annotations to be in a form Sentry is more likely to understand --- interface/src/Application.cpp | 6 +++--- interface/src/CrashHandler_Crashpad.cpp | 7 +++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index a73281e569..7bb845acb1 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -1083,8 +1083,8 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo { // identify gpu as early as possible to help identify OpenGL initialization errors. auto gpuIdent = GPUIdent::getInstance(); - setCrashAnnotation("gpu_name", gpuIdent->getName().toStdString()); - setCrashAnnotation("gpu_driver", gpuIdent->getDriver().toStdString()); + setCrashAnnotation("sentry[contexts][gpu][name]", gpuIdent->getName().toStdString()); + setCrashAnnotation("sentry[contexts][gpu][version]", gpuIdent->getDriver().toStdString()); setCrashAnnotation("gpu_memory", std::to_string(gpuIdent->getMemory())); } @@ -7054,7 +7054,7 @@ void Application::updateWindowTitle() const { nodeList->getDomainHandler().isConnected() ? "" : " (NOT CONNECTED)"; QString username = accountManager->getAccountInfo().getUsername(); - setCrashAnnotation("username", username.toStdString()); + setCrashAnnotation("sentry[user][username]", username.toStdString()); QString currentPlaceName; if (isServerlessMode()) { diff --git a/interface/src/CrashHandler_Crashpad.cpp b/interface/src/CrashHandler_Crashpad.cpp index d1b5103990..900a296955 100644 --- a/interface/src/CrashHandler_Crashpad.cpp +++ b/interface/src/CrashHandler_Crashpad.cpp @@ -84,10 +84,9 @@ bool startCrashHandler(std::string appPath) { std::vector arguments; std::map annotations; - annotations["token"] = BACKTRACE_TOKEN; - annotations["format"] = "minidump"; - annotations["version"] = BuildInfo::VERSION.toStdString(); - annotations["build_number"] = BuildInfo::BUILD_NUMBER.toStdString(); + annotations["sentry[release]"] = BACKTRACE_TOKEN; + annotations["sentry[contexts][app][app_version]"] = BuildInfo::VERSION.toStdString(); + annotations["sentry[contexts][app][app_build]"] = BuildInfo::BUILD_NUMBER.toStdString(); annotations["build_type"] = BuildInfo::BUILD_TYPE_STRING.toStdString(); auto machineFingerPrint = uuidStringWithoutCurlyBraces(FingerprintUtils::getMachineFingerprint());