From aab3b83ad9a138e3356a4851fa9758ec12d74562 Mon Sep 17 00:00:00 2001
From: howard-stearns <howard.stearns@gmail.com>
Date: Thu, 18 Aug 2016 14:20:53 -0700
Subject: [PATCH] open login if user tries to share and is not logged in,
 rather than messaging user that they cannot share

---
 scripts/system/snapshot.js | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/scripts/system/snapshot.js b/scripts/system/snapshot.js
index 8e99783ff6..92b16d31bc 100644
--- a/scripts/system/snapshot.js
+++ b/scripts/system/snapshot.js
@@ -32,6 +32,12 @@ var outstanding;
 function confirmShare(data) {
     var dialog = new OverlayWebWindow('Snapshot Review', Script.resolvePath("html/ShareSnapshot.html"), 800, 470);
     function onMessage(message) {
+        // Receives message from the html dialog via the qwebchannel EventBridge. This is complicated by the following:
+        // 1. Although we can send POJOs, we cannot receive a toplevel object. (Arrays of POJOs are fine, though.)
+        // 2. Although we currently use a single image, we would like to take snapshot, a selfie, a 360 etc. all at the
+        //    same time, show the user all of them, and have the user deselect any that they do not want to share.
+        //    So we'll ultimately be receiving a set of objects, perhaps with different post processing for each.
+        var isLoggedIn, needsLogin = false;
         switch (message) {
         case 'ready':
             dialog.emitScriptEvent(data); // Send it.
@@ -50,16 +56,26 @@ function confirmShare(data) {
             dialog.webEventReceived.disconnect(onMessage); // I'm not certain that this is necessary. If it is, what do we do on normal close?
             dialog.close();
             dialog.deleteLater();
+            isLoggedIn = Account.isLoggedIn();
             message.forEach(function (submessage) {
+                if (submessage.share && !isLoggedIn) {
+                    needsLogin = true;
+                    submessage.share = false;
+                }
                 if (submessage.share) {
                     print('sharing', submessage.localPath);
                     outstanding++;
                     Window.shareSnapshot(submessage.localPath);
+                } else {
+                    print('not sharing', submessage.localPath);
                 }
             });
             if (!outstanding && shouldOpenFeedAfterShare()) {
                 showFeedWindow();
             }
+            if (needsLogin) { // after the possible feed, so that the login is on top
+                Account.checkAndSignalForAccessToken();
+            }
         }
     }
     dialog.webEventReceived.connect(onMessage);
@@ -124,7 +140,7 @@ function resetButtons(path, notify) {
         { localPath: path },
         {
             canShare: Boolean(Window.location.placename),
-            isLoggedIn: Account.isLoggedIn(),
+            isLoggedIn: true, // Just have the dialog act as though we are. To be removed at both ends later.
             openFeedAfterShare: shouldOpenFeedAfterShare()
         }
     ]);