Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-04-07 10:32:25 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Remove PluginManager::disableDisplayPlugin

Browse source 
This isn't called anywhere, and I believe the implementation is flawed anyway.
While it tries to remove the plugin from the list, the plugin isn't shut down,
or disconnected from events. This is likely to cause problems if it were to
be used.
This commit is contained in:
Dale Glass 2023-11-12 13:41:17 +01:00
parent e03768ddc5
commit a7132c4ff6
2 changed files with 0 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libraries/plugins/src/plugins/PluginManager.cpp
View file

@ -272,14 +272,6 @@ DisplayPluginList PluginManager::getAllDisplayPlugins() {
return _displayPlugins;
}
void PluginManager::disableDisplayPlugin(const QString& name) {
auto it = std::remove_if(_displayPlugins.begin(), _displayPlugins.end(), [&](const DisplayPluginPointer& plugin){
return plugin->getName() == name;
});
_displayPlugins.erase(it, _displayPlugins.end());
}
const InputPluginList& PluginManager::getInputPlugins() {
static std::once_flag once;
static auto deviceAddedCallback = [&](QString deviceName) {

9
libraries/plugins/src/plugins/PluginManager.h
View file

@ -107,15 +107,6 @@ public:
*/
void setPreferredDisplayPlugins(const QStringList& displays);
/**
* @brief Disable a display plugin.
*
* This removes the plugin from the plugins list.
* The plugin is not deinitialized, and events are not disconnected.
* @param name
*/
void disableDisplayPlugin(const QString& name);
/**
* @brief Disable a list of displays
*