Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-09 23:40:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #14220 from SamGondelman/pickFree

Browse source 
Fix PickManager::removePick heap use after free
This commit is contained in:
Seth Alves 2018-10-22 09:48:22 -07:00 committed by GitHub
commit a2d4c236c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libraries/pointers/src/PickManager.cpp
View file

@ -38,11 +38,11 @@ std::shared_ptr<PickQuery> PickManager::findPick(unsigned int uid) const {
void PickManager::removePick(unsigned int uid) { void PickManager::removePick(unsigned int uid) {
withWriteLock([&] { withWriteLock([&] {
auto type = _typeMap.find(uid); auto typeIt = _typeMap.find(uid);
if (type != _typeMap.end()) { if (typeIt != _typeMap.end()) {
_picks[type->second].erase(uid); _picks[typeIt->second].erase(uid);
_typeMap.erase(uid); _totalPickCounts[typeIt->second]--;
_totalPickCounts[type->second]--; _typeMap.erase(typeIt);
} }
}); });
} }