fix some warnings

This commit is contained in:
Brad Hefta-Gaub 2015-10-30 00:19:14 -07:00
parent d9c534f404
commit a149a2dd60
3 changed files with 7 additions and 4 deletions

View file

@ -44,8 +44,7 @@ bool GlWindow::makeCurrent() {
qDebug() << "GL Renderer: " << QString((const char*) glGetString(GL_RENDERER)); qDebug() << "GL Renderer: " << QString((const char*) glGetString(GL_RENDERER));
}); });
QOpenGLContext * currentContext = QOpenGLContext::currentContext(); Q_ASSERT(_context == QOpenGLContext::currentContext());
Q_ASSERT(_context == currentContext);
return makeCurrentResult; return makeCurrentResult;
} }

View file

@ -14,11 +14,11 @@
#include "PhysicsCollisionGroups.h" #include "PhysicsCollisionGroups.h"
bool CharacterController::needsRemoval() const { bool CharacterController::needsRemoval() const {
return (bool)(_pendingFlags & PENDING_FLAG_REMOVE_FROM_SIMULATION); return ((_pendingFlags & PENDING_FLAG_REMOVE_FROM_SIMULATION) == PENDING_FLAG_REMOVE_FROM_SIMULATION);
} }
bool CharacterController::needsAddition() const { bool CharacterController::needsAddition() const {
return (bool)(_pendingFlags & PENDING_FLAG_ADD_TO_SIMULATION); return ((_pendingFlags & PENDING_FLAG_ADD_TO_SIMULATION) == PENDING_FLAG_ADD_TO_SIMULATION);
} }
void CharacterController::setDynamicsWorld(btDynamicsWorld* world) { void CharacterController::setDynamicsWorld(btDynamicsWorld* world) {

View file

@ -113,6 +113,7 @@ void VrMenu::addMenu(QMenu* menu) {
Q_ARG(QVariant, QVariant::fromValue(qmlParent)), Q_ARG(QVariant, QVariant::fromValue(qmlParent)),
Q_ARG(QVariant, QVariant::fromValue(menu->title()))); Q_ARG(QVariant, QVariant::fromValue(menu->title())));
Q_ASSERT(invokeResult); Q_ASSERT(invokeResult);
Q_UNUSED(invokeResult); // FIXME - apparently we haven't upgraded the Qt on our unix Jenkins environments to 5.5.x
QObject* result = returnedValue.value<QObject*>(); QObject* result = returnedValue.value<QObject*>();
Q_ASSERT(result); Q_ASSERT(result);
@ -153,6 +154,7 @@ void VrMenu::addAction(QMenu* menu, QAction* action) {
Q_ARG(QVariant, QVariant::fromValue(menuQml)), Q_ARG(QVariant, QVariant::fromValue(menuQml)),
Q_ARG(QVariant, QVariant::fromValue(action->text()))); Q_ARG(QVariant, QVariant::fromValue(action->text())));
Q_ASSERT(invokeResult); Q_ASSERT(invokeResult);
Q_UNUSED(invokeResult); // FIXME - apparently we haven't upgraded the Qt on our unix Jenkins environments to 5.5.x
QObject* result = returnedValue.value<QObject*>(); QObject* result = returnedValue.value<QObject*>();
Q_ASSERT(result); Q_ASSERT(result);
// Bind the QML and Widget together // Bind the QML and Widget together
@ -174,6 +176,7 @@ void VrMenu::insertAction(QAction* before, QAction* action) {
Q_ARG(QVariant, QVariant::fromValue(beforeQml)), Q_ARG(QVariant, QVariant::fromValue(beforeQml)),
Q_ARG(QVariant, QVariant::fromValue(action->text()))); Q_ARG(QVariant, QVariant::fromValue(action->text())));
Q_ASSERT(invokeResult); Q_ASSERT(invokeResult);
Q_UNUSED(invokeResult); // FIXME - apparently we haven't upgraded the Qt on our unix Jenkins environments to 5.5.x
QObject* result = returnedValue.value<QObject*>(); QObject* result = returnedValue.value<QObject*>();
Q_ASSERT(result); Q_ASSERT(result);
bindActionToQmlAction(result, action); bindActionToQmlAction(result, action);
@ -192,4 +195,5 @@ void VrMenu::removeAction(QAction* action) {
Q_ARG(QVariant, QVariant::fromValue(menu)), Q_ARG(QVariant, QVariant::fromValue(menu)),
Q_ARG(QVariant, QVariant::fromValue(item))); Q_ARG(QVariant, QVariant::fromValue(item)));
Q_ASSERT(invokeResult); Q_ASSERT(invokeResult);
Q_UNUSED(invokeResult); // FIXME - apparently we haven't upgraded the Qt on our unix Jenkins environments to 5.5.x
} }