From 9f9ef8764d8341149b15f96e0765a8c6febbab2d Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Mon, 22 Feb 2016 15:32:59 -0800 Subject: [PATCH] add a note about the QDataStream black box --- domain-server/src/DomainServer.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/domain-server/src/DomainServer.cpp b/domain-server/src/DomainServer.cpp index dec88f8647..5e5a843fae 100644 --- a/domain-server/src/DomainServer.cpp +++ b/domain-server/src/DomainServer.cpp @@ -1055,6 +1055,8 @@ void DomainServer::sendHeartbeatToDataServer(const QString& networkAddress) { void DomainServer::sendHeartbeatToIceServer() { if (!_iceServerSocket.getAddress().isNull()) { + // NOTE: I'd love to specify the correct size for the packet here, but it's a little trickey with + // QDataStream and the possibility of IPv6 address for the sockets. static auto heartbeatPacket = NLPacket::create(PacketType::ICEServerHeartbeat); bool shouldRecreatePacket = false;