cleaning the State class code

libraries/gpu/src/gpu/GLBackend.cpp

@@ -379,6 +379,8 @@ void Batch::_glUniform1f(GLint location, GLfloat v0) {
     DO_IT_NOW(_glUniform1f, 1);
 }
 void GLBackend::do_glUniform1f(Batch& batch, uint32 paramOffset) {
+    if (_pipeline._program == 0)
+        return;
     glUniform1f(
         batch._params[paramOffset + 1]._int,
         batch._params[paramOffset + 0]._float);

libraries/gpu/src/gpu/GLBackendPipeline.cpp

@@ -71,6 +71,7 @@ void GLBackend::do_setPipeline(Batch& batch, uint32 paramOffset) {
     
     _pipeline._pipeline = pipeline;
 
+
     if (_pipeline._program != pipelineObject->_program->_program) {
         _pipeline._program = pipelineObject->_program->_program;
         _pipeline._invalidProgram = true;

libraries/gpu/src/gpu/GLBackendState.cpp

@@ -228,11 +228,13 @@ void GLBackend::do_setStateCullMode(int32 mode) {
         glEnable(GL_CULL_FACE);
         glCullFace(GL_CULL_MODES[mode]);
     }
+    CHECK_GL_ERROR();
 }
 
 void GLBackend::do_setStateFrontClockwise(int32 isFrontClockwise) {
     static GLenum  GL_FRONT_FACES[] = { GL_CCW, GL_CW };
     glFrontFace(GL_FRONT_FACES[isFrontClockwise]);
+    CHECK_GL_ERROR();
 }
 
 void GLBackend::do_setStateDepthClipEnable(int32 enable) {
@@ -274,10 +276,10 @@ void GLBackend::do_setStateAntialiasedLineEnable(int32 enable) {
 }
 
 void GLBackend::do_setStateDepthTest(State::DepthTest test) {
-    if (test._enabled) {
+    if (test.isEnabled()) {
         glEnable(GL_DEPTH_TEST);
-        glDepthMask(test._writeMask);
+        glDepthMask(test.getWriteMask());
-        glDepthFunc(GL_COMPARISON_FUNCTIONS[test._function]);
+        glDepthFunc(GL_COMPARISON_FUNCTIONS[test.getFunction()]);
     } else {
         glDisable(GL_DEPTH_TEST);
     }
@@ -285,12 +287,12 @@ void GLBackend::do_setStateDepthTest(State::DepthTest test) {
 }
 
 void GLBackend::do_setStateStencil(State::StencilActivation activation, State::StencilTest frontTest, State::StencilTest backTest) {
-    if (activation._enabled) {
+    if (activation.isEnabled()) {
         glEnable(GL_STENCIL_TEST);
-        glStencilMaskSeparate(GL_FRONT, activation._frontWriteMask);
+        glStencilMaskSeparate(GL_FRONT, activation.getWriteMaskFront());
-        glStencilMaskSeparate(GL_BACK, activation._backWriteMask);
+        glStencilMaskSeparate(GL_BACK, activation.getWriteMaskBack());
 
-         static GLenum STENCIL_OPS[] = {
+        static GLenum STENCIL_OPS[] = {
             GL_KEEP,
             GL_ZERO,
             GL_REPLACE,
@@ -300,11 +302,11 @@ void GLBackend::do_setStateStencil(State::StencilActivation activation, State::S
             GL_INCR,
             GL_DECR };
 
-        glStencilFuncSeparate(GL_FRONT, STENCIL_OPS[frontTest._failOp], STENCIL_OPS[frontTest._passOp], STENCIL_OPS[frontTest._depthFailOp]);
+        glStencilFuncSeparate(GL_FRONT, STENCIL_OPS[frontTest.getFailOp()], STENCIL_OPS[frontTest.getPassOp()], STENCIL_OPS[frontTest.getDepthFailOp()]);
-        glStencilFuncSeparate(GL_FRONT, GL_COMPARISON_FUNCTIONS[frontTest._function], frontTest._reference, frontTest._readMask);
+        glStencilFuncSeparate(GL_FRONT, GL_COMPARISON_FUNCTIONS[frontTest.getFunction()], frontTest.getReference(), frontTest.getReadMask());
 
-        glStencilFuncSeparate(GL_BACK, STENCIL_OPS[backTest._failOp], STENCIL_OPS[backTest._passOp], STENCIL_OPS[backTest._depthFailOp]);
+        glStencilFuncSeparate(GL_BACK, STENCIL_OPS[backTest.getFailOp()], STENCIL_OPS[backTest.getPassOp()], STENCIL_OPS[backTest.getDepthFailOp()]);
-        glStencilFuncSeparate(GL_BACK, GL_COMPARISON_FUNCTIONS[backTest._function], backTest._reference, backTest._readMask);
+        glStencilFuncSeparate(GL_BACK, GL_COMPARISON_FUNCTIONS[backTest.getFunction()], backTest.getReference(), backTest.getReadMask());
     } else {
         glDisable(GL_STENCIL_TEST);
     }
@@ -321,7 +323,7 @@ void GLBackend::do_setStateAlphaToCoverageEnable(int32 enable) {
 }
 
 void GLBackend::do_setStateBlend(State::BlendFunction function, Vec4 factor ) {
-    if (function._enabled) {
+    if (function.isEnabled()) {
         glEnable(GL_BLEND);
 
         static GLenum GL_BLEND_OPS[] = {
@@ -331,7 +333,8 @@ void GLBackend::do_setStateBlend(State::BlendFunction function, Vec4 factor ) {
             GL_MIN,
             GL_MAX };
 
-        glBlendEquationSeparate(GL_BLEND_OPS[function._operationColor], GL_BLEND_OPS[function._operationAlpha]);
+        glBlendEquationSeparate(GL_BLEND_OPS[function.getOperationColor()], GL_BLEND_OPS[function.getOperationAlpha()]);
+        CHECK_GL_ERROR();
 
         static GLenum BLEND_ARGS[] = {
             GL_ZERO,
@@ -351,14 +354,15 @@ void GLBackend::do_setStateBlend(State::BlendFunction function, Vec4 factor ) {
             GL_ONE_MINUS_CONSTANT_ALPHA,
         };
 
-        glBlendFuncSeparate(BLEND_ARGS[function._sourceColor], BLEND_ARGS[function._destinationColor],
+        glBlendFuncSeparate(BLEND_ARGS[function.getSourceColor()], BLEND_ARGS[function.getDestinationColor()],
-                            BLEND_ARGS[function._sourceAlpha], BLEND_ARGS[function._destinationAlpha]);
+                            BLEND_ARGS[function.getSourceAlpha()], BLEND_ARGS[function.getDestinationAlpha()]);
+        CHECK_GL_ERROR();
 
         glBlendColor(factor.x, factor.y, factor.z, factor.w);
+        CHECK_GL_ERROR();
     } else {
         glDisable(GL_BLEND);
     }
-    CHECK_GL_ERROR();
 }
 
 void GLBackend::do_setStateColorWriteMask(int32 mask) {

libraries/gpu/src/gpu/State.cpp

@@ -14,35 +14,8 @@
 
 using namespace gpu;
 
-
+State::State() {
-State::~State()
-{
 }
 
-void State::set(Field field, bool value) {
+State::~State() {
-     _fields[field]._integer = value;
+}
-    _stamp++;
-}
-
-void State::set(Field field, uint32 value) {
-    _fields[field]._unsigned_integer = value;
-    _stamp++;
-}
-
-void State::set(Field field, int32 value) {
-    _fields[field]._integer = value;
-    _stamp++;
-}
-
-void State::set(Field field, float value) {
-    _fields[field]._float = value;
-    _stamp++;
-}
-
-State::Value State::get(Field field) const {
-    auto found = _fields.find(field);
-    if (found != _fields.end()) {
-        return (*found).second;
-    }
-    return Value();
-}

libraries/gpu/src/gpu/State.h

@@ -23,7 +23,7 @@ class GPUObject;
 
 class State {
 public:
-    State() {}
+    State();
     virtual ~State();
 
     const Stamp getStamp() const { return _stamp; }
@@ -144,72 +144,105 @@ public:
     };
 
     class DepthTest {
-    public:
         uint8 _function = LESS;
         bool _writeMask = true;
         bool _enabled = false;
-
+    public:
         DepthTest(bool enabled, bool writeMask, ComparisonFunction func) : 
             _function(func), _writeMask(writeMask), _enabled(enabled) {}
 
+        bool isEnabled() const { return _enabled; }
+        ComparisonFunction getFunction() const { return ComparisonFunction(_function); }
+        bool getWriteMask() const { return _writeMask; }
 
         int32 getRaw() const { return *(reinterpret_cast<const int32*>(this)); }
         DepthTest(int32 raw) { *(reinterpret_cast<int32*>(this)) = raw; }
    };
 
-     class StencilTest {
+     class StencilTest {
+        static const int FUNC_MASK = 0x000f;
+        static const int FAIL_OP_MASK = 0x00f0;
+        static const int DEPTH_FAIL_OP_MASK = 0x0f00;
+        static const int PASS_OP_MASK = 0xf000;
+        static const int FAIL_OP_OFFSET = 4;
+        static const int DEPTH_FAIL_OP_OFFSET = 8;
+        static const int PASS_OP_OFFSET = 12;
+
+        uint16 _functionAndOperations;
+        uint8 _reference = 0;
+        uint8 _readMask = 0xff;
      public:
-        uint8 _reference;
+
-        uint8 _readMask;
-        int8 _function : 4;
-        int8 _failOp : 4;
-        int8 _depthFailOp : 4;
-        int8 _passOp : 4;
- 
         StencilTest(uint8 reference = 0, uint8 readMask =0xFF, ComparisonFunction func = ALWAYS, StencilOp failOp = STENCIL_OP_KEEP, StencilOp depthFailOp = STENCIL_OP_KEEP, StencilOp passOp = STENCIL_OP_KEEP) :
-            _reference(reference), _readMask(readMask), _function(func), _failOp(failOp), _depthFailOp(depthFailOp), _passOp(passOp) {}
+            _reference(reference), _readMask(readMask),
- 
+            _functionAndOperations(func | (failOp << FAIL_OP_OFFSET) | (depthFailOp << DEPTH_FAIL_OP_OFFSET) | (passOp << PASS_OP_OFFSET)) {}
+
+        ComparisonFunction getFunction() const { return ComparisonFunction(_functionAndOperations & FUNC_MASK); }
+        StencilOp getFailOp() const { return StencilOp((_functionAndOperations & FAIL_OP_MASK) >> FAIL_OP_OFFSET); }
+        StencilOp getDepthFailOp() const { return StencilOp((_functionAndOperations & DEPTH_FAIL_OP_MASK) >> DEPTH_FAIL_OP_OFFSET); }
+        StencilOp getPassOp() const { return StencilOp((_functionAndOperations & PASS_OP_MASK) >> PASS_OP_OFFSET); }
+
+        uint8 getReference() const { return _reference; }
+        uint8 getReadMask() const { return _readMask; }
+
         int32 getRaw() const { return *(reinterpret_cast<const int32*>(this)); }
         StencilTest(int32 raw) { *(reinterpret_cast<int32*>(this)) = raw; }
      };
 
      class StencilActivation {
+        uint8 _frontWriteMask = 0xFF;
+        uint8 _backWriteMask = 0xFF;
+        uint16 _enabled = 0;
      public:
-        uint8 _frontWriteMask;
+
-        uint8 _backWriteMask;
-        int16 _enabled;
- 
         StencilActivation(bool enabled, uint8 frontWriteMask = 0xFF, uint8 backWriteMask = 0xFF) :
             _frontWriteMask(frontWriteMask), _backWriteMask(backWriteMask), _enabled(enabled) {}
 
+        bool isEnabled() const { return (_enabled != 0); }
+        uint8 getWriteMaskFront() const { return _frontWriteMask; }
+        uint8 getWriteMaskBack() const { return _backWriteMask; }
+
         int32 getRaw() const { return *(reinterpret_cast<const int32*>(this)); }
         StencilActivation(int32 raw) { *(reinterpret_cast<int32*>(this)) = raw; }
     };
 
 
     class BlendFunction {
+        static const int COLOR_MASK = 0x0f;
+        static const int ALPHA_MASK = 0xf0;
+        static const int ALPHA_OFFSET = 4;
+
+        uint8 _enabled;
+        uint8 _source;
+        uint8 _destination;
+        uint8 _operation;
     public:
-        int8 _enabled;
-        int8 _sourceColor : 4;
-        int8 _sourceAlpha : 4;
-        int8 _destinationColor : 4;
-        int8 _destinationAlpha : 4;
-        int8 _operationColor : 4;
-        int8 _operationAlpha : 4;
 
         BlendFunction(bool enabled,
             BlendArg sourceColor, BlendOp operationColor, BlendArg destinationColor,
             BlendArg sourceAlpha, BlendOp operationAlpha, BlendArg destinationAlpha) :
             _enabled(enabled),
-            _sourceColor(sourceColor), _operationColor(operationColor), _destinationColor(destinationColor),
+            _source(sourceColor | (sourceAlpha << ALPHA_OFFSET)),
-            _sourceAlpha(sourceAlpha), _operationAlpha(operationAlpha), _destinationAlpha(destinationAlpha) {}
+            _destination(destinationColor | (destinationAlpha << ALPHA_OFFSET)),
+            _operation(operationColor | (operationAlpha << ALPHA_OFFSET)) {}
 
-        BlendFunction(bool enabled, BlendArg source, BlendOp operation, BlendArg destination) :
+        BlendFunction(bool enabled, BlendArg source = ONE, BlendOp operation = BLEND_OP_ADD, BlendArg destination = ZERO) :
             _enabled(enabled),
-            _sourceColor(source), _operationColor(operation), _destinationColor(destination),
+            _source(source | (source << ALPHA_OFFSET)),
-            _sourceAlpha(source), _operationAlpha(operation), _destinationAlpha(destination) {}
+            _destination(destination | (destination << ALPHA_OFFSET)),
+            _operation(operation | (operation << ALPHA_OFFSET)) {}
 
-        int32 raw() const { return *(reinterpret_cast<const int32*>(this)); }
+        bool isEnabled() const { return (_enabled != 0); }
+
+        BlendArg getSourceColor() const { return BlendArg(_source & COLOR_MASK); }
+        BlendArg getDestinationColor() const { return BlendArg(_destination & COLOR_MASK); }
+        BlendOp getOperationColor() const { return BlendOp(_operation & COLOR_MASK); }
+
+        BlendArg getSourceAlpha() const { return BlendArg((_source & ALPHA_MASK) >> ALPHA_OFFSET); }
+        BlendArg getDestinationAlpha() const { return BlendArg((_destination & ALPHA_MASK) >> ALPHA_OFFSET); }
+        BlendOp getOperationAlpha() const { return BlendOp((_operation & ALPHA_MASK) >> ALPHA_OFFSET); }
+
+        int32 getRaw() const { return *(reinterpret_cast<const int32*>(this)); }
         BlendFunction(int32 raw) { *(reinterpret_cast<int32*>(this)) = raw; }
     };
 
@@ -220,79 +253,124 @@ public:
             int32 _integer;
             float _float;
         };
+
+        template <typename T> void uncast(T v) { _integer = v; }
+        template <> void State::Value::uncast<int>(int v)  { _integer = v; }
+        template <> void State::Value::uncast<float>(float v)  { _float = v; }
+        template <> void State::Value::uncast<unsigned int>(unsigned int v)  { _unsigned_integer = v; }
+        template <> void State::Value::uncast<DepthTest>(DepthTest v) { _integer = v.getRaw(); }
+        template <> void State::Value::uncast<StencilActivation>(StencilActivation v) { _integer = v.getRaw(); }
+        template <> void State::Value::uncast<StencilTest>(StencilTest v) { _integer = v.getRaw(); }
+        template <> void State::Value::uncast<BlendFunction>(BlendFunction v) { _integer = v.getRaw(); }
+
+        template <typename T> T cast() const;
+        template <> int State::Value::cast<int>() const { return _integer; }
+        template <> float State::Value::cast<float>() const { return _float; }
+        template <> unsigned int State::Value::cast<unsigned int>() const { return _unsigned_integer; }
+        template <> DepthTest State::Value::cast<DepthTest>() const { return DepthTest(_integer); }
+        template <> StencilActivation State::Value::cast<StencilActivation>() const { return StencilActivation(_integer); }
+        template <> StencilTest State::Value::cast<StencilTest>() const { return StencilTest(_integer); }
+        template <> BlendFunction State::Value::cast<BlendFunction>() const { return BlendFunction(_integer); }
     };
     typedef std::unordered_map<Field, Value> FieldMap; 
 
     const FieldMap& getFields() const { return _fields; }
 
-    void set(Field field, bool value);
+    template <class T> void set(Field field, T value) {
-    void set(Field field, uint32 value);
+        _fields[field].uncast(value);
-    void set(Field field, int32 value);
+        _stamp++;
-    void set(Field field, float value);
+    }
 
-    Value get(Field field) const;
+    template <class T> T get(Field field, T defaultValue) const {
+        auto found = _fields.find(field);
+        if (found != _fields.end()) {
+            return (*found).second.cast<T>();
+        }
+        return defaultValue;
+    }
 
-    void setFillMode(FillMode fill) { set(FILL_MODE, uint32(fill)); }
+    void setFillMode(FillMode fill) { set(FILL_MODE, fill); }
-    FillMode getFillMode() const { return FillMode(get(FILL_MODE)._integer); }
+    FillMode getFillMode() const { return get(FILL_MODE, FILL_FACE); }
  
-    void setCullMode(CullMode cull)  { set(CULL_MODE, uint32(cull)); }
+    void setCullMode(CullMode cull)  { set(CULL_MODE, cull); }
-    CullMode getCullMode() const { return CullMode(get(CULL_MODE)._integer); }
+    CullMode getCullMode() const { return get(CULL_MODE, CULL_NONE); }
 
     void setFrontFace(bool isClockwise) { set(FRONT_FACE, isClockwise); }
-    void setDepthClipEnable(bool enable) { set(DEPTH_CLIP_ENABLE, enable); }
+    bool isFrontFaceClockwise() const { return get(FRONT_FACE, true); }
-    void setScissorEnable(bool enable) { set(SCISSOR_ENABLE, enable); }
-    void setMultisampleEnable(bool enable) { set(MULTISAMPLE_ENABLE, enable); }
-    void setAntialiasedLineEnable(bool enable) { set(ANTIALISED_LINE_ENABLE, enable); }
 
-    bool isFrontFaceClockwise() const { return get(FRONT_FACE)._integer; }
+    void setDepthClipEnable(bool enable) { set(DEPTH_CLIP_ENABLE, enable); }
-    bool isDepthClipEnable() const { return get(DEPTH_CLIP_ENABLE)._integer; }
+    bool isDepthClipEnable() const { return get(DEPTH_CLIP_ENABLE, false); }
-    bool isScissorEnable() const { return get(SCISSOR_ENABLE)._integer; }
+
-    bool isMultisampleEnable() const { return get(MULTISAMPLE_ENABLE)._integer; }
+    void setScissorEnable(bool enable) { set(SCISSOR_ENABLE, enable); }
-    bool isAntialiasedLineEnable() const { return get(ANTIALISED_LINE_ENABLE)._integer; }
+    bool isScissorEnable() const { return get(SCISSOR_ENABLE, false); }
+
+    void setMultisampleEnable(bool enable) { set(MULTISAMPLE_ENABLE, enable); }
+    bool isMultisampleEnable() const { return get(MULTISAMPLE_ENABLE, false); }
+
+    void setAntialiasedLineEnable(bool enable) { set(ANTIALISED_LINE_ENABLE, enable); }
+    bool isAntialiasedLineEnable() const { return get(ANTIALISED_LINE_ENABLE, true); }
 
+    // Depth Bias
     void setDepthBias(float bias) { set(DEPTH_BIAS, bias); }
     void setDepthBiasSlopeScale(float scale) { set(DEPTH_BIAS_SLOPE_SCALE, scale); }
-    float getDepthBias() const { return get(DEPTH_BIAS)._integer; }
+    float getDepthBias() const { return get(DEPTH_BIAS, 0.0f); }
-    float getDepthBiasSlopeScale() const { return get(DEPTH_BIAS_SLOPE_SCALE)._float; }
+    float getDepthBiasSlopeScale() const { return get(DEPTH_BIAS_SLOPE_SCALE, 1.0f); }
 
-    void setDepthTest(bool enable, bool writeMask, ComparisonFunction func) { set(DEPTH_TEST, DepthTest(enable, writeMask, func).getRaw()); }
+    // Depth Test
-    DepthTest getDepthTest() const { return DepthTest(get(DEPTH_TEST)._integer); }
+    void setDepthTest(DepthTest depthTest) { set(DEPTH_TEST, depthTest); }
-    bool isDepthTestEnabled() const { return getDepthTest()._enabled; }
+    void setDepthTest(bool enable, bool writeMask, ComparisonFunction func) { setDepthTest(DepthTest(enable, writeMask, func)); }
-    bool getDepthTestWriteMask() const { return getDepthTest()._writeMask; }
+    DepthTest getDepthTest() const { return get(DEPTH_TEST, DepthTest(false, true, LESS)); }
-    ComparisonFunction getDepthTestFunc() const { return ComparisonFunction(getDepthTest()._function); }
+
+    bool isDepthTestEnabled() const { return getDepthTest().isEnabled(); }
+    bool getDepthTestWriteMask() const { return getDepthTest().getWriteMask(); }
+    ComparisonFunction getDepthTestFunc() const { return getDepthTest().getFunction(); }
  
+    // Stencil test
     void setStencilTest(bool enabled, uint8 frontWriteMask, StencilTest frontTest, uint8 backWriteMask, StencilTest backTest) {
-        set(STENCIL_ACTIVATION, StencilActivation(enabled, frontWriteMask, backWriteMask).getRaw());
+        set(STENCIL_ACTIVATION, StencilActivation(enabled, frontWriteMask, backWriteMask));
-        set(STENCIL_TEST_FRONT, frontTest.getRaw()); set(STENCIL_TEST_BACK, backTest.getRaw());
+        set(STENCIL_TEST_FRONT, frontTest);
-    }
+        set(STENCIL_TEST_BACK, backTest); }
-    void setStencilTest(bool enabled, uint8 frontWriteMask, StencilTest frontTest) { setStencilTest(enabled, frontWriteMask, frontTest, frontWriteMask, frontTest); }
+    void setStencilTest(bool enabled, uint8 frontWriteMask, StencilTest frontTest) {
+        setStencilTest(enabled, frontWriteMask, frontTest, frontWriteMask, frontTest); }
 
-    StencilActivation getStencilActivation() const { return StencilActivation(get(STENCIL_ACTIVATION)._integer); }
+    StencilActivation getStencilActivation() const { return get(STENCIL_ACTIVATION, StencilActivation(false)); }
-    bool isStencilEnabled() const { return getStencilActivation()._enabled != 0; }
+    bool isStencilEnabled() const { return getStencilActivation().isEnabled(); }
-    uint8 getStencilWriteMaskFront() const { return getStencilActivation()._frontWriteMask; }
+    uint8 getStencilWriteMaskFront() const { return getStencilActivation().getWriteMaskFront(); }
-    uint8 getStencilWriteMaskBack() const { return getStencilActivation()._backWriteMask; }
+    uint8 getStencilWriteMaskBack() const { return getStencilActivation().getWriteMaskBack(); }
-    StencilTest getStencilTestFront() const { return StencilTest(get(STENCIL_TEST_FRONT)._integer); }
-    StencilTest getStencilTestBack() const { return StencilTest(get(STENCIL_TEST_BACK)._integer); }
 
+    StencilTest getStencilTestFront() const { return get(STENCIL_TEST_FRONT, StencilTest()); }
+    StencilTest getStencilTestBack() const { return get(STENCIL_TEST_BACK, StencilTest()); }
+
+    // Alpha to coverage
     void setAlphaToCoverageEnable(bool enable) { set(ALPHA_TO_COVERAGE_ENABLE, enable); }
-    bool isAlphaToCoverageEnabled() const { return get(ALPHA_TO_COVERAGE_ENABLE)._integer; }
+    bool isAlphaToCoverageEnabled() const { return get(ALPHA_TO_COVERAGE_ENABLE, false); }
 
+    // Sample mask
     void setSampleMask(uint32 mask) { set(SAMPLE_MASK, mask); }
-    uint32 getSampleMask() const { return get(SAMPLE_MASK)._unsigned_integer; }
+    uint32 getSampleMask() const { return get<uint32>(SAMPLE_MASK, 0xFFFFFFFF); }
  
-    void setBlendFunction(BlendFunction function) { set(BLEND_FUNCTION, function.raw()); }
+    // Blend
-    void setBlendFunction(bool enabled, BlendArg sourceColor, BlendOp operationColor, BlendArg destinationColor,
+    void setBlendFunction(BlendFunction function) { set(BLEND_FUNCTION, function); }
-                          BlendArg sourceAlpha, BlendOp operationAlpha, BlendArg destinationAlpha) {
+    void setBlendFunction(bool enabled, BlendArg sourceColor, BlendOp operationColor, BlendArg destinationColor, BlendArg sourceAlpha, BlendOp operationAlpha, BlendArg destinationAlpha) {
-        setBlendFunction(BlendFunction(enabled, sourceColor, operationColor, destinationColor, sourceAlpha, operationAlpha, destinationAlpha)); }
+         setBlendFunction(BlendFunction(enabled, sourceColor, operationColor, destinationColor, sourceAlpha, operationAlpha, destinationAlpha)); }
-    void setBlendFunction(bool enabled, BlendArg source, BlendOp operation, BlendArg destination) {
+    void setBlendFunction(bool enabled, BlendArg source, BlendOp operation, BlendArg destination) { 
         setBlendFunction(BlendFunction(enabled, source, operation, destination)); }
-    bool isBlendEnabled() const { return BlendFunction(get(BLEND_FUNCTION)._integer)._enabled; }
+    BlendFunction getBlendFunction() const { return get(BLEND_FUNCTION, BlendFunction(false)); }
-    BlendFunction getBlendFunction() const { return BlendFunction(get(BLEND_FUNCTION)._integer); } 
+
-    void setBlendFactor(const Vec4& factor) { set(BLEND_FACTOR_X, factor.x); set(BLEND_FACTOR_Y, factor.y); set(BLEND_FACTOR_Z, factor.z); set(BLEND_FACTOR_W, factor.w); }
+    bool isBlendEnabled() const { return getBlendFunction().isEnabled(); }
-    Vec4 getBlendFactor() const { return Vec4(get(BLEND_FACTOR_X)._float, get(BLEND_FACTOR_Y)._float, get(BLEND_FACTOR_Z)._float, get(BLEND_FACTOR_W)._float); }
+
+    void setBlendFactor(const Vec4& factor) {
+        set(BLEND_FACTOR_X, factor.x);
+        set(BLEND_FACTOR_Y, factor.y);
+        set(BLEND_FACTOR_Z, factor.z);
+        set(BLEND_FACTOR_W, factor.w); }
+    Vec4 State::getBlendFactor() const {
+        return Vec4(get(BLEND_FACTOR_X, 0.0f), get(BLEND_FACTOR_Y, 0.0f), get(BLEND_FACTOR_Z, 0.0f), get(BLEND_FACTOR_W, 0.0f));
+    }
 
+    // Color write mask
     void setColorWriteMask(int32 mask) { set(COLOR_WRITE_MASK, mask); }
-    int32 getColorWriteMask() const { return ColorMask(get(COLOR_WRITE_MASK)._integer); }
+    uint32 getColorWriteMask() const { return get<uint32>(COLOR_WRITE_MASK, WRITE_ALL); }
 
 protected:
     State(const State& state);
@@ -309,8 +387,9 @@ protected:
     friend class Backend;
 };
 
+
 typedef std::shared_ptr< State > StatePointer;
-typedef std::vector< StatePointer > States;
+typedef std::vector< StatePointer > States;
 
 };
 

libraries/render-utils/src/Model.cpp

@@ -816,6 +816,9 @@ bool Model::renderCore(float alpha, RenderMode mode, RenderArgs* args) {
     GLBATCH(glBindBuffer)(GL_ELEMENT_ARRAY_BUFFER, 0);
     GLBATCH(glBindTexture)(GL_TEXTURE_2D, 0);
 
+    // Back to no program
+    GLBATCH(glUseProgram)(0);
+
     // Render!
     {
         PROFILE_RANGE("render Batch");
@@ -1873,6 +1876,10 @@ void Model::endScene(RenderMode mode, RenderArgs* args) {
         GLBATCH(glBindBuffer)(GL_ARRAY_BUFFER, 0);
         GLBATCH(glBindBuffer)(GL_ELEMENT_ARRAY_BUFFER, 0);
         GLBATCH(glBindTexture)(GL_TEXTURE_2D, 0);
+
+        // Back to no program
+        GLBATCH(glUseProgram)(0);
+
     if (args) {
         args->_translucentMeshPartsRendered = translucentParts;
         args->_opaqueMeshPartsRendered = opaqueMeshPartsRendered;
@@ -2295,7 +2302,7 @@ int Model::renderMeshesForModelsInScene(gpu::Batch& batch, RenderMode mode, bool
     }
     // if we selected a program, then unselect it
     if (!pickProgramsNeeded) {
-        GLBATCH(glUseProgram)(0);
+ //       GLBATCH(glUseProgram)(0);
     }
     return meshPartsRendered;
 }
@@ -2325,7 +2332,7 @@ int Model::renderMeshes(gpu::Batch& batch, RenderMode mode, bool translucent, fl
                                 args, locations);
     meshPartsRendered = renderMeshesFromList(list, batch, mode, translucent, alphaThreshold, 
                                 args, locations, forceRenderSomeMeshes);
-    GLBATCH(glUseProgram)(0);
+   // GLBATCH(glUseProgram)(0);
 
     return meshPartsRendered;
 }