Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-06 18:50:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

code review

Browse source
This commit is contained in:
Seth Alves 2015-10-05 11:28:59 -07:00
parent a737b4024d
commit 993111d22f
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
interface/src/InterfaceActionFactory.cpp
View file

@ -65,9 +65,9 @@ EntityActionPointer InterfaceActionFactory::factoryBA(EntityItemPointer ownerEnt
if (action) { if (action) {
action->deserialize(data); action->deserialize(data);
} if (action->lifetimeIsOver()) {
if (action->lifetimeIsOver()) { return nullptr;
return nullptr; }
} }
return action; return action;

3
libraries/entities/src/EntityItem.cpp
View file

@ -1661,13 +1661,14 @@ void EntityItem::deserializeActionsInternal() {
// TODO: make sure types match? there isn't currently a way to // TODO: make sure types match? there isn't currently a way to
// change the type of an existing action. // change the type of an existing action.
action->deserialize(serializedAction); action->deserialize(serializedAction);
action->locallyAddedButNotYetReceived = false;
} else { } else {
auto actionFactory = DependencyManager::get<EntityActionFactoryInterface>(); auto actionFactory = DependencyManager::get<EntityActionFactoryInterface>();
EntityItemPointer entity = shared_from_this(); EntityItemPointer entity = shared_from_this();
EntityActionPointer action = actionFactory->factoryBA(entity, serializedAction); EntityActionPointer action = actionFactory->factoryBA(entity, serializedAction);
if (action) { if (action) {
action->locallyAddedButNotYetReceived = false;
entity->addActionInternal(simulation, action); entity->addActionInternal(simulation, action);
action->locallyAddedButNotYetReceived = false;
} }
} }
} }