Cleanup the confusion of using null-resampler for channel conversion

This commit is contained in:
Ken Cooke 2016-09-14 08:22:18 -07:00
parent c555e369c8
commit 96313a421c

View file

@ -823,15 +823,14 @@ void AudioClient::handleLocalEchoAndReverb(QByteArray& inputByteArray) {
int16_t* inputSamples = reinterpret_cast<int16_t*>(inputByteArray.data()); int16_t* inputSamples = reinterpret_cast<int16_t*>(inputByteArray.data());
int16_t* loopbackSamples = reinterpret_cast<int16_t*>(loopBackByteArray.data()); int16_t* loopbackSamples = reinterpret_cast<int16_t*>(loopBackByteArray.data());
auto NO_RESAMPLER = nullptr; // upmix mono to stereo
possibleResampling(NO_RESAMPLER, if (!sampleChannelConversion(inputSamples, loopbackSamples, numInputSamples, _inputFormat, _outputFormat)) {
inputSamples, loopbackSamples, // no conversion, just copy the samples
numInputSamples, numLoopbackSamples, memcpy(loopbackSamples, inputSamples, numInputSamples * sizeof(int16_t));
_inputFormat, _outputFormat); }
// apply stereo reverb at the source, to the loopback audio // apply stereo reverb at the source, to the loopback audio
if (!_shouldEchoLocally && hasReverb) { if (!_shouldEchoLocally && hasReverb) {
assert(_outputFormat.channelCount() == 2);
updateReverbOptions(); updateReverbOptions();
_sourceReverb.render(loopbackSamples, loopbackSamples, numLoopbackSamples/2); _sourceReverb.render(loopbackSamples, loopbackSamples, numLoopbackSamples/2);
} }