From 9187a680cd200f1703239055bdd86c299ebc0f37 Mon Sep 17 00:00:00 2001 From: Heather Anderson Date: Fri, 10 Apr 2020 17:10:41 -0700 Subject: [PATCH] Apply suggestions from code review Adding suggested changes from ctrlaltdavid Co-Authored-By: David Rowe --- interface/src/ui/PreferencesDialog.cpp | 2 +- libraries/networking/src/UserActivityLogger.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/interface/src/ui/PreferencesDialog.cpp b/interface/src/ui/PreferencesDialog.cpp index 5791a06b85..4ce30063e2 100644 --- a/interface/src/ui/PreferencesDialog.cpp +++ b/interface/src/ui/PreferencesDialog.cpp @@ -262,7 +262,7 @@ void setupPreferences() { auto getter = []()->bool { return !Menu::getInstance()->isOptionChecked(MenuOption::DisableCrashLogger); }; auto setter = [](bool value) { Menu::getInstance()->setIsOptionChecked(MenuOption::DisableCrashLogger, !value); }; preferences->addPreference(new CheckPreference("Privacy", "Send crashes - Vircadia uses information provided by your " - "client to improve the product through crash events. By allowing Vircadia to collect " + "client to improve the product through crash reports. By allowing Vircadia to collect " "this information you are helping to improve the product. ", getter, setter)); } diff --git a/libraries/networking/src/UserActivityLogger.h b/libraries/networking/src/UserActivityLogger.h index a9bc5a8509..881c287341 100644 --- a/libraries/networking/src/UserActivityLogger.h +++ b/libraries/networking/src/UserActivityLogger.h @@ -59,7 +59,7 @@ private slots: private: UserActivityLogger(); Setting::Handle _disabled { "UserActivityLoggerDisabled", true }; - Setting::Handle _crashDisabled { "CrashLoggerDisabled", true }; + Setting::Handle _crashDisabled { "CrashLoggerDisabled", false }; QElapsedTimer _timer; };