From 8d4f7f8a2a57ddb49bb83662f84729a967ffbea1 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Mon, 15 Jul 2013 09:26:19 -0700 Subject: [PATCH] CR feedback --- libraries/voxels/src/VoxelNode.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libraries/voxels/src/VoxelNode.cpp b/libraries/voxels/src/VoxelNode.cpp index 6a702e75ba..61a174f90b 100644 --- a/libraries/voxels/src/VoxelNode.cpp +++ b/libraries/voxels/src/VoxelNode.cpp @@ -363,16 +363,14 @@ float VoxelNode::furthestDistanceToCamera(const ViewFrustum& viewFrustum) const box.scale(TREE_SCALE); glm::vec3 furthestPoint = viewFrustum.getFurthestPointFromCamera(box); glm::vec3 temp = viewFrustum.getPosition() - furthestPoint; - float distanceSquared = glm::dot(temp, temp); - float distanceToVoxelCenter = sqrtf(distanceSquared); + float distanceToVoxelCenter = sqrtf(glm::dot(temp, temp)); return distanceToVoxelCenter; } float VoxelNode::distanceToCamera(const ViewFrustum& viewFrustum) const { glm::vec3 center = _box.getCenter() * (float)TREE_SCALE; glm::vec3 temp = viewFrustum.getPosition() - center; - float distanceSquared = glm::dot(temp, temp); - float distanceToVoxelCenter = sqrtf(distanceSquared); + float distanceToVoxelCenter = sqrtf(glm::dot(temp, temp)); return distanceToVoxelCenter; } @@ -384,7 +382,6 @@ float VoxelNode::distanceSquareToPoint(const glm::vec3& point) const { float VoxelNode::distanceToPoint(const glm::vec3& point) const { glm::vec3 temp = point - _box.getCenter(); - float distanceSquare = glm::dot(temp, temp); - float distance = sqrtf(distanceSquare); + float distance = sqrtf(glm::dot(temp, temp)); return distance; }