From 8b0f59c9cfd032de2010d3d0cf1a9b93851f28a1 Mon Sep 17 00:00:00 2001
From: David Rowe <david@ctrlaltstudio.com>
Date: Sat, 25 Jun 2016 13:12:16 +1200
Subject: [PATCH] Fix users window minimized state not being remembered

---
 scripts/system/users.js | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/scripts/system/users.js b/scripts/system/users.js
index 92a05b30fd..afc3ac2de4 100644
--- a/scripts/system/users.js
+++ b/scripts/system/users.js
@@ -370,7 +370,7 @@ var usersWindow = (function () {
         // +ve x, y values are offset from left, top of screen; -ve from right, bottom.
 
         isVisible = true,
-        isMinimized = false,
+        isMinimized = true,
         isBorderVisible = false,
 
         viewport,
@@ -388,6 +388,12 @@ var usersWindow = (function () {
         scrollbarBarClickedAt, // 0.0 .. 1.0
         scrollbarValue = 0.0; // 0.0 .. 1.0
 
+    function isValueTrue(value) {
+        // Work around Boolean Settings values being read as string when Interface starts up but as Booleans when re-read after
+        // Being written if refresh script.
+        return value === true || value === "true";
+    }
+
     function calculateWindowHeight() {
         var AUDIO_METER_HEIGHT = 52,
             MIRROR_HEIGHT = 220,
@@ -664,6 +670,7 @@ var usersWindow = (function () {
             }
         });
         updateOverlayVisibility();
+        Settings.setValue(SETTING_USERS_WINDOW_MINIMIZED, isMinimized);
     }
 
     function onMenuItemEvent(event) {
@@ -1121,12 +1128,10 @@ var usersWindow = (function () {
         pollUsers();
 
         // Set minimized at end - setup code does not handle `minimized == false` correctly
-        setMinimized(Settings.getValue(SETTING_USERS_WINDOW_MINIMIZED, false));
+        setMinimized(isValueTrue(Settings.getValue(SETTING_USERS_WINDOW_MINIMIZED, false)));
     }
 
     function tearDown() {
-        Settings.setValue(SETTING_USERS_WINDOW_MINIMIZED, isMinimized);
-
         Menu.removeMenuItem(MENU_NAME, MENU_ITEM);
 
         Script.clearTimeout(usersTimer);