Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-09 01:36:56 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

use conditional bindings to avoid intermediate binding states

Browse source
This commit is contained in:
beholder 2017-11-10 19:39:51 +03:00
parent 908faa1334
commit 87519cd26f
1 changed files with 10 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
interface/resources/qml/hifi/tablet/TabletMenuItem.qml
View file

@ -40,37 +40,29 @@ Item {
CheckBox { CheckBox {
id: checkbox id: checkbox
// FIXME: Should use radio buttons if source.exclusiveGroup.
width: 20 width: 20
visible: source !== null ? visible: source !== null ?
source.visible && source.type === 1 && source.checkable && !source.exclusiveGroup : source.visible && source.type === 1 && source.checkable && !source.exclusiveGroup :
false false
checked: setChecked()
function setChecked() { Binding on checked {
if (!source || source.type !== 1 || !source.checkable) { value: source.checked;
return false; when: source && source.type === 1 && source.checkable && !source.exclusiveGroup;
}
// FIXME this works for native QML menus but I don't think it will
// for proxied QML menus
return source.checked;
} }
} }
RadioButton { RadioButton {
id: radiobutton id: radiobutton
// FIXME: Should use radio buttons if source.exclusiveGroup.
width: 20 width: 20
visible: source !== null ? visible: source !== null ?
source.visible && source.type === 1 && source.checkable && source.exclusiveGroup : source.visible && source.type === 1 && source.checkable && source.exclusiveGroup :
false false
checked: setChecked()
function setChecked() { Binding on checked {
if (!source || source.type !== 1 || !source.checkable) { value: source.checked;
return false; when: source && source.type === 1 && source.checkable && source.exclusiveGroup;
}
// FIXME this works for native QML menus but I don't think it will
// for proxied QML menus
return source.checked;
} }
} }
} }