Don't call Settings::set when you don't need too.

This commit is contained in:
Atlante45 2015-01-20 17:54:11 -08:00
parent e1725d1eee
commit 850f92eae3
3 changed files with 15 additions and 7 deletions

View file

@ -25,8 +25,10 @@ OctreeQuery::OctreeQuery() {
}
void OctreeQuery::setMaxOctreePacketsPerSecond(int maxOctreePPS) {
_maxOctreePPS = maxOctreePPS;
SettingHandles::maxOctreePacketsPerSecond.set(_maxOctreePPS);
if (maxOctreePPS != _maxOctreePPS) {
_maxOctreePPS = maxOctreePPS;
SettingHandles::maxOctreePacketsPerSecond.set(_maxOctreePPS);
}
}

View file

@ -44,12 +44,16 @@ void ViewFrustum::setOrientation(const glm::quat& orientationAsQuaternion) {
}
void ViewFrustum::setFieldOfView(float f) {
_fieldOfView = f;
SettingHandles::fieldOfView.set(f);
if (f != _fieldOfView) {
_fieldOfView = f;
SettingHandles::fieldOfView.set(f);
}
}
void ViewFrustum::setRealWorldFieldOfView(float realWorldFieldOfView) {
_realWorldFieldOfView = realWorldFieldOfView;
SettingHandles::realWorldFieldOfView.set(realWorldFieldOfView);
if (realWorldFieldOfView != _realWorldFieldOfView) {
_realWorldFieldOfView = realWorldFieldOfView;
SettingHandles::realWorldFieldOfView.set(realWorldFieldOfView);
}
}
// ViewFrustum::calculateViewFrustum()

View file

@ -101,7 +101,9 @@ T SettingHandle<T>::getDefault() const {
template <typename T> inline
void SettingHandle<T>::set(const T& value) const {
SettingsBridge::setInSettings(_key, QVariant(value));
if (value != get()) {
SettingsBridge::setInSettings(_key, QVariant(value));
}
}
template <typename T> inline