From 8145e416f9edcd428374c4da29731f838ebc631a Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Mon, 17 Apr 2017 19:14:24 -0700 Subject: [PATCH] check both sides of range for invalid byte range --- assignment-client/src/assets/SendAssetTask.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assignment-client/src/assets/SendAssetTask.cpp b/assignment-client/src/assets/SendAssetTask.cpp index 4a49deabde..3196c12d97 100644 --- a/assignment-client/src/assets/SendAssetTask.cpp +++ b/assignment-client/src/assets/SendAssetTask.cpp @@ -74,7 +74,7 @@ void SendAssetTask::run() { byteRange.toExclusive = file.size(); } - if (file.size() < std::abs(byteRange.toExclusive)) { + if (file.size() < std::abs(byteRange.fromInclusive) || file.size() < byteRange.toExclusive) { replyPacketList->writePrimitive(AssetServerError::InvalidByteRange); qCDebug(networking) << "Bad byte range: " << hexHash << " " << byteRange.fromInclusive << ":" << byteRange.toExclusive;