From 80c781bcdcf38062e842dbde66af861acb4c338c Mon Sep 17 00:00:00 2001 From: Sam Cake Date: Mon, 10 Apr 2017 22:17:12 -0700 Subject: [PATCH] Fixing warning on mac and more description of the Task class --- libraries/render/src/render/FilterTask.cpp | 3 --- libraries/render/src/render/Task.h | 8 ++++++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libraries/render/src/render/FilterTask.cpp b/libraries/render/src/render/FilterTask.cpp index 68422a021c..22d5feffe4 100644 --- a/libraries/render/src/render/FilterTask.cpp +++ b/libraries/render/src/render/FilterTask.cpp @@ -37,9 +37,6 @@ void FilterLayeredItems::run(const SceneContextPointer& sceneContext, const Rend } void SliceItems::run(const SceneContextPointer& sceneContext, const RenderContextPointer& renderContext, const ItemBounds& inItems, ItemBounds& outItems) { - auto& scene = sceneContext->_scene; - - // Now we have a selection of items to render outItems.clear(); std::static_pointer_cast(renderContext->jobConfig)->setNumItems((int)inItems.size()); diff --git a/libraries/render/src/render/Task.h b/libraries/render/src/render/Task.h index adebc77af3..03824bd14d 100644 --- a/libraries/render/src/render/Task.h +++ b/libraries/render/src/render/Task.h @@ -570,8 +570,12 @@ protected: }; // A task is a specialized job to run a collection of other jobs -// It is defined with JobModel = Task::Model - +// It can be created on any type T by aliasing the type JobModel in the class T +// using JobModel = Task::Model +// The class T is expected to have a "build" method acting as a constructor. +// The build method is where child Jobs can be added internally to the task +// where the input of the task can be setup to feed the child jobs +// and where the output of the task is defined class Task : public Job { public: using Config = TaskConfig;