diff --git a/interface/src/ui/overlays/Overlays.cpp b/interface/src/ui/overlays/Overlays.cpp index 1beee24fd5..399c730dbd 100644 --- a/interface/src/ui/overlays/Overlays.cpp +++ b/interface/src/ui/overlays/Overlays.cpp @@ -67,19 +67,14 @@ void Overlays::init() { } void Overlays::update(float deltatime) { - QMap overlaysHUD; - QMap overlaysWorld; { QMutexLocker locker(&_mutex); - overlaysHUD = _overlaysHUD; - overlaysWorld = _overlaysWorld; - } - - foreach(const auto& thisOverlay, overlaysHUD) { - thisOverlay->update(deltatime); - } - foreach(const auto& thisOverlay, overlaysWorld) { - thisOverlay->update(deltatime); + foreach(const auto& thisOverlay, _overlaysHUD) { + thisOverlay->update(deltatime); + } + foreach(const auto& thisOverlay, _overlaysWorld) { + thisOverlay->update(deltatime); + } } cleanupOverlaysToDelete(); @@ -119,14 +114,8 @@ void Overlays::renderHUD(RenderArgs* renderArgs) { int height = size.y; mat4 legacyProjection = glm::ortho(0, width, height, 0, -1000, 1000); - QMap overlaysHUD; - { - QMutexLocker locker(&_mutex); - overlaysHUD = _overlaysHUD; - } - - - foreach(Overlay::Pointer thisOverlay, overlaysHUD) { + QMutexLocker locker(&_mutex); + foreach(Overlay::Pointer thisOverlay, _overlaysHUD) { // Reset all batch pipeline settings between overlay geometryCache->useSimpleDrawPipeline(batch); @@ -400,36 +389,22 @@ OverlayID Overlays::getOverlayAtPoint(const glm::vec2& point) { return result; } - glm::vec2 pointCopy = point; if (!_enabled) { return UNKNOWN_OVERLAY_ID; } - QMap overlaysHUD; - { - QMutexLocker locker(&_mutex); - overlaysHUD = _overlaysHUD; - } - QMapIterator i(overlaysHUD); - - const float LARGE_NEGATIVE_FLOAT = -9999999; - glm::vec3 origin(pointCopy.x, pointCopy.y, LARGE_NEGATIVE_FLOAT); - glm::vec3 direction(0, 0, 1); - glm::vec3 thisSurfaceNormal; + QMutexLocker locker(&_mutex); + QMapIterator i(_overlaysHUD); unsigned int bestStackOrder = 0; OverlayID bestOverlayID = UNKNOWN_OVERLAY_ID; - while (i.hasNext()) { i.next(); - OverlayID thisID = i.key(); - if (!i.value()->is3D()) { - auto thisOverlay = std::dynamic_pointer_cast(i.value()); - if (thisOverlay && thisOverlay->getVisible() && thisOverlay->isLoaded() && - thisOverlay->getBoundingRect().contains(pointCopy.x, pointCopy.y, false)) { - if (thisOverlay->getStackOrder() > bestStackOrder) { - bestOverlayID = thisID; - bestStackOrder = thisOverlay->getStackOrder(); - } + auto thisOverlay = std::dynamic_pointer_cast(i.value()); + if (thisOverlay && thisOverlay->getVisible() && thisOverlay->isLoaded() && + thisOverlay->getBoundingRect().contains(point.x, point.y, false)) { + if (thisOverlay->getStackOrder() > bestStackOrder) { + bestOverlayID = i.key(); + bestStackOrder = thisOverlay->getStackOrder(); } } } @@ -498,14 +473,9 @@ RayToOverlayIntersectionResult Overlays::findRayIntersectionInternal(const PickR float bestDistance = std::numeric_limits::max(); bool bestIsFront = false; - QMap overlaysWorld; - { - QMutexLocker locker(&_mutex); - overlaysWorld = _overlaysWorld; - } - + QMutexLocker locker(&_mutex); RayToOverlayIntersectionResult result; - QMapIterator i(overlaysWorld); + QMapIterator i(_overlaysWorld); while (i.hasNext()) { i.next(); OverlayID thisID = i.key(); @@ -995,13 +965,8 @@ QVector Overlays::findOverlays(const glm::vec3& center, float radius) { return result; } - QMap overlaysWorld; - { - QMutexLocker locker(&_mutex); - overlaysWorld = _overlaysWorld; - } - - QMapIterator i(overlaysWorld); + QMutexLocker locker(&_mutex); + QMapIterator i(_overlaysWorld); int checked = 0; while (i.hasNext()) { checked++; diff --git a/libraries/model-networking/src/model-networking/TextureCache.cpp b/libraries/model-networking/src/model-networking/TextureCache.cpp index 5c8f59f20f..20749cd567 100644 --- a/libraries/model-networking/src/model-networking/TextureCache.cpp +++ b/libraries/model-networking/src/model-networking/TextureCache.cpp @@ -198,11 +198,7 @@ gpu::TexturePointer TextureCache::getTextureByHash(const std::string& hash) { std::unique_lock lock(_texturesByHashesMutex); weakPointer = _texturesByHashes[hash]; } - auto result = weakPointer.lock(); - if (result) { - qCWarning(modelnetworking) << "QQQ Returning live texture for hash " << hash.c_str(); - } - return result; + return weakPointer.lock(); } gpu::TexturePointer TextureCache::cacheTextureByHash(const std::string& hash, const gpu::TexturePointer& texture) { diff --git a/libraries/script-engine/src/ScriptEngine.cpp b/libraries/script-engine/src/ScriptEngine.cpp index b51cb0ee3b..3a876a0e0a 100644 --- a/libraries/script-engine/src/ScriptEngine.cpp +++ b/libraries/script-engine/src/ScriptEngine.cpp @@ -1821,7 +1821,7 @@ void ScriptEngine::include(const QStringList& includeFiles, QScriptValue callbac clearExceptions(); } } else { - scriptWarningMessage("Script.include() skipping evaluation of previously included url:" + url.toString()); + scriptPrintedMessage("Script.include() skipping evaluation of previously included url:" + url.toString()); } } }