From 7f120febbd6c356f71d7581fe08828aa90109768 Mon Sep 17 00:00:00 2001
From: Howard Stearns <howard@highfidelity.io>
Date: Sat, 29 Apr 2017 15:50:04 -0700
Subject: [PATCH] fix that

---
 scripts/system/makeUserConnection.js | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/scripts/system/makeUserConnection.js b/scripts/system/makeUserConnection.js
index 57a9764e6e..c2d86e71fd 100644
--- a/scripts/system/makeUserConnection.js
+++ b/scripts/system/makeUserConnection.js
@@ -261,6 +261,19 @@
     }
 
     var animationData = {};
+    function updateAnimationData() {
+        // all we are doing here is moving the right hand to a spot
+        // that is in front of and a bit above the hips.  Basing how
+        // far in front as scaling with the avatar's height (say hips
+        // to head distance)
+        var headIndex = MyAvatar.getJointIndex("Head");
+        var offset = 0.5; // default distance of hand in front of you
+        if (headIndex) {
+            offset = 0.8 * MyAvatar.getAbsoluteJointTranslationInObjectFrame(headIndex).y;
+        }
+        animationData.rightHandPosition = Vec3.multiply(offset, {x: -0.25, y: 0.8, z: 1.3});
+        animationData.rightHandRotation = Quat.fromPitchYawRollDegrees(90, 0, 90);
+    }
     function shakeHandsAnimation() {
         return animationData;
     }
@@ -273,20 +286,7 @@
     function startHandshakeAnimation() {
         endHandshakeAnimation(); // just in case order of press/unpress is broken
         debug("adding animation");
-
-        // all we are doing here is moving the right hand to a spot
-        // that is in front of and a bit above the hips.  Basing how
-        // far in front as scaling with the avatar's height (say hips
-        // to head distance)
-        var headIndex = MyAvatar.getJointIndex("Head");
-        var offset = 0.5; // default distance of hand in front of you
-        var result = {};
-        if (headIndex) {
-            offset = 0.8 * MyAvatar.getAbsoluteJointTranslationInObjectFrame(headIndex).y;
-        }
-        result.rightHandPosition = Vec3.multiply(offset, {x: -0.25, y: 0.8, z: 1.3});
-        result.rightHandRotation = Quat.fromPitchYawRollDegrees(90, 0, 90);
-
+        updateAnimationData();
         animHandlerId = MyAvatar.addAnimationStateHandler(shakeHandsAnimation, []);
     }