Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-04-19 12:23:24 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Tidy FIXME

Browse source
This commit is contained in:
David Rowe 2017-04-26 10:16:35 +12:00
parent c83f82f5da
commit 7c2e1aa846
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
interface/src/Application.cpp
View file

@ -747,7 +747,7 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo
audioIO->handleRecordedAudioInput(frame->data);
});
// FIXME
// FIXME: Recorder::recordFrame() doesn't handle data in the following format.
/*
connect(audioIO.data(), &AudioClient::inputReceived, [](const QByteArray& audio){
static auto recorder = DependencyManager::get<recording::Recorder>();
@ -757,7 +757,7 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo
}
});
*/
connect(audioIO.data(), &AudioClient::inputReceivedBytes, [](const QByteArray audio){
connect(audioIO.data(), &AudioClient::inputReceivedBuffer, [](const QByteArray& audio){
static auto recorder = DependencyManager::get<recording::Recorder>();
if (recorder->isRecording()) {
static const recording::FrameType AUDIO_FRAME_TYPE = recording::Frame::registerFrameType(AudioConstants::getAudioFrameName());

2
libraries/audio-client/src/AudioClient.cpp
View file

@ -1007,7 +1007,7 @@ void AudioClient::handleAudioInput(QByteArray& audioBuffer) {
}
emit inputReceived({ audioBuffer.data(), numSamples });
emit inputReceivedBytes(audioBuffer); // FIXME
emit inputReceivedBuffer(audioBuffer); // FIXME: Almost a duplicate of inputReceived().
if (_noiseGate.openedInLastBlock()) {
emit noiseGateOpened();

2
libraries/audio-client/src/AudioClient.h
View file

@ -225,7 +225,7 @@ signals:
bool muteToggled();
void mutedByMixer();
void inputReceived(const QByteArray& inputSamples);
void inputReceivedBytes(const QByteArray inputSamples);
void inputReceivedBuffer(const QByteArray& inputSamples); // FIXME: Almost a duplicate of inputReceived().
void outputBytesToNetwork(int numBytes);
void inputBytesFromNetwork(int numBytes);
void noiseGateOpened();