diff --git a/interface/src/scripting/ControllerScriptingInterface.cpp b/interface/src/scripting/ControllerScriptingInterface.cpp index 1e35713e16..f05d1a41a6 100644 --- a/interface/src/scripting/ControllerScriptingInterface.cpp +++ b/interface/src/scripting/ControllerScriptingInterface.cpp @@ -154,7 +154,7 @@ controller::InputController::Pointer ControllerScriptingInterface::createInputCo if (trackerID >= 0) { controller::InputController::Pointer inputController = std::make_shared(deviceID, trackerID, this); controller::InputController::Key key = inputController->getKey(); - _inputControllers.insert(InputControllerMap::value_type(inputController->getKey(), inputController)); + _inputControllers.insert(InputControllerMap::value_type(key, inputController)); return inputController; } } diff --git a/libraries/controllers/src/controllers/Filter.cpp b/libraries/controllers/src/controllers/Filter.cpp index 43317fd62d..c9ff24fa78 100644 --- a/libraries/controllers/src/controllers/Filter.cpp +++ b/libraries/controllers/src/controllers/Filter.cpp @@ -89,9 +89,9 @@ PulseFilter::FactoryEntryBuilder PulseFilter::_factoryEntryBuilder; float PulseFilter::apply(float value) const { - float result = 0.0; + float result = 0.0f; - if (0.0 != value) { + if (0.0f != value) { float now = secTimestampNow(); float delta = now - _lastEmitTime; if (delta >= _interval) { diff --git a/libraries/controllers/src/controllers/ScriptingInterface.cpp b/libraries/controllers/src/controllers/ScriptingInterface.cpp index 3e470fd365..dc305c4c6e 100644 --- a/libraries/controllers/src/controllers/ScriptingInterface.cpp +++ b/libraries/controllers/src/controllers/ScriptingInterface.cpp @@ -96,7 +96,7 @@ namespace controller { : Endpoint(UserInputMapper::Input(UserInputMapper::Input::INVALID_INPUT)), Pair(first, second) { } virtual float value() { - float result = first->value() * -1.0 + second->value(); + float result = first->value() * -1.0f + second->value(); return result; } @@ -324,7 +324,6 @@ namespace controller { float value = getValue(source); // Apply each of the filters. - const auto& filters = route->_filters; for (const auto& filter : route->_filters) { value = filter->apply(value); } @@ -406,7 +405,7 @@ namespace controller { } bool ScriptingInterface::isButtonPressed(int buttonIndex) const { - return getButtonValue((StandardButtonChannel)buttonIndex) == 0.0 ? false : true; + return getButtonValue((StandardButtonChannel)buttonIndex) == 0.0f ? false : true; } int ScriptingInterface::getNumberOfTriggers() const { diff --git a/libraries/controllers/src/controllers/impl/RouteBuilderProxy.h b/libraries/controllers/src/controllers/impl/RouteBuilderProxy.h index 8e3b3404cc..66b5e85394 100644 --- a/libraries/controllers/src/controllers/impl/RouteBuilderProxy.h +++ b/libraries/controllers/src/controllers/impl/RouteBuilderProxy.h @@ -52,10 +52,9 @@ class RouteBuilderProxy : public QObject { void to(const Endpoint::Pointer& destination); void addFilter(Filter::Lambda lambda); void addFilter(Filter::Pointer filter); + ScriptingInterface& _parent; Mapping::Pointer _mapping; Route::Pointer _route; - - ScriptingInterface& _parent; }; }