From 303026d86bb4c30c78aec9099b4a4def634f0f07 Mon Sep 17 00:00:00 2001 From: Atlante45 Date: Tue, 9 Jun 2015 15:26:41 +0200 Subject: [PATCH 1/3] Reduce qDebug calls --- libraries/entities/src/LineEntityItem.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libraries/entities/src/LineEntityItem.cpp b/libraries/entities/src/LineEntityItem.cpp index bb1e3be539..e7e1c90b41 100644 --- a/libraries/entities/src/LineEntityItem.cpp +++ b/libraries/entities/src/LineEntityItem.cpp @@ -86,6 +86,7 @@ bool LineEntityItem::setProperties(const EntityItemProperties& properties) { void LineEntityItem::setLinePoints(const QVector& points) { QVector sanitizedPoints; + int invalidPoints = 0; for (int i = 0; i < points.size(); i++) { glm::vec3 point = points.at(i); // Make sure all of our points are valid numbers. @@ -93,9 +94,12 @@ void LineEntityItem::setLinePoints(const QVector& points) { if (point.x > 0 && point.y > 0 && point.z > 0){ sanitizedPoints << point; } else { - qDebug() << "INVALID POINT"; + ++invalidPoints; } } + if (invalidPoints > 0) { + qDebug() << "Line with" << invalidPoints << "INVALID POINTS"; + } _points = sanitizedPoints; _pointsChanged = true; } From 90c9a82aeb889423c65de73d42025c6f6b30b31a Mon Sep 17 00:00:00 2001 From: Atlante45 Date: Tue, 9 Jun 2015 15:27:08 +0200 Subject: [PATCH 2/3] Remove unnecesary debug --- libraries/render-utils/src/Model.cpp | 3 --- libraries/render-utils/src/Model.h | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/libraries/render-utils/src/Model.cpp b/libraries/render-utils/src/Model.cpp index aadc4bffbe..c0be64cf61 100644 --- a/libraries/render-utils/src/Model.cpp +++ b/libraries/render-utils/src/Model.cpp @@ -913,8 +913,6 @@ bool Model::addToScene(std::shared_ptr scene, render::PendingChan bool somethingAdded = false; - qDebug() << "Model::addToScene : " << this->getURL().toString(); - // allow the attachments to add to scene foreach (Model* attachment, _attachments) { bool attachementSomethingAdded = attachment->addToScene(scene, pendingChanges); @@ -954,7 +952,6 @@ void Model::removeFromScene(std::shared_ptr scene, render::Pendin } _renderItems.clear(); _readyWhenAdded = false; - qDebug() << "Model::removeFromScene : " << this->getURL().toString(); } bool Model::render(RenderArgs* renderArgs, float alpha) { diff --git a/libraries/render-utils/src/Model.h b/libraries/render-utils/src/Model.h index 0367ad8d32..6f751a5f8d 100644 --- a/libraries/render-utils/src/Model.h +++ b/libraries/render-utils/src/Model.h @@ -312,8 +312,7 @@ protected: float getLimbLength(int jointIndex) const; /// Allow sub classes to force invalidating the bboxes - void invalidCalculatedMeshBoxes() { - qDebug() << "invalidCalculatedMeshBoxes()"; + void invalidCalculatedMeshBoxes() { _calculatedMeshBoxesValid = false; _calculatedMeshPartBoxesValid = false; _calculatedMeshTrianglesValid = false; From bf56ee49a63807e7dd1193830ff05336b3972899 Mon Sep 17 00:00:00 2001 From: Atlante45 Date: Tue, 9 Jun 2015 16:37:48 +0200 Subject: [PATCH 3/3] Print new URL only when it actually changes --- libraries/entities-renderer/src/RenderableWebEntityItem.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/entities-renderer/src/RenderableWebEntityItem.cpp b/libraries/entities-renderer/src/RenderableWebEntityItem.cpp index 3d284baab6..94f88b8390 100644 --- a/libraries/entities-renderer/src/RenderableWebEntityItem.cpp +++ b/libraries/entities-renderer/src/RenderableWebEntityItem.cpp @@ -191,8 +191,8 @@ void RenderableWebEntityItem::render(RenderArgs* args) { } void RenderableWebEntityItem::setSourceUrl(const QString& value) { - qDebug() << "Setting web entity source URL to " << value; if (_sourceUrl != value) { + qDebug() << "Setting web entity source URL to " << value; _sourceUrl = value; if (_webSurface) { AbstractViewStateInterface::instance()->postLambdaEvent([this] {