From a2da59271df5a90fe47896cb0f80718b758b83b0 Mon Sep 17 00:00:00 2001 From: Simon Walton Date: Wed, 6 Feb 2019 11:38:48 -0800 Subject: [PATCH 1/4] If sorting PAL by loudness re-sort upon loudness updates --- interface/resources/qml/hifi/Pal.qml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/interface/resources/qml/hifi/Pal.qml b/interface/resources/qml/hifi/Pal.qml index b7b412b577..9fe5ac3ac2 100644 --- a/interface/resources/qml/hifi/Pal.qml +++ b/interface/resources/qml/hifi/Pal.qml @@ -1247,6 +1247,9 @@ Rectangle { } } } + if (nearbyTable.sortIndicatorColumn == 0) { // Current sort by loudness so re-sort. + sortModel(); + } break; case 'clearLocalQMLData': ignored = {}; From 58d8945aa5df46978147dfdbec80106310e5d92d Mon Sep 17 00:00:00 2001 From: Simon Walton Date: Wed, 6 Feb 2019 14:41:27 -0800 Subject: [PATCH 2/4] Limit re-sort rate to 2 Hz. --- interface/resources/qml/hifi/Pal.qml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/interface/resources/qml/hifi/Pal.qml b/interface/resources/qml/hifi/Pal.qml index 9fe5ac3ac2..92c608fa3c 100644 --- a/interface/resources/qml/hifi/Pal.qml +++ b/interface/resources/qml/hifi/Pal.qml @@ -42,6 +42,8 @@ Rectangle { property var activeTab: "nearbyTab"; property bool currentlyEditingDisplayName: false property bool punctuationMode: false; + property double loudSortTime: 0.0; + readonly property double kLOUD_SORT_PERIOD_MS: 500.0; HifiConstants { id: hifi; } RootHttpRequest { id: http; } @@ -1247,8 +1249,10 @@ Rectangle { } } } - if (nearbyTable.sortIndicatorColumn == 0) { // Current sort by loudness so re-sort. + if (nearbyTable.sortIndicatorColumn == 0 && Date.now() - pal.loudSortTime >= pal.kLOUD_SORT_PERIOD_MS) { + // Current sort by loudness so re-sort. sortModel(); + pal.loudSortTime = Date.now(); } break; case 'clearLocalQMLData': From 4f2223ced3452f9aaeb2b60ba92372e3cb3bc44c Mon Sep 17 00:00:00 2001 From: Simon Walton <36682372+SimonWalton-HiFi@users.noreply.github.com> Date: Mon, 11 Feb 2019 14:17:55 -0800 Subject: [PATCH 3/4] Change max update to 10 Hz --- interface/resources/qml/hifi/Pal.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface/resources/qml/hifi/Pal.qml b/interface/resources/qml/hifi/Pal.qml index 92c608fa3c..7c22b98dc2 100644 --- a/interface/resources/qml/hifi/Pal.qml +++ b/interface/resources/qml/hifi/Pal.qml @@ -43,7 +43,7 @@ Rectangle { property bool currentlyEditingDisplayName: false property bool punctuationMode: false; property double loudSortTime: 0.0; - readonly property double kLOUD_SORT_PERIOD_MS: 500.0; + readonly property double kLOUD_SORT_PERIOD_MS: 100.0; HifiConstants { id: hifi; } RootHttpRequest { id: http; } From 73296aa986cd4a92ee99ed218b92dfc6c82ac8c3 Mon Sep 17 00:00:00 2001 From: Simon Walton <36682372+SimonWalton-HiFi@users.noreply.github.com> Date: Mon, 11 Feb 2019 16:59:18 -0800 Subject: [PATCH 4/4] Change update rate to 1 Hz --- interface/resources/qml/hifi/Pal.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface/resources/qml/hifi/Pal.qml b/interface/resources/qml/hifi/Pal.qml index 7c22b98dc2..1c190a2b79 100644 --- a/interface/resources/qml/hifi/Pal.qml +++ b/interface/resources/qml/hifi/Pal.qml @@ -43,7 +43,7 @@ Rectangle { property bool currentlyEditingDisplayName: false property bool punctuationMode: false; property double loudSortTime: 0.0; - readonly property double kLOUD_SORT_PERIOD_MS: 100.0; + readonly property double kLOUD_SORT_PERIOD_MS: 1000.0; HifiConstants { id: hifi; } RootHttpRequest { id: http; }