Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-08 19:36:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix MS15574: Tiny memory leak in Wallet.h

Browse source
This commit is contained in:
Zach Fox 2018-06-04 14:13:25 -07:00
parent 64cccc55d4
commit 7407507f0b
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
interface/src/commerce/Wallet.cpp
View file

@ -314,6 +314,7 @@ Wallet::Wallet() {
auto nodeList = DependencyManager::get<NodeList>(); auto nodeList = DependencyManager::get<NodeList>();
auto ledger = DependencyManager::get<Ledger>(); auto ledger = DependencyManager::get<Ledger>();
auto& packetReceiver = nodeList->getPacketReceiver(); auto& packetReceiver = nodeList->getPacketReceiver();
_passphrase = new QString("");
packetReceiver.registerListener(PacketType::ChallengeOwnership, this, "handleChallengeOwnershipPacket"); packetReceiver.registerListener(PacketType::ChallengeOwnership, this, "handleChallengeOwnershipPacket");
packetReceiver.registerListener(PacketType::ChallengeOwnershipRequest, this, "handleChallengeOwnershipPacket"); packetReceiver.registerListener(PacketType::ChallengeOwnershipRequest, this, "handleChallengeOwnershipPacket");
@ -359,6 +360,7 @@ void Wallet::clear() {
// tell the provider we got nothing // tell the provider we got nothing
updateImageProvider(); updateImageProvider();
_passphrase->clear(); _passphrase->clear();
delete _passphrase;
} }
Wallet::~Wallet() { Wallet::~Wallet() {

2
interface/src/commerce/Wallet.h
View file

@ -78,7 +78,7 @@ private:
QByteArray _salt; QByteArray _salt;
QByteArray _iv; QByteArray _iv;
QByteArray _ckey; QByteArray _ckey;
QString* _passphrase { new QString("") }; QString* _passphrase { nullptr };
bool _isOverridingServer { false }; bool _isOverridingServer { false };
bool writeWallet(const QString& newPassphrase = QString("")); bool writeWallet(const QString& newPassphrase = QString(""));