From a613da8032939171af048475ea143b08caf049d3 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Mon, 24 Mar 2014 21:25:59 -0700 Subject: [PATCH 01/12] add Script.include() --- examples/includeExample.js | 16 ++++++ libraries/script-engine/src/ScriptEngine.cpp | 55 +++++++++++++++++++- libraries/script-engine/src/ScriptEngine.h | 8 +-- 3 files changed, 75 insertions(+), 4 deletions(-) create mode 100644 examples/includeExample.js diff --git a/examples/includeExample.js b/examples/includeExample.js new file mode 100644 index 0000000000..489928d759 --- /dev/null +++ b/examples/includeExample.js @@ -0,0 +1,16 @@ +// +// includeExample.js +// hifi +// +// Created by Brad Hefta-Gaub on 3/24/14 +// Copyright (c) 2013 HighFidelity, Inc. All rights reserved. +// +// This is an example script that demonstrates use of the Script.include() feature +// + +// You can include scripts from URLs +Script.include("http://public.highfidelity.io/scripts/lookWithTouch.js"); + +// You can also include scripts that are relative to the current script +Script.include("editVoxels.js"); +Script.include("../examples/selectAudioDevice.js"); diff --git a/libraries/script-engine/src/ScriptEngine.cpp b/libraries/script-engine/src/ScriptEngine.cpp index 38948071ff..834cb33158 100644 --- a/libraries/script-engine/src/ScriptEngine.cpp +++ b/libraries/script-engine/src/ScriptEngine.cpp @@ -113,11 +113,12 @@ void ScriptEngine::cleanupMenuItems() { } } -bool ScriptEngine::setScriptContents(const QString& scriptContents) { +bool ScriptEngine::setScriptContents(const QString& scriptContents, const QString& fileNameString) { if (_isRunning) { return false; } _scriptContents = scriptContents; + _fileNameString = fileNameString; return true; } @@ -436,3 +437,55 @@ void ScriptEngine::stopTimer(QTimer *timer) { delete timer; } } + +QUrl ScriptEngine::resolveInclude(const QString& include) const { + // first lets check to see if it's already a full URL + QUrl url(include); + if (!url.scheme().isEmpty()) { + return url; + } + + // we apparently weren't a fully qualified url, so, let's assume we're relative + // to the original URL of our script + QUrl parentURL(_fileNameString); + + // if the parent URL's scheme is empty, then this is probably a local file... + if (parentURL.scheme().isEmpty()) { + parentURL = QUrl::fromLocalFile(_fileNameString); + } + + // at this point we should have a legitimate fully qualified URL for our parent + url = parentURL.resolved(url); + return url; +} + +void ScriptEngine::include(const QString& includeFile) { + QUrl url = resolveInclude(includeFile); + QString includeContents; + + if (url.scheme() == "file") { + QString fileName = url.toLocalFile(); + QFile scriptFile(fileName); + if (scriptFile.open(QFile::ReadOnly | QFile::Text)) { + qDebug() << "Loading file:" << fileName; + QTextStream in(&scriptFile); + includeContents = in.readAll(); + } else { + qDebug() << "ERROR Loading file:" << fileName; + } + } else { + QNetworkAccessManager* networkManager = new QNetworkAccessManager(this); + QNetworkReply* reply = networkManager->get(QNetworkRequest(url)); + qDebug() << "Downloading included script at" << includeFile; + QEventLoop loop; + QObject::connect(reply, SIGNAL(finished()), &loop, SLOT(quit())); + loop.exec(); + includeContents = reply->readAll(); + } + + QScriptValue result = _engine.evaluate(includeContents); + if (_engine.hasUncaughtException()) { + int line = _engine.uncaughtExceptionLineNumber(); + qDebug() << "Uncaught exception at (" << includeFile << ") line" << line << ":" << result.toString(); + } +} diff --git a/libraries/script-engine/src/ScriptEngine.h b/libraries/script-engine/src/ScriptEngine.h index 755418b0c1..2afe7b475b 100644 --- a/libraries/script-engine/src/ScriptEngine.h +++ b/libraries/script-engine/src/ScriptEngine.h @@ -33,8 +33,8 @@ const unsigned int SCRIPT_DATA_CALLBACK_USECS = floor(((1.0 / 60.0f) * 1000 * 10 class ScriptEngine : public QObject { Q_OBJECT public: - ScriptEngine(const QString& scriptContents = NO_SCRIPT, bool wantMenuItems = false, - const QString& scriptMenuName = QString(""), + ScriptEngine(const QString& scriptContents = NO_SCRIPT, bool wantMenuItems = false, + const QString& fileNameString = QString(""), AbstractControllerScriptingInterface* controllerScriptingInterface = NULL); /// Access the VoxelsScriptingInterface in order to initialize it with a custom packet sender and jurisdiction listener @@ -44,7 +44,7 @@ public: static ParticlesScriptingInterface* getParticlesScriptingInterface() { return &_particlesScriptingInterface; } /// sets the script contents, will return false if failed, will fail if script is already running - bool setScriptContents(const QString& scriptContents); + bool setScriptContents(const QString& scriptContents, const QString& fileNameString = QString("")); const QString& getScriptMenuName() const { return _scriptMenuName; } void cleanupMenuItems(); @@ -75,6 +75,7 @@ public slots: QObject* setTimeout(const QScriptValue& function, int timeoutMS); void clearInterval(QObject* timer) { stopTimer(reinterpret_cast(timer)); } void clearTimeout(QObject* timer) { stopTimer(reinterpret_cast(timer)); } + void include(const QString& includeFile); signals: void update(float deltaTime); @@ -97,6 +98,7 @@ protected: int _numAvatarSoundSentBytes; private: + QUrl resolveInclude(const QString& include) const; void sendAvatarIdentityPacket(); void sendAvatarBillboardPacket(); From c34b64e296bdd2d92c9feae9e4b8b99e01e4eb57 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Tue, 25 Mar 2014 00:17:19 -0700 Subject: [PATCH 02/12] add load script from URL support --- interface/src/Application.cpp | 58 +++++++++------- interface/src/Application.h | 1 + interface/src/Menu.cpp | 2 + interface/src/Menu.h | 5 +- libraries/script-engine/src/ScriptEngine.cpp | 71 ++++++++++++++++++-- libraries/script-engine/src/ScriptEngine.h | 5 ++ 6 files changed, 112 insertions(+), 30 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 2ca4ef74cd..8bcfb5151b 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -3508,35 +3509,17 @@ void Application::cleanupScriptMenuItem(const QString& scriptMenuName) { Menu::getInstance()->removeAction(Menu::getInstance()->getActiveScriptsMenu(), scriptMenuName); } -void Application::loadScript(const QString& fileNameString) { - QByteArray fileNameAscii = fileNameString.toLocal8Bit(); - const char* fileName = fileNameAscii.data(); - - std::ifstream file(fileName, std::ios::in|std::ios::binary|std::ios::ate); - if(!file.is_open()) { - qDebug("Error loading file %s", fileName); - return; - } - qDebug("Loading file %s...", fileName); - _activeScripts.append(fileNameString); - - // get file length.... - unsigned long fileLength = file.tellg(); - file.seekg( 0, std::ios::beg ); - - // read the entire file into a buffer, WHAT!? Why not. - char* entireFile = new char[fileLength+1]; - file.read((char*)entireFile, fileLength); - file.close(); - - entireFile[fileLength] = 0;// null terminate - QString script(entireFile); - delete[] entireFile; +void Application::loadScript(const QString& scriptName) { // start the script on a new thread... bool wantMenuItems = true; // tells the ScriptEngine object to add menu items for itself + ScriptEngine* scriptEngine = new ScriptEngine(QUrl(scriptName), wantMenuItems, &_controllerScriptingInterface); - ScriptEngine* scriptEngine = new ScriptEngine(script, wantMenuItems, fileName, &_controllerScriptingInterface); + if (!scriptEngine->hasScript()) { + qDebug() << "Application::loadScript(), script failed to load..."; + return; + } + _activeScripts.append(scriptName); // add a stop menu item Menu::getInstance()->addActionToQMenuAndActionHash(Menu::getInstance()->getActiveScriptsMenu(), @@ -3599,6 +3582,31 @@ void Application::loadDialog() { loadScript(fileNameString); } +void Application::loadScriptURLDialog() { + + QInputDialog scriptURLDialog(Application::getInstance()->getWindow()); + scriptURLDialog.setWindowTitle("Open and Run Script URL"); + scriptURLDialog.setLabelText("Script:"); + scriptURLDialog.setWindowFlags(Qt::Sheet); + const float DIALOG_RATIO_OF_WINDOW = 0.30f; + scriptURLDialog.resize(scriptURLDialog.parentWidget()->size().width() * DIALOG_RATIO_OF_WINDOW, + scriptURLDialog.size().height()); + + int dialogReturn = scriptURLDialog.exec(); + QString newScript; + if (dialogReturn == QDialog::Accepted) { + if (scriptURLDialog.textValue().size() > 0) { + // the user input a new hostname, use that + newScript = scriptURLDialog.textValue(); + } + loadScript(newScript); + } + + sendFakeEnterEvent(); +} + + + void Application::toggleLogDialog() { if (! _logDialog) { _logDialog = new LogDialog(_glWidget, getLogger()); diff --git a/interface/src/Application.h b/interface/src/Application.h index caeea529af..ccd07d41b6 100644 --- a/interface/src/Application.h +++ b/interface/src/Application.h @@ -254,6 +254,7 @@ public slots: void setRenderVoxels(bool renderVoxels); void doKillLocalVoxels(); void loadDialog(); + void loadScriptURLDialog(); void toggleLogDialog(); void initAvatarAndViewFrustum(); void stopAllScripts(); diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp index 7adef1be1c..49b839873f 100644 --- a/interface/src/Menu.cpp +++ b/interface/src/Menu.cpp @@ -107,6 +107,8 @@ Menu::Menu() : addDisabledActionAndSeparator(fileMenu, "Scripts"); addActionToQMenuAndActionHash(fileMenu, MenuOption::LoadScript, Qt::CTRL | Qt::Key_O, appInstance, SLOT(loadDialog())); + addActionToQMenuAndActionHash(fileMenu, MenuOption::LoadScriptURL, + Qt::CTRL | Qt::SHIFT | Qt::Key_O, appInstance, SLOT(loadScriptURLDialog())); addActionToQMenuAndActionHash(fileMenu, MenuOption::StopAllScripts, 0, appInstance, SLOT(stopAllScripts())); addActionToQMenuAndActionHash(fileMenu, MenuOption::ReloadAllScripts, 0, appInstance, SLOT(reloadAllScripts())); _activeScriptsMenu = fileMenu->addMenu("Running Scripts"); diff --git a/interface/src/Menu.h b/interface/src/Menu.h index cb0ca4c5c4..08887d7b18 100644 --- a/interface/src/Menu.h +++ b/interface/src/Menu.h @@ -272,7 +272,8 @@ namespace MenuOption { const QString OffAxisProjection = "Off-Axis Projection"; const QString OldVoxelCullingMode = "Old Voxel Culling Mode"; const QString TurnWithHead = "Turn using Head"; - const QString LoadScript = "Open and Run Script..."; + const QString LoadScript = "Open and Run Script File..."; + const QString LoadScriptURL = "Open and Run Script from URL..."; const QString Oscilloscope = "Audio Oscilloscope"; const QString Pair = "Pair"; const QString Particles = "Particles"; @@ -304,4 +305,6 @@ namespace MenuOption { const QString VoxelTextures = "Voxel Textures"; } +void sendFakeEnterEvent(); + #endif /* defined(__hifi__Menu__) */ diff --git a/libraries/script-engine/src/ScriptEngine.cpp b/libraries/script-engine/src/ScriptEngine.cpp index 834cb33158..9bd00a0019 100644 --- a/libraries/script-engine/src/ScriptEngine.cpp +++ b/libraries/script-engine/src/ScriptEngine.cpp @@ -64,13 +64,10 @@ ScriptEngine::ScriptEngine(const QString& scriptContents, bool wantMenuItems, co _quatLibrary(), _vec3Library() { - QByteArray fileNameAscii = fileNameString.toLocal8Bit(); - const char* scriptMenuName = fileNameAscii.data(); - // some clients will use these menu features if (!fileNameString.isEmpty()) { _scriptMenuName = "Stop "; - _scriptMenuName.append(scriptMenuName); + _scriptMenuName.append(qPrintable(fileNameString)); _scriptMenuName.append(QString(" [%1]").arg(_scriptNumber)); } else { _scriptMenuName = "Stop Script "; @@ -79,6 +76,72 @@ ScriptEngine::ScriptEngine(const QString& scriptContents, bool wantMenuItems, co _scriptNumber++; } +ScriptEngine::ScriptEngine(const QUrl& scriptURL, bool wantMenuItems, + AbstractControllerScriptingInterface* controllerScriptingInterface) : + _scriptContents(), + _isFinished(false), + _isRunning(false), + _isInitialized(false), + _engine(), + _isAvatar(false), + _avatarIdentityTimer(NULL), + _avatarBillboardTimer(NULL), + _timerFunctionMap(), + _isListeningToAudioStream(false), + _avatarSound(NULL), + _numAvatarSoundSentBytes(0), + _controllerScriptingInterface(controllerScriptingInterface), + _avatarData(NULL), + _wantMenuItems(wantMenuItems), + _scriptMenuName(), + _fileNameString(), + _quatLibrary(), + _vec3Library() +{ + QString scriptURLString = scriptURL.toString(); + _fileNameString = scriptURLString; + // some clients will use these menu features + if (!scriptURLString.isEmpty()) { + _scriptMenuName = "Stop "; + _scriptMenuName.append(qPrintable(scriptURLString)); + _scriptMenuName.append(QString(" [%1]").arg(_scriptNumber)); + } else { + _scriptMenuName = "Stop Script "; + _scriptMenuName.append(_scriptNumber); + } + _scriptNumber++; + + QUrl url(scriptURL); + + // if the scheme is empty, maybe they typed in a file, let's try + if (url.scheme().isEmpty()) { + url = QUrl::fromLocalFile(scriptURLString); + } + + // ok, let's see if it's valid... and if so, load it + if (url.isValid()) { + if (url.scheme() == "file") { + QString fileName = url.toLocalFile(); + QFile scriptFile(fileName); + if (scriptFile.open(QFile::ReadOnly | QFile::Text)) { + qDebug() << "Loading file:" << fileName; + QTextStream in(&scriptFile); + _scriptContents = in.readAll(); + } else { + qDebug() << "ERROR Loading file:" << fileName; + } + } else { + QNetworkAccessManager* networkManager = new QNetworkAccessManager(this); + QNetworkReply* reply = networkManager->get(QNetworkRequest(url)); + qDebug() << "Downloading included script at" << url; + QEventLoop loop; + QObject::connect(reply, SIGNAL(finished()), &loop, SLOT(quit())); + loop.exec(); + _scriptContents = reply->readAll(); + } + } +} + void ScriptEngine::setIsAvatar(bool isAvatar) { _isAvatar = isAvatar; diff --git a/libraries/script-engine/src/ScriptEngine.h b/libraries/script-engine/src/ScriptEngine.h index 2afe7b475b..4fc90d2959 100644 --- a/libraries/script-engine/src/ScriptEngine.h +++ b/libraries/script-engine/src/ScriptEngine.h @@ -33,6 +33,9 @@ const unsigned int SCRIPT_DATA_CALLBACK_USECS = floor(((1.0 / 60.0f) * 1000 * 10 class ScriptEngine : public QObject { Q_OBJECT public: + ScriptEngine(const QUrl& scriptURL, bool wantMenuItems = false, + AbstractControllerScriptingInterface* controllerScriptingInterface = NULL); + ScriptEngine(const QString& scriptContents = NO_SCRIPT, bool wantMenuItems = false, const QString& fileNameString = QString(""), AbstractControllerScriptingInterface* controllerScriptingInterface = NULL); @@ -68,6 +71,8 @@ public: void timerFired(); + bool hasScript() const { return !_scriptContents.isEmpty(); } + public slots: void stop(); From 571ecf096433ac0e19e1c48feea20d7f34dce1ef Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Tue, 25 Mar 2014 00:45:31 -0700 Subject: [PATCH 03/12] add first cut at firstrun support --- interface/src/Application.cpp | 24 ++++++++++++++++++++---- interface/src/Application.h | 1 + 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 8bcfb5151b..437f050c88 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -251,7 +251,7 @@ Application::Application(int& argc, char** argv, timeval &startup_time) : QMetaObject::invokeMethod(&accountManager, "checkAndSignalForAccessToken", Qt::QueuedConnection); _settings = new QSettings(this); - + // Check to see if the user passed in a command line option for loading a local // Voxel File. _voxelsFilename = getCmdOption(argc, constArgv, "-i"); @@ -330,9 +330,18 @@ Application::Application(int& argc, char** argv, timeval &startup_time) : LocalVoxelsList::getInstance()->addPersistantTree(DOMAIN_TREE_NAME, _voxels.getTree()); LocalVoxelsList::getInstance()->addPersistantTree(CLIPBOARD_TREE_NAME, &_clipboard); - - // do this as late as possible so that all required subsystems are inialized - loadScripts(); + + // check first run... + QVariant firstRunValue = _settings->value("firstRun",QVariant(true)); + if (firstRunValue.isValid() && firstRunValue.toBool()) { + qDebug() << "This is a first run..."; + // clear the scripts, and set out script to our default scripts + clearScriptsBeforeRunning(); + loadScript("http://public.highfidelity.io/scripts/defaultScripts.js"); + } else { + // do this as late as possible so that all required subsystems are inialized + loadScripts(); + } } Application::~Application() { @@ -3454,6 +3463,13 @@ void Application::loadScripts() { settings->endArray(); } +void Application::clearScriptsBeforeRunning() { + // clears all scripts from the settings + QSettings* settings = new QSettings(this); + settings->beginWriteArray("Settings"); + settings->endArray(); +} + void Application::saveScripts() { // saves all current running scripts QSettings* settings = new QSettings(this); diff --git a/interface/src/Application.h b/interface/src/Application.h index ccd07d41b6..15778f2a17 100644 --- a/interface/src/Application.h +++ b/interface/src/Application.h @@ -115,6 +115,7 @@ public: void loadScript(const QString& fileNameString); void loadScripts(); void storeSizeAndPosition(); + void clearScriptsBeforeRunning(); void saveScripts(); void initializeGL(); void paintGL(); From f10d5e23f8732ff5594eefb6723ddd7e3d3317db Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Tue, 25 Mar 2014 00:57:29 -0700 Subject: [PATCH 04/12] set firstRun so it only happens once --- interface/src/Application.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 437f050c88..13c05fa702 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -338,6 +338,8 @@ Application::Application(int& argc, char** argv, timeval &startup_time) : // clear the scripts, and set out script to our default scripts clearScriptsBeforeRunning(); loadScript("http://public.highfidelity.io/scripts/defaultScripts.js"); + + _settings->setValue("firstRun",QVariant(false)); } else { // do this as late as possible so that all required subsystems are inialized loadScripts(); From 7b50e6d4ef9362a2acb489d35a32094b8a7c2a67 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Tue, 25 Mar 2014 01:02:50 -0700 Subject: [PATCH 05/12] added hydraMove.js to default scripts --- examples/defaultScripts.js | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/defaultScripts.js b/examples/defaultScripts.js index 4b228492c7..eae3c2eb8c 100644 --- a/examples/defaultScripts.js +++ b/examples/defaultScripts.js @@ -3,3 +3,4 @@ Script.include("lookWithTouch.js"); Script.include("editVoxels.js"); Script.include("selectAudioDevice.js"); +Script.include("hydraMove.js"); \ No newline at end of file From d8bf5be68b99d768edbe8468b36ea14b77928929 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Tue, 25 Mar 2014 08:43:56 -0700 Subject: [PATCH 06/12] fix audio position in editVoxles.js --- examples/editVoxels.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/editVoxels.js b/examples/editVoxels.js index cb2553a8e3..5e4b77a10f 100644 --- a/examples/editVoxels.js +++ b/examples/editVoxels.js @@ -400,9 +400,9 @@ function calcScaleFromThumb(newThumbX) { } function setAudioPosition() { - var camera = Camera.getPosition(); + var position = MyAvatar.position; var forwardVector = Quat.getFront(MyAvatar.orientation); - audioOptions.position = Vec3.sum(camera, forwardVector); + audioOptions.position = Vec3.sum(position, forwardVector); } function getNewPasteVoxel(pickRay) { @@ -735,6 +735,7 @@ function trackKeyReleaseEvent(event) { if (event.text == "TAB") { editToolsOn = !editToolsOn; moveTools(); + setAudioPosition(); // make sure we set the audio position before playing sounds showPreviewGuides(); Audio.playSound(clickSound, audioOptions); } From e8b9594758215f74befd3491c5e5a9349ccbf562 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 09:39:43 -0700 Subject: [PATCH 07/12] spread out billboard and identity fallbacks --- assignment-client/src/avatars/AvatarMixer.cpp | 122 +++--------------- .../src/avatars/AvatarMixerClientData.cpp | 4 +- .../src/avatars/AvatarMixerClientData.h | 12 -- 3 files changed, 22 insertions(+), 116 deletions(-) diff --git a/assignment-client/src/avatars/AvatarMixer.cpp b/assignment-client/src/avatars/AvatarMixer.cpp index 0ec7c3e15e..34544af8ab 100644 --- a/assignment-client/src/avatars/AvatarMixer.cpp +++ b/assignment-client/src/avatars/AvatarMixer.cpp @@ -46,6 +46,8 @@ void attachAvatarDataToNode(Node* newNode) { } } +const float BILLBOARD_AND_IDENTITY_SEND_PROBABILITY = 1.0f / 300.0f; + // NOTE: some additional optimizations to consider. // 1) use the view frustum to cull those avatars that are out of view. Since avatar data doesn't need to be present // if the avatar is not in view or in the keyhole. @@ -99,6 +101,23 @@ void AvatarMixer::broadcastAvatarData() { // copy the avatar into the mixedAvatarByteArray packet mixedAvatarByteArray.append(avatarByteArray); + + if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY) { + QByteArray billboardPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarBillboard); + billboardPacket.append(otherNode->getUUID().toRfc4122()); + billboardPacket.append(otherNodeData->getAvatar().getBillboard()); + nodeList->writeDatagram(billboardPacket, node); + } + + if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY) { + QByteArray identityPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarIdentity); + + QByteArray individualData = otherNodeData->getAvatar().identityByteArray(); + individualData.replace(0, NUM_BYTES_RFC4122_UUID, otherNode->getUUID().toRfc4122()); + identityPacket.append(individualData); + + nodeList->writeDatagram(identityPacket, node); + } } } } @@ -108,66 +127,6 @@ void AvatarMixer::broadcastAvatarData() { } } -void broadcastIdentityPacket() { - - NodeList* nodeList = NodeList::getInstance(); - - QByteArray avatarIdentityPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarIdentity); - int numPacketHeaderBytes = avatarIdentityPacket.size(); - - foreach (const SharedNodePointer& node, nodeList->getNodeHash()) { - if (node->getLinkedData() && node->getType() == NodeType::Agent) { - - AvatarMixerClientData* nodeData = reinterpret_cast(node->getLinkedData()); - AvatarData& avatar = nodeData->getAvatar(); - QByteArray individualData = avatar.identityByteArray(); - individualData.replace(0, NUM_BYTES_RFC4122_UUID, node->getUUID().toRfc4122()); - - if (avatarIdentityPacket.size() + individualData.size() > MAX_PACKET_SIZE) { - // we've hit MTU, send out the current packet before appending - nodeList->broadcastToNodes(avatarIdentityPacket, NodeSet() << NodeType::Agent); - avatarIdentityPacket.resize(numPacketHeaderBytes); - } - - // append the individual data to the current the avatarIdentityPacket - avatarIdentityPacket.append(individualData); - - // re-set the bool in AvatarMixerClientData so a change between key frames gets sent out - nodeData->setHasSentIdentityBetweenKeyFrames(false); - } - } - - // send out the final packet - if (avatarIdentityPacket.size() > numPacketHeaderBytes) { - nodeList->broadcastToNodes(avatarIdentityPacket, NodeSet() << NodeType::Agent); - } -} - -void broadcastBillboardPacket(const SharedNodePointer& sendingNode) { - AvatarMixerClientData* nodeData = static_cast(sendingNode->getLinkedData()); - AvatarData& avatar = nodeData->getAvatar(); - QByteArray packet = byteArrayWithPopulatedHeader(PacketTypeAvatarBillboard); - packet.append(sendingNode->getUUID().toRfc4122()); - packet.append(avatar.getBillboard()); - - NodeList* nodeList = NodeList::getInstance(); - foreach (const SharedNodePointer& node, nodeList->getNodeHash()) { - if (node->getType() == NodeType::Agent && node != sendingNode) { - nodeList->writeDatagram(packet, node); - } - } -} - -void broadcastBillboardPackets() { - foreach (const SharedNodePointer& node, NodeList::getInstance()->getNodeHash()) { - if (node->getLinkedData() && node->getType() == NodeType::Agent) { - AvatarMixerClientData* nodeData = static_cast(node->getLinkedData()); - broadcastBillboardPacket(node); - nodeData->setHasSentBillboardBetweenKeyFrames(false); - } - } -} - void AvatarMixer::nodeKilled(SharedNodePointer killedNode) { if (killedNode->getType() == NodeType::Agent && killedNode->getLinkedData()) { @@ -202,19 +161,7 @@ void AvatarMixer::readPendingDatagrams() { if (avatarNode && avatarNode->getLinkedData()) { AvatarMixerClientData* nodeData = reinterpret_cast(avatarNode->getLinkedData()); AvatarData& avatar = nodeData->getAvatar(); - if (avatar.hasIdentityChangedAfterParsing(receivedPacket) - && !nodeData->hasSentIdentityBetweenKeyFrames()) { - // this avatar changed their identity in some way and we haven't sent a packet in this keyframe - QByteArray identityPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarIdentity); - - QByteArray individualByteArray = avatar.identityByteArray(); - individualByteArray.replace(0, NUM_BYTES_RFC4122_UUID, avatarNode->getUUID().toRfc4122()); - - identityPacket.append(individualByteArray); - - nodeData->setHasSentIdentityBetweenKeyFrames(true); - nodeList->broadcastToNodes(identityPacket, NodeSet() << NodeType::Agent); - } + avatar.hasIdentityChangedAfterParsing(receivedPacket); } break; } @@ -226,12 +173,7 @@ void AvatarMixer::readPendingDatagrams() { if (avatarNode && avatarNode->getLinkedData()) { AvatarMixerClientData* nodeData = static_cast(avatarNode->getLinkedData()); AvatarData& avatar = nodeData->getAvatar(); - if (avatar.hasBillboardChangedAfterParsing(receivedPacket) - && !nodeData->hasSentBillboardBetweenKeyFrames()) { - // this avatar changed their billboard and we haven't sent a packet in this keyframe - broadcastBillboardPacket(avatarNode); - nodeData->setHasSentBillboardBetweenKeyFrames(true); - } + avatar.hasBillboardChangedAfterParsing(receivedPacket); } break; } @@ -261,9 +203,6 @@ void AvatarMixer::sendStatsPacket() { _numStatFrames = 0; } -const qint64 AVATAR_IDENTITY_KEYFRAME_MSECS = 5000; -const qint64 AVATAR_BILLBOARD_KEYFRAME_MSECS = 5000; - void AvatarMixer::run() { ThreadedAssignment::commonInit(AVATAR_MIXER_LOGGING_NAME, NodeType::AvatarMixer); @@ -277,12 +216,6 @@ void AvatarMixer::run() { gettimeofday(&startTime, NULL); - QElapsedTimer identityTimer; - identityTimer.start(); - - QElapsedTimer billboardTimer; - billboardTimer.start(); - int usecToSleep = AVATAR_DATA_SEND_INTERVAL_USECS; const int TRAILING_AVERAGE_FRAMES = 100; @@ -338,19 +271,6 @@ void AvatarMixer::run() { broadcastAvatarData(); - if (identityTimer.elapsed() >= AVATAR_IDENTITY_KEYFRAME_MSECS) { - // it's time to broadcast the keyframe identity packets - broadcastIdentityPacket(); - - // restart the timer so we do it again in AVATAR_IDENTITY_KEYFRAME_MSECS - identityTimer.restart(); - } - - if (billboardTimer.elapsed() >= AVATAR_BILLBOARD_KEYFRAME_MSECS) { - broadcastBillboardPackets(); - billboardTimer.restart(); - } - QCoreApplication::processEvents(); if (_isFinished) { diff --git a/assignment-client/src/avatars/AvatarMixerClientData.cpp b/assignment-client/src/avatars/AvatarMixerClientData.cpp index 90088173a9..5847f72ffb 100644 --- a/assignment-client/src/avatars/AvatarMixerClientData.cpp +++ b/assignment-client/src/avatars/AvatarMixerClientData.cpp @@ -9,9 +9,7 @@ #include "AvatarMixerClientData.h" AvatarMixerClientData::AvatarMixerClientData() : - NodeData(), - _hasSentIdentityBetweenKeyFrames(false), - _hasSentBillboardBetweenKeyFrames(false) + NodeData() { } diff --git a/assignment-client/src/avatars/AvatarMixerClientData.h b/assignment-client/src/avatars/AvatarMixerClientData.h index 854e8172d3..9accc70291 100644 --- a/assignment-client/src/avatars/AvatarMixerClientData.h +++ b/assignment-client/src/avatars/AvatarMixerClientData.h @@ -20,21 +20,9 @@ public: AvatarMixerClientData(); int parseData(const QByteArray& packet); - - bool hasSentIdentityBetweenKeyFrames() const { return _hasSentIdentityBetweenKeyFrames; } - void setHasSentIdentityBetweenKeyFrames(bool hasSentIdentityBetweenKeyFrames) - { _hasSentIdentityBetweenKeyFrames = hasSentIdentityBetweenKeyFrames; } - - bool hasSentBillboardBetweenKeyFrames() const { return _hasSentBillboardBetweenKeyFrames; } - void setHasSentBillboardBetweenKeyFrames(bool hasSentBillboardBetweenKeyFrames) - { _hasSentBillboardBetweenKeyFrames = hasSentBillboardBetweenKeyFrames; } - AvatarData& getAvatar() { return _avatar; } private: - - bool _hasSentIdentityBetweenKeyFrames; - bool _hasSentBillboardBetweenKeyFrames; AvatarData _avatar; }; From e6b83ac52dda1a6a39951877c369f3ac27019ba4 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 10:34:38 -0700 Subject: [PATCH 08/12] send mesh and billboard on receiver's first connect --- assignment-client/src/avatars/AvatarMixer.cpp | 6 ++++-- assignment-client/src/avatars/AvatarMixerClientData.cpp | 9 ++++++++- assignment-client/src/avatars/AvatarMixerClientData.h | 5 ++++- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/assignment-client/src/avatars/AvatarMixer.cpp b/assignment-client/src/avatars/AvatarMixer.cpp index 34544af8ab..4d09228dd0 100644 --- a/assignment-client/src/avatars/AvatarMixer.cpp +++ b/assignment-client/src/avatars/AvatarMixer.cpp @@ -102,14 +102,16 @@ void AvatarMixer::broadcastAvatarData() { // copy the avatar into the mixedAvatarByteArray packet mixedAvatarByteArray.append(avatarByteArray); - if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY) { + bool forceSend = !myData->checkAndSetHasReceivedFirstPackets(); + + if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY || forceSend) { QByteArray billboardPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarBillboard); billboardPacket.append(otherNode->getUUID().toRfc4122()); billboardPacket.append(otherNodeData->getAvatar().getBillboard()); nodeList->writeDatagram(billboardPacket, node); } - if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY) { + if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY || forceSend) { QByteArray identityPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarIdentity); QByteArray individualData = otherNodeData->getAvatar().identityByteArray(); diff --git a/assignment-client/src/avatars/AvatarMixerClientData.cpp b/assignment-client/src/avatars/AvatarMixerClientData.cpp index 5847f72ffb..84db17ecf4 100644 --- a/assignment-client/src/avatars/AvatarMixerClientData.cpp +++ b/assignment-client/src/avatars/AvatarMixerClientData.cpp @@ -9,7 +9,8 @@ #include "AvatarMixerClientData.h" AvatarMixerClientData::AvatarMixerClientData() : - NodeData() + NodeData(), + _hasReceivedFirstPackets(false) { } @@ -19,3 +20,9 @@ int AvatarMixerClientData::parseData(const QByteArray& packet) { int offset = numBytesForPacketHeader(packet); return _avatar.parseDataAtOffset(packet, offset); } + +bool AvatarMixerClientData::checkAndSetHasReceivedFirstPackets() { + bool oldValue = _hasReceivedFirstPackets; + _hasReceivedFirstPackets = true; + return oldValue; +} diff --git a/assignment-client/src/avatars/AvatarMixerClientData.h b/assignment-client/src/avatars/AvatarMixerClientData.h index 9accc70291..5cf61659a7 100644 --- a/assignment-client/src/avatars/AvatarMixerClientData.h +++ b/assignment-client/src/avatars/AvatarMixerClientData.h @@ -21,9 +21,12 @@ public: int parseData(const QByteArray& packet); AvatarData& getAvatar() { return _avatar; } - + + bool checkAndSetHasReceivedFirstPackets(); + private: AvatarData _avatar; + bool _hasReceivedFirstPackets; }; #endif /* defined(__hifi__AvatarMixerClientData__) */ From f763859fd0f8835b9587c0d554be5384f9228bf9 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 10:44:52 -0700 Subject: [PATCH 09/12] don't attempt to render avatars until they are initialized --- interface/src/avatar/AvatarManager.cpp | 76 +++++++++++++++----------- interface/src/avatar/AvatarManager.h | 6 +- 2 files changed, 48 insertions(+), 34 deletions(-) diff --git a/interface/src/avatar/AvatarManager.cpp b/interface/src/avatar/AvatarManager.cpp index 9147a08dbd..bc1f826606 100644 --- a/interface/src/avatar/AvatarManager.cpp +++ b/interface/src/avatar/AvatarManager.cpp @@ -48,15 +48,12 @@ void AvatarManager::updateOtherAvatars(float deltaTime) { AvatarHash::iterator avatarIterator = _avatarHash.begin(); while (avatarIterator != _avatarHash.end()) { Avatar* avatar = static_cast(avatarIterator.value().data()); - if (avatar == static_cast(_myAvatar.data())) { + if (avatar == static_cast(_myAvatar.data()) || !avatar->isInitialized()) { // DO NOT update _myAvatar! Its update has already been done earlier in the main loop. - //updateMyAvatar(deltaTime); + // DO NOT update uninitialized Avatars ++avatarIterator; continue; } - if (!avatar->isInitialized()) { - avatar->init(); - } if (avatar->getOwningAvatarMixer()) { // this avatar's mixer is still around, go ahead and simulate it avatar->simulate(deltaTime); @@ -104,12 +101,14 @@ void AvatarManager::simulateAvatarFades(float deltaTime) { while (fadingIterator != _avatarFades.end()) { Avatar* avatar = static_cast(fadingIterator->data()); - avatar->setTargetScale(avatar->getScale() * SHRINK_RATE); - if (avatar->getTargetScale() < MIN_FADE_SCALE) { - fadingIterator = _avatarFades.erase(fadingIterator); - } else { - avatar->simulate(deltaTime); - ++fadingIterator; + if (avatar->isInitialized()) { + avatar->setTargetScale(avatar->getScale() * SHRINK_RATE); + if (avatar->getTargetScale() < MIN_FADE_SCALE) { + fadingIterator = _avatarFades.erase(fadingIterator); + } else { + avatar->simulate(deltaTime); + ++fadingIterator; + } } } } @@ -120,22 +119,40 @@ void AvatarManager::renderAvatarFades(const glm::vec3& cameraPosition, Avatar::R foreach(const AvatarSharedPointer& fadingAvatar, _avatarFades) { Avatar* avatar = static_cast(fadingAvatar.data()); - if (avatar != static_cast(_myAvatar.data())) { + if (avatar != static_cast(_myAvatar.data()) && avatar->isInitialized()) { avatar->render(cameraPosition, renderMode); } } } +AvatarSharedPointer AvatarManager::matchingOrNewAvatar(const QUuid& nodeUUID, const QWeakPointer& mixerWeakPointer) { + AvatarSharedPointer matchingAvatar = _avatarHash.value(nodeUUID); + + if (!matchingAvatar) { + // construct a new Avatar for this node + Avatar* avatar = new Avatar(); + avatar->setOwningAvatarMixer(mixerWeakPointer); + + // insert the new avatar into our hash + matchingAvatar = AvatarSharedPointer(avatar); + _avatarHash.insert(nodeUUID, matchingAvatar); + + qDebug() << "Adding avatar with UUID" << nodeUUID << "to AvatarManager hash."; + } + + return matchingAvatar; +} + void AvatarManager::processAvatarMixerDatagram(const QByteArray& datagram, const QWeakPointer& mixerWeakPointer) { switch (packetTypeForPacket(datagram)) { case PacketTypeBulkAvatarData: processAvatarDataPacket(datagram, mixerWeakPointer); break; case PacketTypeAvatarIdentity: - processAvatarIdentityPacket(datagram); + processAvatarIdentityPacket(datagram, mixerWeakPointer); break; case PacketTypeAvatarBillboard: - processAvatarBillboardPacket(datagram); + processAvatarBillboardPacket(datagram, mixerWeakPointer); break; case PacketTypeKillAvatar: processKillAvatar(datagram); @@ -154,26 +171,21 @@ void AvatarManager::processAvatarDataPacket(const QByteArray &datagram, const QW QUuid nodeUUID = QUuid::fromRfc4122(datagram.mid(bytesRead, NUM_BYTES_RFC4122_UUID)); bytesRead += NUM_BYTES_RFC4122_UUID; - AvatarSharedPointer matchingAvatar = _avatarHash.value(nodeUUID); - - if (!matchingAvatar) { - // construct a new Avatar for this node - Avatar* avatar = new Avatar(); - avatar->setOwningAvatarMixer(mixerWeakPointer); - - // insert the new avatar into our hash - matchingAvatar = AvatarSharedPointer(avatar); - _avatarHash.insert(nodeUUID, matchingAvatar); - - qDebug() << "Adding avatar with UUID" << nodeUUID << "to AvatarManager hash."; - } + AvatarSharedPointer matchingAvatarData = matchingOrNewAvatar(nodeUUID, mixerWeakPointer); // have the matching (or new) avatar parse the data from the packet - bytesRead += matchingAvatar->parseDataAtOffset(datagram, bytesRead); + bytesRead += matchingAvatarData->parseDataAtOffset(datagram, bytesRead); + + Avatar* matchingAvatar = reinterpret_cast(matchingAvatarData.data()); + + if (!matchingAvatar->isInitialized()) { + // now that we have AvatarData for this Avatar we are go for init + matchingAvatar->init(); + } } } -void AvatarManager::processAvatarIdentityPacket(const QByteArray &packet) { +void AvatarManager::processAvatarIdentityPacket(const QByteArray &packet, const QWeakPointer& mixerWeakPointer) { // setup a data stream to parse the packet QDataStream identityStream(packet); identityStream.skipRawData(numBytesForPacketHeader(packet)); @@ -187,7 +199,7 @@ void AvatarManager::processAvatarIdentityPacket(const QByteArray &packet) { identityStream >> nodeUUID >> faceMeshURL >> skeletonURL >> displayName; // mesh URL for a UUID, find avatar in our list - AvatarSharedPointer matchingAvatar = _avatarHash.value(nodeUUID); + AvatarSharedPointer matchingAvatar = matchingOrNewAvatar(nodeUUID, mixerWeakPointer); if (matchingAvatar) { Avatar* avatar = static_cast(matchingAvatar.data()); @@ -206,11 +218,11 @@ void AvatarManager::processAvatarIdentityPacket(const QByteArray &packet) { } } -void AvatarManager::processAvatarBillboardPacket(const QByteArray& packet) { +void AvatarManager::processAvatarBillboardPacket(const QByteArray& packet, const QWeakPointer& mixerWeakPointer) { int headerSize = numBytesForPacketHeader(packet); QUuid nodeUUID = QUuid::fromRfc4122(QByteArray::fromRawData(packet.constData() + headerSize, NUM_BYTES_RFC4122_UUID)); - AvatarSharedPointer matchingAvatar = _avatarHash.value(nodeUUID); + AvatarSharedPointer matchingAvatar = matchingOrNewAvatar(nodeUUID, mixerWeakPointer); if (matchingAvatar) { Avatar* avatar = static_cast(matchingAvatar.data()); QByteArray billboard = packet.mid(headerSize + NUM_BYTES_RFC4122_UUID); diff --git a/interface/src/avatar/AvatarManager.h b/interface/src/avatar/AvatarManager.h index 06494f309c..bd04dddb78 100644 --- a/interface/src/avatar/AvatarManager.h +++ b/interface/src/avatar/AvatarManager.h @@ -39,9 +39,11 @@ public slots: private: AvatarManager(const AvatarManager& other); + AvatarSharedPointer matchingOrNewAvatar(const QUuid& nodeUUID, const QWeakPointer& mixerWeakPointer); + void processAvatarDataPacket(const QByteArray& packet, const QWeakPointer& mixerWeakPointer); - void processAvatarIdentityPacket(const QByteArray& packet); - void processAvatarBillboardPacket(const QByteArray& packet); + void processAvatarIdentityPacket(const QByteArray& packet, const QWeakPointer& mixerWeakPointer); + void processAvatarBillboardPacket(const QByteArray& packet, const QWeakPointer& mixerWeakPointer); void processKillAvatar(const QByteArray& datagram); void simulateAvatarFades(float deltaTime); From 786d9ce404a42c9c2ddf9f173a800ad62fb7ef46 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 10:56:06 -0700 Subject: [PATCH 10/12] force sending of identity and billboard packets changed in last frame --- assignment-client/src/avatars/AvatarMixer.cpp | 33 ++++++++++++++++--- assignment-client/src/avatars/AvatarMixer.h | 2 ++ .../src/avatars/AvatarMixerClientData.cpp | 4 ++- .../src/avatars/AvatarMixerClientData.h | 8 +++++ 4 files changed, 41 insertions(+), 6 deletions(-) diff --git a/assignment-client/src/avatars/AvatarMixer.cpp b/assignment-client/src/avatars/AvatarMixer.cpp index 4d09228dd0..e14cb5868f 100644 --- a/assignment-client/src/avatars/AvatarMixer.cpp +++ b/assignment-client/src/avatars/AvatarMixer.cpp @@ -11,7 +11,7 @@ // nodes, and broadcasts that data back to them, every BROADCAST_INTERVAL ms. #include -#include +#include #include #include @@ -31,6 +31,7 @@ const unsigned int AVATAR_DATA_SEND_INTERVAL_USECS = (1 / 60.0) * 1000 * 1000; AvatarMixer::AvatarMixer(const QByteArray& packet) : ThreadedAssignment(packet), + _lastFrameTimestamp(QDateTime::currentMSecsSinceEpoch()), _trailingSleepRatio(1.0f), _performanceThrottlingRatio(0.0f), _sumListeners(0), @@ -102,16 +103,27 @@ void AvatarMixer::broadcastAvatarData() { // copy the avatar into the mixedAvatarByteArray packet mixedAvatarByteArray.append(avatarByteArray); + // if the receiving avatar has just connected make sure we send out the mesh and billboard + // for this avatar (assuming they exist) bool forceSend = !myData->checkAndSetHasReceivedFirstPackets(); - if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY || forceSend) { + // we will also force a send of billboard or identity packet + // if either has changed in the last frame + + if (otherNodeData->getBillboardChangeTimestamp() > 0 + && (forceSend + || otherNodeData->getBillboardChangeTimestamp() > _lastFrameTimestamp + || randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY)) { QByteArray billboardPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarBillboard); billboardPacket.append(otherNode->getUUID().toRfc4122()); billboardPacket.append(otherNodeData->getAvatar().getBillboard()); nodeList->writeDatagram(billboardPacket, node); } - if (randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY || forceSend) { + if (otherNodeData->getIdentityChangeTimestamp() > 0 + && (forceSend + || otherNodeData->getIdentityChangeTimestamp() > _lastFrameTimestamp + || randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY)) { QByteArray identityPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarIdentity); QByteArray individualData = otherNodeData->getAvatar().identityByteArray(); @@ -127,6 +139,8 @@ void AvatarMixer::broadcastAvatarData() { nodeList->writeDatagram(mixedAvatarByteArray, node); } } + + _lastFrameTimestamp = QDateTime::currentMSecsSinceEpoch(); } void AvatarMixer::nodeKilled(SharedNodePointer killedNode) { @@ -163,7 +177,11 @@ void AvatarMixer::readPendingDatagrams() { if (avatarNode && avatarNode->getLinkedData()) { AvatarMixerClientData* nodeData = reinterpret_cast(avatarNode->getLinkedData()); AvatarData& avatar = nodeData->getAvatar(); - avatar.hasIdentityChangedAfterParsing(receivedPacket); + + // parse the identity packet and update the change timestamp if appropriate + if (avatar.hasIdentityChangedAfterParsing(receivedPacket)) { + nodeData->setIdentityChangeTimestamp(QDateTime::currentMSecsSinceEpoch()); + } } break; } @@ -175,7 +193,12 @@ void AvatarMixer::readPendingDatagrams() { if (avatarNode && avatarNode->getLinkedData()) { AvatarMixerClientData* nodeData = static_cast(avatarNode->getLinkedData()); AvatarData& avatar = nodeData->getAvatar(); - avatar.hasBillboardChangedAfterParsing(receivedPacket); + + // parse the billboard packet and update the change timestamp if appropriate + if (avatar.hasBillboardChangedAfterParsing(receivedPacket)) { + nodeData->setBillboardChangeTimestamp(QDateTime::currentMSecsSinceEpoch()); + } + } break; } diff --git a/assignment-client/src/avatars/AvatarMixer.h b/assignment-client/src/avatars/AvatarMixer.h index 4d54b715f8..d4e354f347 100644 --- a/assignment-client/src/avatars/AvatarMixer.h +++ b/assignment-client/src/avatars/AvatarMixer.h @@ -30,6 +30,8 @@ public slots: private: void broadcastAvatarData(); + quint64 _lastFrameTimestamp; + float _trailingSleepRatio; float _performanceThrottlingRatio; diff --git a/assignment-client/src/avatars/AvatarMixerClientData.cpp b/assignment-client/src/avatars/AvatarMixerClientData.cpp index 84db17ecf4..d1449e956e 100644 --- a/assignment-client/src/avatars/AvatarMixerClientData.cpp +++ b/assignment-client/src/avatars/AvatarMixerClientData.cpp @@ -10,7 +10,9 @@ AvatarMixerClientData::AvatarMixerClientData() : NodeData(), - _hasReceivedFirstPackets(false) + _hasReceivedFirstPackets(false), + _billboardChangeTimestamp(0), + _identityChangeTimestamp(0) { } diff --git a/assignment-client/src/avatars/AvatarMixerClientData.h b/assignment-client/src/avatars/AvatarMixerClientData.h index 5cf61659a7..bc0a54f06b 100644 --- a/assignment-client/src/avatars/AvatarMixerClientData.h +++ b/assignment-client/src/avatars/AvatarMixerClientData.h @@ -24,9 +24,17 @@ public: bool checkAndSetHasReceivedFirstPackets(); + quint64 getBillboardChangeTimestamp() const { return _billboardChangeTimestamp; } + void setBillboardChangeTimestamp(quint64 billboardChangeTimestamp) { _billboardChangeTimestamp = billboardChangeTimestamp; } + + quint64 getIdentityChangeTimestamp() const { return _identityChangeTimestamp; } + void setIdentityChangeTimestamp(quint64 identityChangeTimestamp) { _identityChangeTimestamp = identityChangeTimestamp; } + private: AvatarData _avatar; bool _hasReceivedFirstPackets; + quint64 _billboardChangeTimestamp; + quint64 _identityChangeTimestamp; }; #endif /* defined(__hifi__AvatarMixerClientData__) */ From 8a796be785562db948ca2f900a3c65c8ea80c456 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 11:10:28 -0700 Subject: [PATCH 11/12] only fade avatars if they have ever been initialized --- interface/src/avatar/AvatarManager.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/interface/src/avatar/AvatarManager.cpp b/interface/src/avatar/AvatarManager.cpp index bc1f826606..c2ba28ac7b 100644 --- a/interface/src/avatar/AvatarManager.cpp +++ b/interface/src/avatar/AvatarManager.cpp @@ -101,14 +101,12 @@ void AvatarManager::simulateAvatarFades(float deltaTime) { while (fadingIterator != _avatarFades.end()) { Avatar* avatar = static_cast(fadingIterator->data()); - if (avatar->isInitialized()) { - avatar->setTargetScale(avatar->getScale() * SHRINK_RATE); - if (avatar->getTargetScale() < MIN_FADE_SCALE) { - fadingIterator = _avatarFades.erase(fadingIterator); - } else { - avatar->simulate(deltaTime); - ++fadingIterator; - } + avatar->setTargetScale(avatar->getScale() * SHRINK_RATE); + if (avatar->getTargetScale() < MIN_FADE_SCALE) { + fadingIterator = _avatarFades.erase(fadingIterator); + } else { + avatar->simulate(deltaTime); + ++fadingIterator; } } } @@ -246,7 +244,9 @@ void AvatarManager::processKillAvatar(const QByteArray& datagram) { AvatarHash::iterator AvatarManager::erase(const AvatarHash::iterator& iterator) { if (iterator.key() != MY_AVATAR_KEY) { qDebug() << "Removing Avatar with UUID" << iterator.key() << "from AvatarManager hash."; - _avatarFades.push_back(iterator.value()); + if (reinterpret_cast(iterator.value().data())->isInitialized()) { + _avatarFades.push_back(iterator.value()); + } return AvatarHashMap::erase(iterator); } else { // never remove _myAvatar from the list From ff788a340b300c585c20fdaf49d519b0bb39f4b8 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Tue, 25 Mar 2014 11:38:00 -0700 Subject: [PATCH 12/12] add stat for average billboard and identity packets per frame --- assignment-client/src/avatars/AvatarMixer.cpp | 14 +++++++++++++- assignment-client/src/avatars/AvatarMixer.h | 2 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/assignment-client/src/avatars/AvatarMixer.cpp b/assignment-client/src/avatars/AvatarMixer.cpp index e14cb5868f..54f1943930 100644 --- a/assignment-client/src/avatars/AvatarMixer.cpp +++ b/assignment-client/src/avatars/AvatarMixer.cpp @@ -35,7 +35,9 @@ AvatarMixer::AvatarMixer(const QByteArray& packet) : _trailingSleepRatio(1.0f), _performanceThrottlingRatio(0.0f), _sumListeners(0), - _numStatFrames(0) + _numStatFrames(0), + _sumBillboardPackets(0), + _sumIdentityPackets(0) { // make sure we hear about node kills so we can tell the other nodes connect(NodeList::getInstance(), &NodeList::nodeKilled, this, &AvatarMixer::nodeKilled); @@ -118,12 +120,15 @@ void AvatarMixer::broadcastAvatarData() { billboardPacket.append(otherNode->getUUID().toRfc4122()); billboardPacket.append(otherNodeData->getAvatar().getBillboard()); nodeList->writeDatagram(billboardPacket, node); + + ++_sumBillboardPackets; } if (otherNodeData->getIdentityChangeTimestamp() > 0 && (forceSend || otherNodeData->getIdentityChangeTimestamp() > _lastFrameTimestamp || randFloat() < BILLBOARD_AND_IDENTITY_SEND_PROBABILITY)) { + QByteArray identityPacket = byteArrayWithPopulatedHeader(PacketTypeAvatarIdentity); QByteArray individualData = otherNodeData->getAvatar().identityByteArray(); @@ -131,6 +136,8 @@ void AvatarMixer::broadcastAvatarData() { identityPacket.append(individualData); nodeList->writeDatagram(identityPacket, node); + + ++_sumIdentityPackets; } } } @@ -219,12 +226,17 @@ void AvatarMixer::sendStatsPacket() { QJsonObject statsObject; statsObject["average_listeners_last_second"] = (float) _sumListeners / (float) _numStatFrames; + statsObject["average_billboard_packets_per_frame"] = (float) _sumBillboardPackets / (float) _numStatFrames; + statsObject["average_identity_packets_per_frame"] = (float) _sumIdentityPackets / (float) _numStatFrames; + statsObject["trailing_sleep_percentage"] = _trailingSleepRatio * 100; statsObject["performance_throttling_ratio"] = _performanceThrottlingRatio; ThreadedAssignment::addPacketStatsAndSendStatsPacket(statsObject); _sumListeners = 0; + _sumBillboardPackets = 0; + _sumIdentityPackets = 0; _numStatFrames = 0; } diff --git a/assignment-client/src/avatars/AvatarMixer.h b/assignment-client/src/avatars/AvatarMixer.h index d4e354f347..4171df49af 100644 --- a/assignment-client/src/avatars/AvatarMixer.h +++ b/assignment-client/src/avatars/AvatarMixer.h @@ -37,6 +37,8 @@ private: int _sumListeners; int _numStatFrames; + int _sumBillboardPackets; + int _sumIdentityPackets; }; #endif /* defined(__hifi__AvatarMixer__) */