From 6e4c5d1ab4bb336d9fbd386602a48b51e221796e Mon Sep 17 00:00:00 2001 From: Ryan Huffman Date: Tue, 9 May 2017 16:27:02 -0700 Subject: [PATCH] Update FileCache writing to check QSaveFile::write return value --- libraries/networking/src/FileCache.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libraries/networking/src/FileCache.cpp b/libraries/networking/src/FileCache.cpp index 348206a863..0f90807d08 100644 --- a/libraries/networking/src/FileCache.cpp +++ b/libraries/networking/src/FileCache.cpp @@ -112,9 +112,8 @@ FilePointer FileCache::writeFile(const char* data, File::Metadata&& metadata) { } QSaveFile saveFile(QString::fromStdString(filepath)); - saveFile.open(QIODevice::WriteOnly); - saveFile.write(data, metadata.length); - if (saveFile.commit()) { + if (saveFile.open(QIODevice::WriteOnly) && saveFile.write(data, metadata.length) == metadata.length + && saveFile.commit()) { file = addFile(std::move(metadata), filepath); } else { qCWarning(file_cache, "[%s] Failed to write %s", _dirname.c_str(), metadata.key.c_str());