From 5018edcfe00b701fdc5bcef243957a8fdd1150dd Mon Sep 17 00:00:00 2001
From: SamGondelman <samuel_gondelman@alumni.brown.edu>
Date: Fri, 22 Dec 2017 12:48:05 -0800
Subject: [PATCH 1/2] reduce calls to getVisible

---
 .../entities-renderer/src/RenderableEntityItem.cpp     |  5 +----
 libraries/entities/src/EntityItem.cpp                  | 10 +++++++++-
 libraries/entities/src/EntityItem.h                    |  3 +++
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/libraries/entities-renderer/src/RenderableEntityItem.cpp b/libraries/entities-renderer/src/RenderableEntityItem.cpp
index 24de651247..3060cdb9ca 100644
--- a/libraries/entities-renderer/src/RenderableEntityItem.cpp
+++ b/libraries/entities-renderer/src/RenderableEntityItem.cpp
@@ -141,6 +141,7 @@ std::shared_ptr<T> make_renderer(const EntityItemPointer& entity) {
 }
 
 EntityRenderer::EntityRenderer(const EntityItemPointer& entity) : _entity(entity) {
+    connect(entity.get(), &EntityItem::requestRenderUpdate, this, &EntityRenderer::requestRenderUpdate);
 }
 
 EntityRenderer::~EntityRenderer() { }
@@ -331,10 +332,6 @@ bool EntityRenderer::needsRenderUpdateFromEntity(const EntityItemPointer& entity
         return true;
     }
 
-    if (_visible != entity->getVisible()) {
-        return true;
-    }
-
     if (_moving != entity->isMovingRelativeToParent()) {
         return true;
     }
diff --git a/libraries/entities/src/EntityItem.cpp b/libraries/entities/src/EntityItem.cpp
index 271fef33c8..5f2b260627 100644
--- a/libraries/entities/src/EntityItem.cpp
+++ b/libraries/entities/src/EntityItem.cpp
@@ -2692,9 +2692,17 @@ bool EntityItem::getVisible() const {
 }
 
 void EntityItem::setVisible(bool value) {
+    bool changed = false;
     withWriteLock([&] {
-        _visible = value;
+        if (_visible != value) {
+            changed = true;
+            _visible = value;
+        }
     });
+
+    if (changed) {
+        emit requestRenderUpdate();
+    }
 }
 
 bool EntityItem::isChildOfMyAvatar() const {
diff --git a/libraries/entities/src/EntityItem.h b/libraries/entities/src/EntityItem.h
index 088d21e84d..06471b991b 100644
--- a/libraries/entities/src/EntityItem.h
+++ b/libraries/entities/src/EntityItem.h
@@ -464,6 +464,9 @@ public:
     static QString _marketplacePublicKey;
     static void retrieveMarketplacePublicKey();
 
+signals:
+    void requestRenderUpdate();
+
 protected:
     QHash<ChangeHandlerId, ChangeHandlerCallback> _changeHandlers;
 

From 4f5727e6b0c143a400c6e0be063fd91eb6eb8c4a Mon Sep 17 00:00:00 2001
From: SamGondelman <samuel_gondelman@alumni.brown.edu>
Date: Mon, 8 Jan 2018 15:25:16 -0800
Subject: [PATCH 2/2] add _needsRenderUpdate flag

---
 libraries/entities-renderer/src/RenderableEntityItem.cpp | 9 ++++++++-
 libraries/entities-renderer/src/RenderableEntityItem.h   | 1 +
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/libraries/entities-renderer/src/RenderableEntityItem.cpp b/libraries/entities-renderer/src/RenderableEntityItem.cpp
index 1f11802405..fb9aba636b 100644
--- a/libraries/entities-renderer/src/RenderableEntityItem.cpp
+++ b/libraries/entities-renderer/src/RenderableEntityItem.cpp
@@ -141,7 +141,10 @@ std::shared_ptr<T> make_renderer(const EntityItemPointer& entity) {
 }
 
 EntityRenderer::EntityRenderer(const EntityItemPointer& entity) : _entity(entity) {
-    connect(entity.get(), &EntityItem::requestRenderUpdate, this, &EntityRenderer::requestRenderUpdate);
+    connect(entity.get(), &EntityItem::requestRenderUpdate, this, [&] {
+        _needsRenderUpdate = true;
+        emit requestRenderUpdate();
+    });
 }
 
 EntityRenderer::~EntityRenderer() { }
@@ -312,6 +315,9 @@ void EntityRenderer::setSubRenderItemIDs(const render::ItemIDs& ids) {
 // Returns true if the item needs to have updateInscene called because of internal rendering 
 // changes (animation, fading, etc)
 bool EntityRenderer::needsRenderUpdate() const {
+    if (_needsRenderUpdate) {
+        return true;
+    }
     if (_prevIsTransparent != isTransparent()) {
         return true;
     }
@@ -360,6 +366,7 @@ void EntityRenderer::doRenderUpdateSynchronous(const ScenePointer& scene, Transa
 
         _moving = entity->isMovingRelativeToParent();
         _visible = entity->getVisible();
+        _needsRenderUpdate = false;
     });
 }
 
diff --git a/libraries/entities-renderer/src/RenderableEntityItem.h b/libraries/entities-renderer/src/RenderableEntityItem.h
index 5deb69711d..8eb82e2c6e 100644
--- a/libraries/entities-renderer/src/RenderableEntityItem.h
+++ b/libraries/entities-renderer/src/RenderableEntityItem.h
@@ -125,6 +125,7 @@ protected:
     bool _prevIsTransparent { false };
     bool _visible { false };
     bool _moving { false };
+    bool _needsRenderUpdate { false };
     // Only touched on the rendering thread
     bool _renderUpdateQueued{ false };