Merge branch 'master' of github.com:highfidelity/hifi into bug16645

assignment-client/src/assets/AssetServer.cpp

@@ -23,6 +23,7 @@
 #include <QtCore/QFile>
 #include <QtCore/QFileInfo>
 #include <QtCore/QJsonDocument>
+#include <QtCore/QSaveFile>
 #include <QtCore/QString>
 #include <QtGui/QImageReader>
 #include <QtCore/QVector>
@@ -1042,7 +1043,7 @@ bool AssetServer::loadMappingsFromFile() {
 bool AssetServer::writeMappingsToFile() {
     auto mapFilePath = _resourcesDirectory.absoluteFilePath(MAP_FILE_NAME);
 
-    QFile mapFile { mapFilePath };
+    QSaveFile mapFile { mapFilePath };
     if (mapFile.open(QIODevice::WriteOnly)) {
         QJsonObject root;
 
@@ -1053,8 +1054,12 @@ bool AssetServer::writeMappingsToFile() {
         QJsonDocument jsonDocument { root };
 
         if (mapFile.write(jsonDocument.toJson()) != -1) {
+            if (mapFile.commit()) {
                 qCDebug(asset_server) << "Wrote JSON mappings to file at" << mapFilePath;
                 return true;
+            } else {
+                qCWarning(asset_server) << "Failed to commit JSON mappings to file at" << mapFilePath;
+            }
         } else {
             qCWarning(asset_server) << "Failed to write JSON mappings to file at" << mapFilePath;
         }

interface/src/avatar/MyAvatar.cpp

@@ -262,6 +262,26 @@ void MyAvatar::setDominantHand(const QString& hand) {
     }
 }
 
+void MyAvatar::requestDisableHandTouch() {
+    std::lock_guard<std::mutex> guard(_disableHandTouchMutex);
+    _disableHandTouchCount++;
+    emit shouldDisableHandTouchChanged(_disableHandTouchCount > 0);
+}
+
+void MyAvatar::requestEnableHandTouch() {
+    std::lock_guard<std::mutex> guard(_disableHandTouchMutex);
+    _disableHandTouchCount = std::max(_disableHandTouchCount - 1, 0);
+    emit shouldDisableHandTouchChanged(_disableHandTouchCount > 0);
+}
+
+void MyAvatar::disableHandTouchForID(const QUuid& entityID) {
+    emit disableHandTouchForIDChanged(entityID, true);
+}
+
+void MyAvatar::enableHandTouchForID(const QUuid& entityID) {
+    emit disableHandTouchForIDChanged(entityID, false);
+}
+
 void MyAvatar::registerMetaTypes(ScriptEnginePointer engine) {
     QScriptValue value = engine->newQObject(this, QScriptEngine::QtOwnership, QScriptEngine::ExcludeDeleteLater | QScriptEngine::ExcludeChildObjects);
     engine->globalObject().setProperty("MyAvatar", value);

interface/src/avatar/MyAvatar.h

@@ -505,6 +505,28 @@ public:
      * @returns {boolean} 
      */
     Q_INVOKABLE bool getHMDLeanRecenterEnabled() const { return _hmdLeanRecenterEnabled; }
+    /**jsdoc
+     * Request to enable hand touch effect globally
+     * @function MyAvatar.requestEnableHandTouch
+     */
+    Q_INVOKABLE void requestEnableHandTouch();
+    /**jsdoc
+     * Request to disable hand touch effect globally
+     * @function MyAvatar.requestDisableHandTouch
+     */
+    Q_INVOKABLE void requestDisableHandTouch();
+    /**jsdoc
+     * Disables hand touch effect on a specific entity
+     * @function MyAvatar.disableHandTouchForID
+     * @param {Uuid} entityID - ID of the entity that will disable hand touch effect
+     */
+    Q_INVOKABLE void disableHandTouchForID(const QUuid& entityID);
+    /**jsdoc
+     * Enables hand touch effect on a specific entity
+     * @function MyAvatar.enableHandTouchForID
+     * @param {Uuid} entityID - ID of the entity that will enable hand touch effect
+     */
+    Q_INVOKABLE void enableHandTouchForID(const QUuid& entityID);
 
     bool useAdvancedMovementControls() const { return _useAdvancedMovementControls.get(); }
     void setUseAdvancedMovementControls(bool useAdvancedMovementControls)
@@ -1392,6 +1414,23 @@ signals:
      */
     void scaleChanged();
 
+    /**jsdoc
+     * Triggered when hand touch is globally enabled or disabled
+     * @function MyAvatar.shouldDisableHandTouchChanged
+     * @param {boolean} shouldDisable
+     * @returns {Signal}
+     */
+    void shouldDisableHandTouchChanged(bool shouldDisable);
+
+    /**jsdoc
+     * Triggered when hand touch is enabled or disabled for an specific entity
+     * @function MyAvatar.disableHandTouchForIDChanged
+     * @param {Uuid} entityID - ID of the entity that will enable hand touch effect
+     * @param {boolean} disable
+     * @returns {Signal}
+     */
+    void disableHandTouchForIDChanged(const QUuid& entityID, bool disable);
+
 private slots:
     void leaveDomain();
 
@@ -1628,6 +1667,7 @@ private:
     // all poses are in sensor-frame
     std::map<controller::Action, controller::Pose> _controllerPoseMap;
     mutable std::mutex _controllerPoseMapMutex;
+    mutable std::mutex _disableHandTouchMutex;
 
     bool _centerOfGravityModelEnabled { true };
     bool _hmdLeanRecenterEnabled { true };
@@ -1668,6 +1708,7 @@ private:
     bool _shouldLoadScripts { false };
 
     bool _haveReceivedHeightLimitsFromDomain { false };
+    int _disableHandTouchCount { 0 };
 };
 
 QScriptValue audioListenModeToScriptValue(QScriptEngine* engine, const AudioListenerMode& audioListenerMode);

libraries/fbx/src/GLTFReader.cpp

@@ -21,14 +21,17 @@
 #include <QtCore/qpair.h>
 #include <QtCore/qlist.h>
 
+
 #include <QtNetwork/QNetworkAccessManager>
 #include <QtNetwork/QNetworkRequest>
 
 #include <qfile.h>
+#include <qfileinfo.h>
 
 #include <shared/NsightHelpers.h>
 #include <NetworkAccessManager.h>
 #include <ResourceManager.h>
+#include <PathUtils.h>
 
 #include "FBXReader.h"
 
@@ -786,13 +789,18 @@ bool GLTFReader::buildGeometry(FBXGeometry& geometry, const QUrl& url) {
                 QVector<glm::vec3> raw_vertices;
                 QVector<glm::vec3> raw_normals;
 
-                addArrayOfType(indicesBuffer.blob, 
+                bool success = addArrayOfType(indicesBuffer.blob, 
                     indicesBufferview.byteOffset + indicesAccBoffset, 
-                    indicesBufferview.byteLength, 
+                    indicesAccessor.count, 
                     part.triangleIndices, 
                     indicesAccessor.type, 
                     indicesAccessor.componentType);
 
+                if (!success) {
+                    qWarning(modelformat) << "There was a problem reading glTF INDICES data for model " << _url;
+                    continue;
+                }
+
                 QList<QString> keys = primitive.attributes.values.keys();
 
                 foreach(auto &key, keys) {
@@ -805,44 +813,60 @@ bool GLTFReader::buildGeometry(FBXGeometry& geometry, const QUrl& url) {
                     int accBoffset = accessor.defined["byteOffset"] ? accessor.byteOffset : 0;
                     if (key == "POSITION") {
                         QVector<float> vertices;
-                        addArrayOfType(buffer.blob, 
+                        success = addArrayOfType(buffer.blob, 
                             bufferview.byteOffset + accBoffset, 
-                            bufferview.byteLength, vertices, 
+                            accessor.count, vertices, 
                             accessor.type, 
                             accessor.componentType);
+                        if (!success) {
+                            qWarning(modelformat) << "There was a problem reading glTF POSITION data for model " << _url;
+                            continue;
+                        }
                         for (int n = 0; n < vertices.size(); n = n + 3) {
                             mesh.vertices.push_back(glm::vec3(vertices[n], vertices[n + 1], vertices[n + 2]));
                         }
                     } else if (key == "NORMAL") {
                         QVector<float> normals;
-                        addArrayOfType(buffer.blob, 
+                        success = addArrayOfType(buffer.blob, 
                             bufferview.byteOffset + accBoffset, 
-                            bufferview.byteLength, 
+                            accessor.count, 
                             normals, 
                             accessor.type, 
                             accessor.componentType);
+                        if (!success) {
+                            qWarning(modelformat) << "There was a problem reading glTF NORMAL data for model " << _url;
+                            continue;
+                        }
                         for (int n = 0; n < normals.size(); n = n + 3) {
                             mesh.normals.push_back(glm::vec3(normals[n], normals[n + 1], normals[n + 2]));
                         }
                     } else if (key == "TEXCOORD_0") {
                         QVector<float> texcoords;
-                        addArrayOfType(buffer.blob, 
+                        success = addArrayOfType(buffer.blob, 
                             bufferview.byteOffset + accBoffset, 
-                            bufferview.byteLength, 
+                            accessor.count, 
                             texcoords, 
                             accessor.type, 
                             accessor.componentType);
+                        if (!success) {
+                            qWarning(modelformat) << "There was a problem reading glTF TEXCOORD_0 data for model " << _url;
+                            continue;
+                        }
                         for (int n = 0; n < texcoords.size(); n = n + 2) {
                             mesh.texCoords.push_back(glm::vec2(texcoords[n], texcoords[n + 1]));
                         }
                     } else if (key == "TEXCOORD_1") {
                         QVector<float> texcoords;
-                        addArrayOfType(buffer.blob, 
+                        success = addArrayOfType(buffer.blob, 
                             bufferview.byteOffset + accBoffset, 
-                            bufferview.byteLength, 
+                            accessor.count, 
                             texcoords, 
                             accessor.type, 
                             accessor.componentType);
+                        if (!success) {
+                            qWarning(modelformat) << "There was a problem reading glTF TEXCOORD_1 data for model " << _url;
+                            continue;
+                        }
                         for (int n = 0; n < texcoords.size(); n = n + 2) {
                             mesh.texCoords1.push_back(glm::vec2(texcoords[n], texcoords[n + 1]));
                         }
@@ -888,8 +912,16 @@ bool GLTFReader::buildGeometry(FBXGeometry& geometry, const QUrl& url) {
 
 FBXGeometry* GLTFReader::readGLTF(QByteArray& model, const QVariantHash& mapping, 
                                   const QUrl& url, bool loadLightmaps, float lightmapLevel) {
+    
     _url = url;
 
+    // Normalize url for local files
+    QUrl normalizeUrl = DependencyManager::get<ResourceManager>()->normalizeURL(url);
+    if (normalizeUrl.scheme().isEmpty() || (normalizeUrl.scheme() == "file")) {
+        QString localFileName = PathUtils::expandToLocalDataAbsolutePath(normalizeUrl).toLocalFile();
+        _url = QUrl(QFileInfo(localFileName).absoluteFilePath());
+    }
+
     parseGLTF(model);
     //_file.dump();
     FBXGeometry* geometryPtr = new FBXGeometry();
@@ -904,6 +936,7 @@ FBXGeometry* GLTFReader::readGLTF(QByteArray& model, const QVariantHash& mapping
 
 bool GLTFReader::readBinary(const QString& url, QByteArray& outdata) {
     QUrl binaryUrl = _url.resolved(QUrl(url).fileName());
+
     qCDebug(modelformat) << "binaryUrl: " << binaryUrl << "  OriginalUrl: " << _url;
     bool success;
     std::tie<bool, QByteArray>(success, outdata) = requestData(binaryUrl);
@@ -1018,13 +1051,12 @@ void GLTFReader::setFBXMaterial(FBXMaterial& fbxmat, const GLTFMaterial& materia
             fbxmat.opacityTexture = getFBXTexture(_file.textures[material.pbrMetallicRoughness.baseColorTexture]);
             fbxmat.albedoTexture = getFBXTexture(_file.textures[material.pbrMetallicRoughness.baseColorTexture]);
             fbxmat.useAlbedoMap = true;
-            fbxmat.metallicTexture = getFBXTexture(_file.textures[material.pbrMetallicRoughness.baseColorTexture]);
-            fbxmat.useMetallicMap = true;
         }
         if (material.pbrMetallicRoughness.defined["metallicRoughnessTexture"]) {
             fbxmat.roughnessTexture = getFBXTexture(_file.textures[material.pbrMetallicRoughness.metallicRoughnessTexture]);
             fbxmat.useRoughnessMap = true;
-
+            fbxmat.metallicTexture = getFBXTexture(_file.textures[material.pbrMetallicRoughness.metallicRoughnessTexture]);
+            fbxmat.useMetallicMap = true;
         }
         if (material.pbrMetallicRoughness.defined["roughnessFactor"]) {
             fbxmat._material->setRoughness(material.pbrMetallicRoughness.roughnessFactor);
@@ -1043,7 +1075,7 @@ void GLTFReader::setFBXMaterial(FBXMaterial& fbxmat, const GLTFMaterial& materia
 }
 
 template<typename T, typename L>
-bool GLTFReader::readArray(const QByteArray& bin, int byteOffset, int byteLength, 
+bool GLTFReader::readArray(const QByteArray& bin, int byteOffset, int count, 
                            QVector<L>& outarray, int accessorType) {
     
     QDataStream blobstream(bin);
@@ -1051,142 +1083,77 @@ bool GLTFReader::readArray(const QByteArray& bin, int byteOffset, int byteLength
     blobstream.setVersion(QDataStream::Qt_5_9);
     blobstream.setFloatingPointPrecision(QDataStream::FloatingPointPrecision::SinglePrecision);
 
-    int vsize = byteLength / sizeof(T);
+    qCDebug(modelformat) << "size1: " << count;
-
-    qCDebug(modelformat) << "size1: " << vsize;
     int dataskipped = blobstream.skipRawData(byteOffset);
     qCDebug(modelformat) << "dataskipped: " << dataskipped;
 
-
+    int bufferCount = 0;
-    while (outarray.size() < vsize) {
+    switch (accessorType) {
-        
+    case GLTFAccessorType::SCALAR:
-        T value1, value2, value3, value4, 
+        bufferCount = 1;
-          value5, value6, value7, value8, 
+        break;
-          value9, value10, value11, value12, 
+    case GLTFAccessorType::VEC2:
-          value13, value14, value15, value16;
+        bufferCount = 2;
-
+        break;
-        if (accessorType == GLTFAccessorType::SCALAR) {
+    case GLTFAccessorType::VEC3:
-
+        bufferCount = 3;
-            blobstream >> value1;
+        break;
-
+    case GLTFAccessorType::VEC4:
-            outarray.push_back(value1);
+        bufferCount = 4;
-        } else if (accessorType == GLTFAccessorType::VEC2) {
+        break;
-
+    case GLTFAccessorType::MAT2:
-            blobstream >> value1; 
+        bufferCount = 4;
-            blobstream >> value2;
+        break;
-
+    case GLTFAccessorType::MAT3:
-            outarray.push_back(value1);
+        bufferCount = 9;
-            outarray.push_back(value2);
+        break;
-        } else if (accessorType == GLTFAccessorType::VEC3) {
+    case GLTFAccessorType::MAT4:
-
+        bufferCount = 16;
-            blobstream >> value1;
+        break;
-            blobstream >> value2;
+    default:
-            blobstream >> value3;
+        qWarning(modelformat) << "Unknown accessorType: " << accessorType;
-
+        blobstream.unsetDevice();
-            outarray.push_back(value1);
+        return false;
-            outarray.push_back(value2);
+    }
-            outarray.push_back(value3);
+    for (int i = 0; i < count; i++) {
-        } else if (accessorType == GLTFAccessorType::VEC4 || accessorType == GLTFAccessorType::MAT2) {
+        for (int j = 0; j < bufferCount; j++) {
-
+            if (!blobstream.atEnd()) {
-            blobstream >> value1;
+                T value;
-            blobstream >> value2;
+                blobstream >> value;
-            blobstream >> value3;
+                outarray.push_back(value);
-            blobstream >> value4;
+            } else {
-
+                blobstream.unsetDevice();
-            outarray.push_back(value1);
+                return false;
-            outarray.push_back(value2);
-            outarray.push_back(value3);
-            outarray.push_back(value4);
-        } else if (accessorType == GLTFAccessorType::MAT3) {
-
-            blobstream >> value1;
-            blobstream >> value2;
-            blobstream >> value3;
-            blobstream >> value4;
-            blobstream >> value5;
-            blobstream >> value6;
-            blobstream >> value7;
-            blobstream >> value8;
-            blobstream >> value9;
-
-            outarray.push_back(value1);
-            outarray.push_back(value2);
-            outarray.push_back(value3);
-            outarray.push_back(value4);
-            outarray.push_back(value5);
-            outarray.push_back(value6);
-            outarray.push_back(value7);
-            outarray.push_back(value8);
-            outarray.push_back(value9);
-        } else if (accessorType == GLTFAccessorType::MAT4) {
-
-            blobstream >> value1;
-            blobstream >> value2;
-            blobstream >> value3;
-            blobstream >> value4;
-            blobstream >> value5;
-            blobstream >> value6;
-            blobstream >> value7;
-            blobstream >> value8;
-            blobstream >> value9;
-            blobstream >> value10;
-            blobstream >> value11;
-            blobstream >> value12;
-            blobstream >> value13; 
-            blobstream >> value14; 
-            blobstream >> value15;
-            blobstream >> value16;
-
-            outarray.push_back(value1);
-            outarray.push_back(value2);
-            outarray.push_back(value3);
-            outarray.push_back(value4);
-            outarray.push_back(value5);
-            outarray.push_back(value6);
-            outarray.push_back(value7);
-            outarray.push_back(value8);
-            outarray.push_back(value9);
-            outarray.push_back(value10);
-            outarray.push_back(value11);
-            outarray.push_back(value12);
-            outarray.push_back(value13);
-            outarray.push_back(value14);
-            outarray.push_back(value15);
-            outarray.push_back(value16);
-        
             }
         }
+    }
+
     blobstream.unsetDevice();
     return true;
 }
 template<typename T>
-bool GLTFReader::addArrayOfType(const QByteArray& bin, int byteOffset, int byteLength, 
+bool GLTFReader::addArrayOfType(const QByteArray& bin, int byteOffset, int count, 
                                 QVector<T>& outarray, int accessorType, int componentType) {
     
     switch (componentType) {
     case GLTFAccessorComponentType::BYTE: {}
     case GLTFAccessorComponentType::UNSIGNED_BYTE: {
-        readArray<uchar>(bin, byteOffset, byteLength, outarray, accessorType);
+        return readArray<uchar>(bin, byteOffset, count, outarray, accessorType);
-        break;
     }
     case GLTFAccessorComponentType::SHORT: {
-        readArray<short>(bin, byteOffset, byteLength, outarray, accessorType);
+        return readArray<short>(bin, byteOffset, count, outarray, accessorType);
-        break;
     }
     case GLTFAccessorComponentType::UNSIGNED_INT: {
-        readArray<quint32>(bin, byteOffset, byteLength, outarray, accessorType);
+        return readArray<uint>(bin, byteOffset, count, outarray, accessorType);
-        break;
     }
     case GLTFAccessorComponentType::UNSIGNED_SHORT: {
-        readArray<ushort>(bin, byteOffset, byteLength, outarray, accessorType);
+        return readArray<ushort>(bin, byteOffset, count, outarray, accessorType);
-        break;
     }
     case GLTFAccessorComponentType::FLOAT: {
-        readArray<float>(bin, byteOffset, byteLength, outarray, accessorType);
+        return readArray<float>(bin, byteOffset, count, outarray, accessorType);
-        break;
     }
     }
-    return true;
+    return false;
 }
 
 void GLTFReader::retriangulate(const QVector<int>& inIndices, const QVector<glm::vec3>& in_vertices, 

libraries/fbx/src/GLTFReader.h

@@ -762,11 +762,11 @@ private:
     bool readBinary(const QString& url, QByteArray& outdata);
 
     template<typename T, typename L>
-    bool readArray(const QByteArray& bin, int byteOffset, int byteLength, 
+    bool readArray(const QByteArray& bin, int byteOffset, int count, 
                    QVector<L>& outarray, int accessorType);
     
     template<typename T>
-    bool addArrayOfType(const QByteArray& bin, int byteOffset, int byteLength, 
+    bool addArrayOfType(const QByteArray& bin, int byteOffset, int count, 
                         QVector<T>& outarray, int accessorType, int componentType);
 
     void retriangulate(const QVector<int>& in_indices, const QVector<glm::vec3>& in_vertices, 

scripts/system/controllers/handTouch.js

@@ -16,10 +16,10 @@
 
 (function () {
 
+    var handTouchEnabled = true;
     var MSECONDS_AFTER_LOAD = 2000;
-
     var updateFingerWithIndex = 0;
-    
+    var untouchableEntities = [];
     
         // Keys to access finger data
     var fingerKeys = ["pinky", "ring", "middle", "index", "thumb"];
@@ -305,7 +305,6 @@
         avatarLoaded: false
     };
 
-    
     // Add/Subtract the joint data - per finger joint
     function addVals(val1, val2, sign) {
         var val = [];
@@ -351,7 +350,6 @@
     }
 
     function dataRelativeToWorld(side, dataIn, dataOut) {
-
         var handJoint = handJointNames[side];
         var jointIndex = MyAvatar.getJointIndex(handJoint);
         var worldPosHand = MyAvatar.jointToWorldPoint({x: 0, y: 0, z: 0}, jointIndex);
@@ -369,7 +367,6 @@
     }
 
     function dataRelativeToHandJoint(side, dataIn, dataOut) {
-
         var handJoint = handJointNames[side];
         var jointIndex = MyAvatar.getJointIndex(handJoint);
         var worldPosHand = MyAvatar.jointToWorldPoint({x: 0, y: 0, z: 0}, jointIndex);
@@ -385,7 +382,6 @@
 
     // Calculate touch field; Sphere at the center of the palm,
     // perpendicular vector from the palm plane and origin of the the finger rays
-    
     function estimatePalmData(side) {
         // Return data object
         var data = new Palm();
@@ -407,7 +403,6 @@
         var weightCount = 0;
 
         // Calculate palm center
-        
         var handJointWeight = 1;
         var fingerJointWeight = 2;
 
@@ -459,7 +454,6 @@
         // return getDataRelativeToHandJoint(side, data);
         dataRelativeToHandJoint(side, data, palmData[side]);
         palmData[side].set = true;
-        // return palmData[side];
     }
 
     // Register GlobalDebugger for API Debugger
@@ -484,11 +478,9 @@
     };
 
     // Create debug overlays - finger rays + palm rays + spheres
-    
     var palmRay, sphereHand;
 
     function createDebugLines() {
-    
         for (var i = 0; i < fingerKeys.length; i++) {
             fingerRays.left[fingerKeys[i]] = Overlays.addOverlay("line3d", {
                 color: { red: 0, green: 0, blue: 255 },
@@ -522,7 +514,6 @@
     }
 
     function createDebugSphere() {
-            
         sphereHand = {
             right: Overlays.addOverlay("sphere", {
                 position: MyAvatar.position,
@@ -633,6 +624,7 @@
             RayPick.setPrecisionPicking(rayPicks[side][finger], true);
         }
     }
+
     function activateNextRay(side, index) {
         var nextIndex = (index < fingerKeys.length-1) ? index + 1 : 0;
         for (var i = 0; i < fingerKeys.length; i++) {
@@ -646,7 +638,6 @@
     }
 
     function updateSphereHand(side) {
-
         var data = new Palm();
         dataRelativeToWorld(side, palmData[side], data);
         varsToDebug.palmData[side] = palmData[side];
@@ -656,7 +647,6 @@
         var dist = LOOKUP_DISTANCE_MULTIPLIER*data.distance;
 
         // Situate the debugging overlays
-        
         var checkOffset = {
             x: data.perpendicular.x * dist,
             y: data.perpendicular.y * dist,
@@ -694,12 +684,12 @@
         }
 
         // Update the intersection of only one finger at a time
-
         var finger = fingerKeys[updateFingerWithIndex];
-
+        var nearbyEntities = Entities.findEntities(spherePos, dist);
-        
+        // Filter the entities that are allowed to be touched
-        var grabbables = Entities.findEntities(spherePos, dist);
+        var touchableEntities = nearbyEntities.filter(function (id) {
-        
+            return untouchableEntities.indexOf(id) == -1;
+        });
         var intersection;
         if (rayPicks[side][finger] !== undefined) {
             intersection = RayPick.getPrevRayPickResult(rayPicks[side][finger]);
@@ -708,9 +698,8 @@
         var animationSteps = defaultAnimationSteps;
         var newFingerData = dataDefault[side][finger];
         var isAbleToGrab = false;
-        if (grabbables.length > 0) {    
+        if (touchableEntities.length > 0) {
-        
+            RayPick.setIncludeItems(rayPicks[side][finger], touchableEntities);
-            RayPick.setIncludeItems(rayPicks[side][finger], grabbables);
 
             if (intersection === undefined) {
                 return;
@@ -726,7 +715,6 @@
             isTouching[side][finger] = isAbleToGrab;
             if (isAbleToGrab) {
                 // update the open/close percentage for this finger
-                
                 var FINGER_REACT_MULTIPLIER = 2.8;
 
                 percent = intersection.distance/(FINGER_REACT_MULTIPLIER*dist);
@@ -761,7 +749,6 @@
     }
 
     // Recreate the finger joint names
-    
     function getJointNames(side, finger, count) {
         var names = [];
         for (var i = 1; i < count+1; i++) {
@@ -772,26 +759,30 @@
     }
 
     // Capture the controller values
-    
     var leftTriggerPress = function (value) {
         varsToDebug.triggerValues.leftTriggerValue = value;
         // the value for the trigger increments the hand-close percentage
         grabPercent.left = value;
     };
+
     var leftTriggerClick = function (value) {
         varsToDebug.triggerValues.leftTriggerClicked = value;
     };
+
     var rightTriggerPress = function (value) {
         varsToDebug.triggerValues.rightTriggerValue = value;
         // the value for the trigger increments the hand-close percentage
         grabPercent.right = value;
     };
+
     var rightTriggerClick = function (value) {
         varsToDebug.triggerValues.rightTriggerClicked = value;
     };
+
     var leftSecondaryPress = function (value) {
         varsToDebug.triggerValues.leftSecondaryValue = value;
     };
+
     var rightSecondaryPress = function (value) {
         varsToDebug.triggerValues.rightSecondaryValue = value;
     };
@@ -814,6 +805,7 @@
         createDebugLines();
         linesCreated = true;
     }
+
     if (showSphere && !sphereCreated) {
         createDebugSphere();
         sphereCreated = true;
@@ -840,6 +832,57 @@
         });
     }
 
+    function cleanUp() {
+        ["right", "left"].forEach(function (side) {
+            if (linesCreated) {
+                Overlays.deleteOverlay(palmRay[side]);
+            }
+            if (sphereCreated) {
+                Overlays.deleteOverlay(sphereHand[side]);
+            }
+            clearRayPicks(side);
+            for (var i = 0; i < fingerKeys.length; i++) {
+                var finger = fingerKeys[i];
+                var jointSuffixes = 3; // We need to clear the joints 0, 1 and 2 joints
+                var names = getJointNames(side, finger, jointSuffixes);
+                for (var j = 0; j < names.length; j++) {
+                    var index = MyAvatar.getJointIndex(names[j]);
+                    MyAvatar.clearJointData(index);
+                }
+                if (linesCreated) {
+                    Overlays.deleteOverlay(fingerRays[side][finger]);
+                }
+            }
+        });
+    }
+
+    MyAvatar.shouldDisableHandTouchChanged.connect(function (shouldDisable) {
+        if (shouldDisable) {
+            if (handTouchEnabled) {
+                cleanUp();
+            }
+        } else {
+            if (!handTouchEnabled) {
+                reEstimatePalmData();
+                recreateRayPicks();
+            }
+        }
+        handTouchEnabled = !shouldDisable;
+    });
+
+    MyAvatar.disableHandTouchForIDChanged.connect(function (entityID, disable) {
+        var entityIndex = untouchableEntities.indexOf(entityID);
+        if (disable) {
+            if (entityIndex == -1) {
+                untouchableEntities.push(entityID);
+            }
+        } else {
+            if (entityIndex != -1) {
+                untouchableEntities.splice(entityIndex, 1);
+            }
+        }
+    });
+
     MyAvatar.onLoadComplete.connect(function () {
         // Sometimes the rig is not ready when this signal is trigger
         console.log("avatar loaded");
@@ -854,36 +897,16 @@
     });
 
     Script.scriptEnding.connect(function () {
-        ["right", "left"].forEach(function(side) {
+        cleanUp();
-            if (linesCreated) {
-                Overlays.deleteOverlay(palmRay[side]); 
-            }
-            if (sphereCreated) {
-                Overlays.deleteOverlay(sphereHand[side]); 
-            }
-            clearRayPicks(side);
-            for (var i = 0; i < fingerKeys.length; i++) {
-
-                var finger = fingerKeys[i];
-                var jointSuffixes = 3; // We need to clear the joints 0, 1 and 2 joints
-                var names = getJointNames(side, finger, jointSuffixes); 
-                
-                for (var j = 0; j < names.length; j++) {
-                    var index = MyAvatar.getJointIndex(names[j]);
-                    MyAvatar.clearJointData(index);
-                }
-                
-                if (linesCreated) {
-                    Overlays.deleteOverlay(fingerRays[side][finger]);
-                }  
-            }
-        });
     });
 
     Script.update.connect(function () {
 
-        // index of the finger that needs to be updated this frame
+        if (!handTouchEnabled) {
+            return;
+        }
 
+        // index of the finger that needs to be updated this frame
         updateFingerWithIndex = (updateFingerWithIndex < fingerKeys.length-1) ? updateFingerWithIndex + 1 : 0;
 
         ["right", "left"].forEach(function(side) {
@@ -901,18 +924,15 @@
             var isHandTouching = getTouching(side);
             countToDefault[side] = isHandTouching ? 0 : countToDefault[side] + 1;
 
-            
             for (var i = 0; i < fingerKeys.length; i++) {
                 var finger = fingerKeys[i];
                 var jointSuffixes = 3; // We need to update rotation of the 0, 1 and 2 joints
                 var names = getJointNames(side, finger, jointSuffixes);
 
                 // Add the animation increments
-                
                 dataCurrent[side][finger] = addVals(dataCurrent[side][finger], dataDelta[side][finger], 1);
 
                 // update every finger joint
-                
                 for (var j = 0; j < names.length; j++) {
                     var index = MyAvatar.getJointIndex(names[j]);
                     // if no finger is touching restate the default poses

scripts/system/edit.js

@@ -63,6 +63,15 @@ var createToolsWindow = new CreateWindow(
     false
 );
 
+/**
+ * @description Returns true in case we should use the tablet version of the CreateApp
+ * @returns boolean
+ */
+var shouldUseEditTabletApp = function() {
+    return HMD.active || (!HMD.active && !Settings.getValue("desktopTabletBecomesToolbar", true));
+};
+
+
 var selectionDisplay = SelectionDisplay;
 var selectionManager = SelectionManager;
 
@@ -88,11 +97,12 @@ var cameraManager = new CameraManager();
 var grid = new Grid();
 var gridTool = new GridTool({
     horizontalGrid: grid,
-    createToolsWindow: createToolsWindow
+    createToolsWindow: createToolsWindow,
+    shouldUseEditTabletApp: shouldUseEditTabletApp
 });
 gridTool.setVisible(false);
 
-var entityListTool = new EntityListTool();
+var entityListTool = new EntityListTool(shouldUseEditTabletApp);
 
 selectionManager.addEventListener(function () {
     selectionDisplay.updateHandles();
@@ -578,7 +588,8 @@ var toolBar = (function () {
         });
         createButton = activeButton;
         tablet.screenChanged.connect(function (type, url) {
-            var isGoingToHomescreenOnDesktop = (!HMD.active && (url === 'hifi/tablet/TabletHome.qml' || url === ''));
+            var isGoingToHomescreenOnDesktop = (!shouldUseEditTabletApp() &&
+                (url === 'hifi/tablet/TabletHome.qml' || url === ''));
             if (isActive && (type !== "QML" || url !== "hifi/tablet/Edit.qml") && !isGoingToHomescreenOnDesktop) {
                 that.setActive(false);
             }
@@ -605,7 +616,7 @@ var toolBar = (function () {
         });
         function createNewEntityDialogButtonCallback(entityType) {
             return function() {
-                if (HMD.active) {
+                if (shouldUseEditTabletApp()) {
                     // tablet version of new-model dialog
                     var tablet = Tablet.getTablet("com.highfidelity.interface.tablet.system");
                     tablet.pushOntoStack("hifi/tablet/New" + entityType + "Dialog.qml");
@@ -837,7 +848,7 @@ var toolBar = (function () {
             selectionDisplay.triggerMapping.disable();
             tablet.landscape = false;
         } else {
-            if (HMD.active) {
+            if (shouldUseEditTabletApp()) {
                 tablet.loadQMLSource("hifi/tablet/Edit.qml", true);
             } else {
                 // make other apps inactive while in desktop mode
@@ -1989,8 +2000,8 @@ var PropertiesTool = function (opts) {
 
     that.setVisible = function (newVisible) {
         visible = newVisible;
-        webView.setVisible(HMD.active && visible);
+        webView.setVisible(shouldUseEditTabletApp() && visible);
-        createToolsWindow.setVisible(!HMD.active && visible);
+        createToolsWindow.setVisible(!shouldUseEditTabletApp() && visible);
     };
 
     that.setVisible(false);
@@ -2416,7 +2427,7 @@ function selectParticleEntity(entityID) {
 
     // Switch to particle explorer
     var selectTabMethod = { method: 'selectTab', params: { id: 'particle' } };
-    if (HMD.active) {
+    if (shouldUseEditTabletApp()) {
         var tablet = Tablet.getTablet("com.highfidelity.interface.tablet.system");
         tablet.sendToQml(selectTabMethod);
     } else {

scripts/system/libraries/entityList.js

@@ -11,7 +11,7 @@
 /* global EntityListTool, Tablet, selectionManager, Entities, Camera, MyAvatar, Vec3, Menu, Messages,
    cameraManager, MENU_EASE_ON_FOCUS, deleteSelectedEntities, toggleSelectedEntitiesLocked, toggleSelectedEntitiesVisible */
 
-EntityListTool = function() {
+EntityListTool = function(shouldUseEditTabletApp) {
     var that = {};
 
     var CreateWindow = Script.require('../modules/createWindow.js');
@@ -55,8 +55,8 @@ EntityListTool = function() {
 
     that.setVisible = function(newVisible) {
         visible = newVisible;
-        webView.setVisible(HMD.active && visible);
+        webView.setVisible(shouldUseEditTabletApp() && visible);
-        entityListWindow.setVisible(!HMD.active && visible);
+        entityListWindow.setVisible(!shouldUseEditTabletApp() && visible);
     };
 
     that.setVisible(false);

scripts/system/libraries/gridTool.js

@@ -1,6 +1,6 @@
 var GRID_CONTROLS_HTML_URL = Script.resolvePath('../html/gridControls.html');
 
-Grid = function(opts) {
+Grid = function() {
     var that = {};
     var gridColor = { red: 0, green: 0, blue: 0 };
     var gridAlpha = 0.6;
@@ -247,6 +247,7 @@ GridTool = function(opts) {
     var horizontalGrid = opts.horizontalGrid;
     var verticalGrid = opts.verticalGrid;
     var createToolsWindow = opts.createToolsWindow;
+    var shouldUseEditTabletApp = opts.shouldUseEditTabletApp;
     var listeners = [];
 
     var webView = null;
@@ -299,7 +300,7 @@ GridTool = function(opts) {
     };
 
     that.setVisible = function(visible) {
-        webView.setVisible(HMD.active && visible);
+        webView.setVisible(shouldUseEditTabletApp() && visible);
     };
 
     return that;