From 6b28f3ea0dd1536bd480403bb8c3e3407cd7b99e Mon Sep 17 00:00:00 2001 From: David Rowe Date: Fri, 31 Jul 2020 15:20:13 +1200 Subject: [PATCH] Reinstate TODOs --- interface/src/ui/DialogsManager.cpp | 5 +++++ interface/src/ui/LoginDialog.cpp | 3 +++ 2 files changed, 8 insertions(+) diff --git a/interface/src/ui/DialogsManager.cpp b/interface/src/ui/DialogsManager.cpp index c61d4c4069..9cad1b8a9e 100644 --- a/interface/src/ui/DialogsManager.cpp +++ b/interface/src/ui/DialogsManager.cpp @@ -144,6 +144,11 @@ void DialogsManager::showDomainLoginDialog() { LoginDialog::showWithSelection(); } +// #######: TODO: Domain version of toggleLoginDialog()? + +// #######: TODO: Domain version of hiadLoginDialog()? + + void DialogsManager::showUpdateDialog() { UpdateDialog::show(); } diff --git a/interface/src/ui/LoginDialog.cpp b/interface/src/ui/LoginDialog.cpp index d64ebdf42a..cd686719ea 100644 --- a/interface/src/ui/LoginDialog.cpp +++ b/interface/src/ui/LoginDialog.cpp @@ -146,6 +146,9 @@ void LoginDialog::login(const QString& username, const QString& password) const void LoginDialog::loginDomain(const QString& username, const QString& password, const QString& domainAuthProvider) const { qDebug() << "Attempting to login" << username << "into a domain through" << domainAuthProvider; DependencyManager::get()->requestAccessToken(username, password, domainAuthProvider); + + // ####### TODO: It may not be necessary to pass domainAuthProvider to the login dialog and through to here because it was + // originally provided to the QML from C++. } void LoginDialog::loginThroughOculus() {