Merge pull request #1224 from birarda/master

use virtual deleteOrDeleteLater in NodeData to handle AvatarVoxelSystem

interface/src/avatar/Avatar.cpp

@@ -255,6 +255,11 @@ Avatar::~Avatar() {
     delete _balls;
 }
 
+void Avatar::deleteOrDeleteLater() {
+    this->deleteLater();
+}
+
+
 void Avatar::init() {
     _head.init();
     _hand.init();

interface/src/avatar/Avatar.h

@@ -134,6 +134,7 @@ public:
     
     Avatar(Node* owningNode = NULL);
     ~Avatar();
+    void deleteOrDeleteLater();
     
     void init();
     void simulate(float deltaTime, Transmitter* transmitter);

libraries/shared/src/Node.cpp

@@ -21,7 +21,6 @@
 #include "SharedUtil.h"
 #include "UDPSocket.h"
 
-#include <QtCore/QCoreApplication>
 #include <QtCore/QDebug>
 
 Node::Node(const QUuid& uuid, char type, sockaddr* publicSocket, sockaddr* localSocket) :
@@ -44,14 +43,8 @@ Node::~Node() {
     delete _publicSocket;
     delete _localSocket;
     
-    if (QCoreApplication::instance()) {
+    if (_linkedData) {
-        // even if we have a QCoreApplication instance we don't get here unless it's been exec'ed
+        _linkedData->deleteOrDeleteLater();
-        // which is only currently the case for interface
-        if (_linkedData) {
-            _linkedData->deleteLater();
-        }
-    } else {
-        delete _linkedData;
     }
     
     delete _bytesReceivedMovingAverage;

libraries/shared/src/NodeData.cpp

@@ -16,4 +16,8 @@ NodeData::NodeData(Node* owningNode) :
 
 NodeData::~NodeData() {
 
+}
+
+void NodeData::deleteOrDeleteLater() {
+    delete this;
 }

libraries/shared/src/NodeData.h

@@ -21,6 +21,8 @@ public:
     virtual ~NodeData() = 0;
     virtual int parseData(unsigned char* sourceBuffer, int numBytes) = 0;
     
+    virtual void deleteOrDeleteLater();
+    
     Node* getOwningNode() { return _owningNode; }
 protected:
     Node* _owningNode;