From 6442055600d53a76dca90c90b0f39c0de20b0f0e Mon Sep 17 00:00:00 2001 From: kasenvr <52365539+kasenvr@users.noreply.github.com> Date: Tue, 13 Oct 2020 04:59:04 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: David Rowe --- scripts/system/onFirstRun.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/system/onFirstRun.js b/scripts/system/onFirstRun.js index b7efc24297..785017b935 100644 --- a/scripts/system/onFirstRun.js +++ b/scripts/system/onFirstRun.js @@ -14,9 +14,13 @@ (function() { // BEGIN LOCAL_SCOPE var SETTING_TO_CHECK = 'firstRun'; - var DEFAULT_NAME = ''; + var DEFAULT_DISPLAY_NAME = ''; - if ((Settings.getValue('firstRun', false) && MyAvatar.displayName === '') || MyAvatar.displayName === '') { + if (!Settings.getValue('firstRun', false)) { + return; + } + + if (MyAvatar.displayName === '') { var selectedDisplayName = Window.prompt('Enter a display name.', MyAvatar.displayName); if (selectedDisplayName === '') {