From 61452c21a2d877a75be54686e91e15cec6abb9cc Mon Sep 17 00:00:00 2001 From: humbletim Date: Sun, 6 Nov 2016 09:40:28 -0500 Subject: [PATCH] bail early from irrecoverable retry situations --- libraries/script-engine/src/ScriptCache.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libraries/script-engine/src/ScriptCache.cpp b/libraries/script-engine/src/ScriptCache.cpp index 96e3d7e914..941c0b6175 100644 --- a/libraries/script-engine/src/ScriptCache.cpp +++ b/libraries/script-engine/src/ScriptCache.cpp @@ -202,7 +202,14 @@ void ScriptCache::scriptContentAvailable() { finished = true; qCDebug(scriptengine) << "Done downloading script at:" << url.toString(); } else { - if (scriptRequest.numRetries < MAX_RETRIES) { + auto result = req->getResult(); + bool irrecoverable = + result == ResourceRequest::AccessDenied || + result == ResourceRequest::InvalidURL || + result == ResourceRequest::NotFound || + scriptRequest.numRetries >= MAX_RETRIES; + + if (!irrecoverable) { ++scriptRequest.numRetries; qDebug() << "Script request failed: " << url;