From 6026e055aaa173978e300ffcf7bfc00fe6592ae4 Mon Sep 17 00:00:00 2001 From: ZappoMan Date: Sat, 30 Apr 2016 15:45:42 -0700 Subject: [PATCH] more CR feedback removed redundant abort code --- libraries/script-engine/src/ScriptEngine.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libraries/script-engine/src/ScriptEngine.cpp b/libraries/script-engine/src/ScriptEngine.cpp index fc09c21929..3b8b4925ad 100644 --- a/libraries/script-engine/src/ScriptEngine.cpp +++ b/libraries/script-engine/src/ScriptEngine.cpp @@ -221,7 +221,8 @@ void ScriptEngine::waitTillDoneRunning() { auto elapsed = stillWaiting - startedWaiting; // if we've been waiting a second or more, then tell the script engine to stop evaluating - if (elapsed > USECS_PER_SECOND) { + static const auto MAX_SCRIPT_EVALUATION_TIME = USECS_PER_SECOND; + if (elapsed > MAX_SCRIPT_EVALUATION_TIME) { qCDebug(scriptengine) << "Script " << scriptName << " has been running too long [" << elapsed << "] aborting evaluation."; threadSafeAbortEvaluation(); }