Repeated logging - Fixes and clean-up

This commit is contained in:
Simon Walton 2018-04-03 12:23:21 -07:00
parent a7fc6a2991
commit 5b0bcd76e3
2 changed files with 6 additions and 5 deletions

View file

@ -27,7 +27,8 @@ Q_DECLARE_LOGGING_CATEGORY(messages_client)
QString logString_; \
QDebug debugString_(&logString_); \
debugString_ << msg; \
LogHandler::getInstance().printRepeatedMessage(repeatedMessageID_, LogDebug, QMessageLogContext(), logString_); \
LogHandler::getInstance().printRepeatedMessage(repeatedMessageID_, LogDebug, QMessageLogContext(__FILE__, \
__LINE__, __func__, category().categoryName()), logString_); \
} \
} while (false)

View file

@ -112,8 +112,8 @@ void LogHandler::flushRepeatedMessages() {
for (int m = 0; m < (int)_repeatCounts.size(); ++m) {
int repeatCount = _repeatCounts[m];
if (repeatCount > 1) {
QString repeatLogMessage = QString(repeatCount) + " repeated log entries - Last entry: \"" + _repeatedMessageStrings[m]
+ "\"";
QString repeatLogMessage = QString().setNum(repeatCount) + " repeated log entries - Last entry: \""
+ _repeatedMessageStrings[m] + "\"";
printMessage(LogSuppressed, QMessageLogContext(), repeatLogMessage);
_repeatCounts[m] = 0;
_repeatedMessageStrings[m] = QString();
@ -239,8 +239,8 @@ int LogHandler::newRepeatedMessageID() {
return newMessageId;
}
void LogHandler::printRepeatedMessage(int messageID, LogMsgType type, const QMessageLogContext & context,
const QString & message) {
void LogHandler::printRepeatedMessage(int messageID, LogMsgType type, const QMessageLogContext& context,
const QString& message) {
QMutexLocker lock(&_mutex);
if (messageID >= _currentMessageID) {
return;