From 5adcf6875241fd7c58ec309f026e8b866fd87a8a Mon Sep 17 00:00:00 2001
From: Stephen Birarda <commit@birarda.com>
Date: Mon, 7 Apr 2014 09:08:51 -0700
Subject: [PATCH] sort nodes on DS page by their uptime

---
 domain-server/resources/web/index.shtml  |  1 +
 domain-server/resources/web/js/tables.js | 16 ++++++++++++++--
 domain-server/src/DomainServer.cpp       |  4 ++++
 libraries/shared/src/Node.cpp            |  3 ++-
 libraries/shared/src/Node.h              |  6 +++---
 5 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/domain-server/resources/web/index.shtml b/domain-server/resources/web/index.shtml
index bba4dc4d22..afd0af1679 100644
--- a/domain-server/resources/web/index.shtml
+++ b/domain-server/resources/web/index.shtml
@@ -12,6 +12,7 @@
         <th>Pool</th>
         <th>Public</th>
         <th>Local</th>
+        <th>Uptime (s)</th>
         <th>Kill?</th>
       </tr>
     </thead>
diff --git a/domain-server/resources/web/js/tables.js b/domain-server/resources/web/js/tables.js
index 3f7b2b7b28..a4884486c3 100644
--- a/domain-server/resources/web/js/tables.js
+++ b/domain-server/resources/web/js/tables.js
@@ -5,13 +5,21 @@ $(document).ready(function(){
       
       json.nodes.sort(function(a, b){
           if (a.type === b.type) {
-            return 0;
+            if (a.wake_timestamp < b.wake_timestamp) {
+              return 1;
+            } else if (a.wake_timestamp > b.wake_timestamp) {
+              return -1;
+            } else {
+              return 0;
+            }
           } 
               
           if (a.type === "agent" && b.type !== "agent") {
             return 1;
+          } else if (b.type === "agent" && a.type !== "agent") {
+            return -1;
           }
-              
+          
           if (a.type > b.type) {
             return 1;
           }
@@ -30,6 +38,10 @@ $(document).ready(function(){
         nodesTableBody += "<td>" + (data.pool ? data.pool : "") + "</td>";
         nodesTableBody += "<td>" + data.public.ip + "<span class='port'>:" + data.public.port + "</span></td>";
         nodesTableBody += "<td>" + data.local.ip + "<span class='port'>:" + data.local.port + "</span></td>";
+        
+        var uptimeSeconds = (Date.now() - data.wake_timestamp) / 1000;
+        nodesTableBody += "<td>" + uptimeSeconds.toLocaleString() + "</td>";
+        
         nodesTableBody += "<td><span class='glyphicon glyphicon-remove' data-uuid=" + data.uuid + "></span></td>";
         nodesTableBody += "</tr>";
       });
diff --git a/domain-server/src/DomainServer.cpp b/domain-server/src/DomainServer.cpp
index d18f12ec7f..8d1ee9d3dd 100644
--- a/domain-server/src/DomainServer.cpp
+++ b/domain-server/src/DomainServer.cpp
@@ -627,6 +627,7 @@ const char JSON_KEY_TYPE[] = "type";
 const char JSON_KEY_PUBLIC_SOCKET[] = "public";
 const char JSON_KEY_LOCAL_SOCKET[] = "local";
 const char JSON_KEY_POOL[] = "pool";
+const char JSON_KEY_WAKE_TIMESTAMP[] = "wake_timestamp";
 
 QJsonObject DomainServer::jsonObjectForNode(const SharedNodePointer& node) {
     QJsonObject nodeJson;
@@ -646,6 +647,9 @@ QJsonObject DomainServer::jsonObjectForNode(const SharedNodePointer& node) {
     nodeJson[JSON_KEY_PUBLIC_SOCKET] = jsonForSocket(node->getPublicSocket());
     nodeJson[JSON_KEY_LOCAL_SOCKET] = jsonForSocket(node->getLocalSocket());
     
+    // add the node uptime in our list
+    nodeJson[JSON_KEY_WAKE_TIMESTAMP] = QString::number(node->getWakeTimestamp());
+    
     // if the node has pool information, add it
     SharedAssignmentPointer matchingAssignment = _staticAssignmentHash.value(node->getUUID());
     if (matchingAssignment) {
diff --git a/libraries/shared/src/Node.cpp b/libraries/shared/src/Node.cpp
index a4491fb707..1e78bc3feb 100644
--- a/libraries/shared/src/Node.cpp
+++ b/libraries/shared/src/Node.cpp
@@ -19,6 +19,7 @@
 #include "SharedUtil.h"
 
 #include <QtCore/QDataStream>
+#include <QtCore/QDateTime>
 #include <QtCore/QDebug>
 
 const QString UNKNOWN_NodeType_t_NAME = "Unknown";
@@ -47,7 +48,7 @@ const QString& NodeType::getNodeTypeName(NodeType_t nodeType) {
 Node::Node(const QUuid& uuid, char type, const HifiSockAddr& publicSocket, const HifiSockAddr& localSocket) :
     _type(type),
     _uuid(uuid),
-    _wakeMicrostamp(usecTimestampNow()),
+    _wakeTimestamp(QDateTime::currentMSecsSinceEpoch()),
     _lastHeardMicrostamp(usecTimestampNow()),
     _publicSocket(publicSocket),
     _localSocket(localSocket),
diff --git a/libraries/shared/src/Node.h b/libraries/shared/src/Node.h
index 79d75629a6..5d30d6f7b0 100644
--- a/libraries/shared/src/Node.h
+++ b/libraries/shared/src/Node.h
@@ -60,8 +60,8 @@ public:
     const QUuid& getUUID() const { return _uuid; }
     void setUUID(const QUuid& uuid) { _uuid = uuid; }
 
-    quint64 getWakeMicrostamp() const { return _wakeMicrostamp; }
-    void setWakeMicrostamp(quint64 wakeMicrostamp) { _wakeMicrostamp = wakeMicrostamp; }
+    quint64 getWakeTimestamp() const { return _wakeTimestamp; }
+    void setWakeTimestamp(quint64 wakeTimestamp) { _wakeTimestamp = wakeTimestamp; }
 
     quint64 getLastHeardMicrostamp() const { return _lastHeardMicrostamp; }
     void setLastHeardMicrostamp(quint64 lastHeardMicrostamp) { _lastHeardMicrostamp = lastHeardMicrostamp; }
@@ -109,7 +109,7 @@ private:
 
     NodeType_t _type;
     QUuid _uuid;
-    quint64 _wakeMicrostamp;
+    quint64 _wakeTimestamp;
     quint64 _lastHeardMicrostamp;
     HifiSockAddr _publicSocket;
     HifiSockAddr _localSocket;