From 5a1eac563ba352cbbe1dc480c67d327ce489052b Mon Sep 17 00:00:00 2001 From: samcake Date: Mon, 2 Apr 2018 15:50:18 -0700 Subject: [PATCH] Code review fixes --- interface/src/LODManager.cpp | 10 ---------- scripts/system/notifications.js | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/interface/src/LODManager.cpp b/interface/src/LODManager.cpp index 2e8d3011d7..d7d73e962a 100644 --- a/interface/src/LODManager.cpp +++ b/interface/src/LODManager.cpp @@ -86,11 +86,6 @@ void LODManager::autoAdjustLOD(float realTimeDelta) { if (_octreeSizeScale < ADJUST_LOD_MIN_SIZE_SCALE) { _octreeSizeScale = ADJUST_LOD_MIN_SIZE_SCALE; } - // DEBUG: Less is more, avoid logging all the time - /* qCDebug(interfaceapp) << "adjusting LOD DOWN" - << "fps =" << currentFPS - << "targetFPS =" << getLODDecreaseFPS() - << "octreeSizeScale =" << _octreeSizeScale; */ emit LODDecreased(); // Assuming the LOD adjustment will work: we optimistically reset _avgRenderTime // to provide an FPS just above the decrease threshold. It will drift close to its @@ -112,11 +107,6 @@ void LODManager::autoAdjustLOD(float realTimeDelta) { if (_octreeSizeScale > ADJUST_LOD_MAX_SIZE_SCALE) { _octreeSizeScale = ADJUST_LOD_MAX_SIZE_SCALE; } - // DEBUG: Less is more, avoid logging all the time - /* qCDebug(interfaceapp) << "adjusting LOD UP" - << "fps =" << currentFPS - << "targetFPS =" << getLODDecreaseFPS() - << "octreeSizeScale =" << _octreeSizeScale; */ emit LODIncreased(); // Assuming the LOD adjustment will work: we optimistically reset _avgRenderTime // to provide an FPS just below the increase threshold. It will drift close to its diff --git a/scripts/system/notifications.js b/scripts/system/notifications.js index 94a8e1adec..8b68a9355e 100644 --- a/scripts/system/notifications.js +++ b/scripts/system/notifications.js @@ -84,7 +84,7 @@ var NOTIFICATION_MENU_ITEM_POST = " Notifications"; var PLAY_NOTIFICATION_SOUNDS_SETTING = "play_notification_sounds"; var PLAY_NOTIFICATION_SOUNDS_TYPE_SETTING_PRE = "play_notification_sounds_type_"; - var NOTIFICATIONS_MESSAGE_CHANNEL = "Hifi-Notifications" + var NOTIFICATIONS_MESSAGE_CHANNEL = "Hifi-Notifications"; var NotificationType = { UNKNOWN: 0,