CR feedback

This commit is contained in:
Zach Fox 2017-01-17 15:01:02 -08:00
parent 246f5fb7f5
commit 59ff970d5b

View file

@ -75,7 +75,7 @@ Item {
id: myDisplayNameText id: myDisplayNameText
// Properties // Properties
text: thisNameCard.displayName text: thisNameCard.displayName
maximumLength: 64 maximumLength: 256
clip: true clip: true
// Size // Size
width: parent.width width: parent.width
@ -84,7 +84,8 @@ Item {
anchors.verticalCenter: parent.verticalCenter anchors.verticalCenter: parent.verticalCenter
anchors.left: parent.left anchors.left: parent.left
anchors.leftMargin: 10 anchors.leftMargin: 10
anchors.rightMargin: editGlyph.implicitWidth + editGlyph.anchors.rightMargin anchors.right: parent.right
anchors.rightMargin: editGlyph.width + editGlyph.anchors.rightMargin
// Style // Style
color: hifi.colors.darkGray color: hifi.colors.darkGray
FontLoader { id: firaSansSemiBold; source: "../../fonts/FiraSans-SemiBold.ttf"; } FontLoader { id: firaSansSemiBold; source: "../../fonts/FiraSans-SemiBold.ttf"; }
@ -98,6 +99,7 @@ Item {
// Signals // Signals
onEditingFinished: { onEditingFinished: {
pal.sendToScript({method: 'displayNameUpdate', params: text}) pal.sendToScript({method: 'displayNameUpdate', params: text})
cursorPosition = 0
focus = false focus = false
myDisplayName.border.width = 0 myDisplayName.border.width = 0
color = hifi.colors.darkGray color = hifi.colors.darkGray