From 5fc09a68a8fd12dc7bf5bf583dac5beb2c92db88 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Thu, 27 Aug 2015 17:24:57 -0700 Subject: [PATCH] add an assert that enqueued packet is part of message --- libraries/networking/src/udt/Connection.cpp | 4 ++++ libraries/networking/src/udt/Socket.cpp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libraries/networking/src/udt/Connection.cpp b/libraries/networking/src/udt/Connection.cpp index fe545d8263..de4b76a972 100644 --- a/libraries/networking/src/udt/Connection.cpp +++ b/libraries/networking/src/udt/Connection.cpp @@ -737,6 +737,10 @@ void Connection::updateCongestionControlAndSendQueue(std::function cong } void PendingReceivedMessage::enqueuePacket(std::unique_ptr packet) { + Q_ASSERT_X(packet->isPartOfMessage(), + "PendingReceivedMessage::enqueuePacket", + "called with a packet that is not part of a message"); + if (_isComplete) { qCDebug(networking) << "UNEXPECTED: Received packet for a message that is already complete"; return; diff --git a/libraries/networking/src/udt/Socket.cpp b/libraries/networking/src/udt/Socket.cpp index 72174bf3e7..4b1f5f8a83 100644 --- a/libraries/networking/src/udt/Socket.cpp +++ b/libraries/networking/src/udt/Socket.cpp @@ -215,7 +215,7 @@ void Socket::readPendingDatagrams() { } else { // setup a Packet from the data we just read auto packet = Packet::fromReceivedPacket(std::move(buffer), packetSizeWithHeader, senderSockAddr); - + // call our verification operator to see if this packet is verified if (!_packetFilterOperator || _packetFilterOperator(*packet)) { if (packet->isReliable()) {