Merge pull request #13799 from davidkelly/dk/17340

Only update gain if it really changed
This commit is contained in:
Zach Fox 2018-08-10 16:20:24 -07:00 committed by GitHub
commit 57d2f04f14
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -526,11 +526,13 @@ Item {
anchors.left: nameCardVUMeter.left; anchors.left: nameCardVUMeter.left;
// Properties // Properties
visible: (isMyCard || (selected && pal.activeTab == "nearbyTab")) && isPresent; visible: (isMyCard || (selected && pal.activeTab == "nearbyTab")) && isPresent;
value: Users.getAvatarGain(uuid)
minimumValue: -60.0 minimumValue: -60.0
maximumValue: 20.0 maximumValue: 20.0
stepSize: 5 stepSize: 5
updateValueWhileDragging: true updateValueWhileDragging: true
Component.onCompleted: {
value = Users.getAvatarGain(uuid);
}
onValueChanged: { onValueChanged: {
updateGainFromQML(uuid, value, false); updateGainFromQML(uuid, value, false);
} }
@ -587,11 +589,13 @@ Item {
} }
function updateGainFromQML(avatarUuid, sliderValue, isReleased) { function updateGainFromQML(avatarUuid, sliderValue, isReleased) {
if (Users.getAvatarGain(avatarUuid) != sliderValue) {
Users.setAvatarGain(avatarUuid, sliderValue); Users.setAvatarGain(avatarUuid, sliderValue);
if (isReleased) { if (isReleased) {
UserActivityLogger.palAction("avatar_gain_changed", avatarUuid); UserActivityLogger.palAction("avatar_gain_changed", avatarUuid);
} }
} }
}
// Function body by Howard Stearns 2017-01-08 // Function body by Howard Stearns 2017-01-08
function goToUserInDomain(avatarUuid) { function goToUserInDomain(avatarUuid) {