Merge branch 'master' of github.com:highfidelity/hifi into notificationsForFourApps

This commit is contained in:
Zach Fox 2018-09-24 09:32:53 -07:00
commit 57c303440b
5 changed files with 25 additions and 29 deletions

View file

@ -2829,8 +2829,10 @@ void RayToAvatarIntersectionResultFromScriptValue(const QScriptValue& object, Ra
value.extraInfo = object.property("extraInfo").toVariant().toMap(); value.extraInfo = object.property("extraInfo").toVariant().toMap();
} }
// these coefficients can be changed via JS for experimental tuning
// use AvatatManager.setAvatarSortCoefficient("name", value) by a user with domain kick-rights
float AvatarData::_avatarSortCoefficientSize { 8.0f }; float AvatarData::_avatarSortCoefficientSize { 8.0f };
float AvatarData::_avatarSortCoefficientCenter { 4.0f }; float AvatarData::_avatarSortCoefficientCenter { 0.25f };
float AvatarData::_avatarSortCoefficientAge { 1.0f }; float AvatarData::_avatarSortCoefficientAge { 1.0f };
QScriptValue AvatarEntityMapToScriptValue(QScriptEngine* engine, const AvatarEntityMap& value) { QScriptValue AvatarEntityMapToScriptValue(QScriptEngine* engine, const AvatarEntityMap& value) {

View file

@ -538,7 +538,6 @@ void AccountManager::requestAccessToken(const QString& login, const QString& pas
QNetworkReply* requestReply = networkAccessManager.post(request, postData); QNetworkReply* requestReply = networkAccessManager.post(request, postData);
connect(requestReply, &QNetworkReply::finished, this, &AccountManager::requestAccessTokenFinished); connect(requestReply, &QNetworkReply::finished, this, &AccountManager::requestAccessTokenFinished);
connect(requestReply, SIGNAL(error(QNetworkReply::NetworkError)), this, SLOT(requestAccessTokenError(QNetworkReply::NetworkError)));
} }
void AccountManager::requestAccessTokenWithSteam(QByteArray authSessionTicket) { void AccountManager::requestAccessTokenWithSteam(QByteArray authSessionTicket) {
@ -633,12 +632,6 @@ void AccountManager::requestAccessTokenFinished() {
} }
} }
void AccountManager::requestAccessTokenError(QNetworkReply::NetworkError error) {
// TODO: error handling
qCDebug(networking) << "AccountManager: failed to fetch access token - " << error;
emit loginFailed();
}
void AccountManager::refreshAccessTokenFinished() { void AccountManager::refreshAccessTokenFinished() {
QNetworkReply* requestReply = reinterpret_cast<QNetworkReply*>(sender()); QNetworkReply* requestReply = reinterpret_cast<QNetworkReply*>(sender());

View file

@ -106,7 +106,6 @@ public slots:
void requestAccessTokenFinished(); void requestAccessTokenFinished();
void refreshAccessTokenFinished(); void refreshAccessTokenFinished();
void requestProfileFinished(); void requestProfileFinished();
void requestAccessTokenError(QNetworkReply::NetworkError error);
void refreshAccessTokenError(QNetworkReply::NetworkError error); void refreshAccessTokenError(QNetworkReply::NetworkError error);
void requestProfileError(QNetworkReply::NetworkError error); void requestProfileError(QNetworkReply::NetworkError error);
void logout(); void logout();

View file

@ -27,8 +27,11 @@ const COMPARE_ASCENDING = function(a, b) {
return -1; return -1;
} else if (va > vb) { } else if (va > vb) {
return 1; return 1;
} else if (a.id < b.id) {
return -1;
} }
return 0;
return 1;
} }
const COMPARE_DESCENDING = function(a, b) { const COMPARE_DESCENDING = function(a, b) {
return COMPARE_ASCENDING(b, a); return COMPARE_ASCENDING(b, a);
@ -223,15 +226,15 @@ function loaded() {
type: type, type: type,
url: filename, url: filename,
fullUrl: entity.url, fullUrl: entity.url,
locked: entity.locked ? LOCKED_GLYPH : null, locked: entity.locked,
visible: entity.visible ? VISIBLE_GLYPH : null, visible: entity.visible,
verticesCount: displayIfNonZero(entity.verticesCount), verticesCount: entity.verticesCount,
texturesCount: displayIfNonZero(entity.texturesCount), texturesCount: entity.texturesCount,
texturesSize: decimalMegabytes(entity.texturesSize), texturesSize: entity.texturesSize,
hasTransparent: entity.hasTransparent ? TRANSPARENCY_GLYPH : null, hasTransparent: entity.hasTransparent,
isBaked: entity.isBaked ? BAKED_GLYPH : null, isBaked: entity.isBaked,
drawCalls: displayIfNonZero(entity.drawCalls), drawCalls: entity.drawCalls,
hasScript: entity.hasScript ? SCRIPT_GLYPH : null, hasScript: entity.hasScript,
} }
entities.push(entityData); entities.push(entityData);
@ -259,15 +262,15 @@ function loaded() {
addColumn('type', entity.type); addColumn('type', entity.type);
addColumn('name', entity.name); addColumn('name', entity.name);
addColumn('url', entity.url); addColumn('url', entity.url);
addColumnHTML('locked glyph', entity.locked); addColumnHTML('locked glyph', entity.locked ? LOCKED_GLYPH : null);
addColumnHTML('visible glyph', entity.visible); addColumnHTML('visible glyph', entity.visible ? VISIBLE_GLYPH : null);
addColumn('verticesCount', entity.verticesCount); addColumn('verticesCount', displayIfNonZero(entity.verticesCount));
addColumn('texturesCount', entity.texturesCount); addColumn('texturesCount', displayIfNonZero(entity.texturesCount));
addColumn('texturesSize', entity.texturesSize); addColumn('texturesSize', decimalMegabytes(entity.texturesSize));
addColumnHTML('hasTransparent glyph', entity.hasTransparent); addColumnHTML('hasTransparent glyph', entity.hasTransparent ? TRANSPARENCY_GLYPH : null);
addColumnHTML('isBaked glyph', entity.isBaked); addColumnHTML('isBaked glyph', entity.isBaked ? BAKED_GLYPH : null);
addColumn('drawCalls', entity.drawCalls); addColumn('drawCalls', displayIfNonZero(entity.drawCalls));
addColumn('hasScript glyph', entity.hasScript); addColumn('hasScript glyph', entity.hasScript ? SCRIPT_GLYPH : null);
row.addEventListener('click', onRowClicked); row.addEventListener('click', onRowClicked);
row.addEventListener('dblclick', onRowDoubleClicked); row.addEventListener('dblclick', onRowDoubleClicked);

View file

@ -140,7 +140,6 @@
localPosition: { x: 0.0 , y: -1.5, z: -0.3 }, localPosition: { x: 0.0 , y: -1.5, z: -0.3 },
url: Script.resourcesPath() + "images/interstitialPage/goTo_button.png", url: Script.resourcesPath() + "images/interstitialPage/goTo_button.png",
alpha: 1, alpha: 1,
dimensions: { x: 1.5, y: 1.0 },
visible: isVisible, visible: isVisible,
emissive: true, emissive: true,
ignoreRayIntersection: false, ignoreRayIntersection: false,