From e988941d14f84059d25f757c088b00a6d6a66af3 Mon Sep 17 00:00:00 2001 From: Seth Alves Date: Fri, 21 Oct 2016 10:53:13 -0700 Subject: [PATCH 1/4] undo bad script-engine AC change --- assignment-client/src/AssignmentClient.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/assignment-client/src/AssignmentClient.cpp b/assignment-client/src/AssignmentClient.cpp index 2bba2e2427..798510466b 100644 --- a/assignment-client/src/AssignmentClient.cpp +++ b/assignment-client/src/AssignmentClient.cpp @@ -56,10 +56,7 @@ AssignmentClient::AssignmentClient(Assignment::Type requestAssignmentType, QStri auto scriptableAvatar = DependencyManager::set(); auto addressManager = DependencyManager::set(); - - if (requestAssignmentType == Assignment::AgentType) { - auto scriptEngines = DependencyManager::set(); - } + auto scriptEngines = DependencyManager::set(); // create a NodeList as an unassigned client, must be after addressManager auto nodeList = DependencyManager::set(NodeType::Unassigned, listenPort); From 30f29d179680d3701a393fccf9172522e3b8e52f Mon Sep 17 00:00:00 2001 From: Seth Alves Date: Fri, 21 Oct 2016 10:57:22 -0700 Subject: [PATCH 2/4] move ScriptEngines to Agent --- assignment-client/src/Agent.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/assignment-client/src/Agent.cpp b/assignment-client/src/Agent.cpp index 14b3c0e90f..8daca1bfd9 100644 --- a/assignment-client/src/Agent.cpp +++ b/assignment-client/src/Agent.cpp @@ -67,6 +67,7 @@ Agent::Agent(ReceivedMessage& message) : DependencyManager::set(); DependencyManager::set(); DependencyManager::set(); + auto scriptEngines = DependencyManager::set(); auto& packetReceiver = DependencyManager::get()->getPacketReceiver(); @@ -588,9 +589,10 @@ void Agent::aboutToFinish() { DependencyManager::get()->setEntityTree(nullptr); ResourceManager::cleanup(); - + // cleanup the AudioInjectorManager (and any still running injectors) DependencyManager::destroy(); + DependencyManager::destroy(); emit stopAvatarAudioTimer(); _avatarAudioTimerThread.quit(); From 5af8dfdfbda9fa6424d43a15ec17133757b99033 Mon Sep 17 00:00:00 2001 From: Seth Alves Date: Fri, 21 Oct 2016 10:57:58 -0700 Subject: [PATCH 3/4] move ScriptEngines to Agent --- assignment-client/src/AssignmentClient.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/assignment-client/src/AssignmentClient.cpp b/assignment-client/src/AssignmentClient.cpp index 798510466b..8ddc45f1f2 100644 --- a/assignment-client/src/AssignmentClient.cpp +++ b/assignment-client/src/AssignmentClient.cpp @@ -56,7 +56,6 @@ AssignmentClient::AssignmentClient(Assignment::Type requestAssignmentType, QStri auto scriptableAvatar = DependencyManager::set(); auto addressManager = DependencyManager::set(); - auto scriptEngines = DependencyManager::set(); // create a NodeList as an unassigned client, must be after addressManager auto nodeList = DependencyManager::set(NodeType::Unassigned, listenPort); @@ -178,8 +177,6 @@ AssignmentClient::~AssignmentClient() { void AssignmentClient::aboutToQuit() { stopAssignmentClient(); - DependencyManager::destroy(); - // clear the log handler so that Qt doesn't call the destructor on LogHandler qInstallMessageHandler(0); } From 5660063702344d9261fa4ce00e549afd994be52e Mon Sep 17 00:00:00 2001 From: Seth Alves Date: Fri, 21 Oct 2016 11:05:50 -0700 Subject: [PATCH 4/4] code review --- assignment-client/src/Agent.cpp | 3 ++- assignment-client/src/AssignmentClient.cpp | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assignment-client/src/Agent.cpp b/assignment-client/src/Agent.cpp index 8daca1bfd9..eebd2a81e7 100644 --- a/assignment-client/src/Agent.cpp +++ b/assignment-client/src/Agent.cpp @@ -28,6 +28,7 @@ #include #include #include +#include #include #include @@ -67,7 +68,7 @@ Agent::Agent(ReceivedMessage& message) : DependencyManager::set(); DependencyManager::set(); DependencyManager::set(); - auto scriptEngines = DependencyManager::set(); + DependencyManager::set(); auto& packetReceiver = DependencyManager::get()->getPacketReceiver(); diff --git a/assignment-client/src/AssignmentClient.cpp b/assignment-client/src/AssignmentClient.cpp index 8ddc45f1f2..3b4300b6fd 100644 --- a/assignment-client/src/AssignmentClient.cpp +++ b/assignment-client/src/AssignmentClient.cpp @@ -31,7 +31,6 @@ #include #include #include -#include #include "AssignmentFactory.h" #include "AssignmentActionFactory.h"