From 5553c9f87fd0bcc6c8062aa8c7ddef80372aeaa6 Mon Sep 17 00:00:00 2001 From: David Rowe Date: Tue, 14 Jun 2016 07:46:41 +1200 Subject: [PATCH] Code review --- interface/src/scripting/WindowScriptingInterface.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/interface/src/scripting/WindowScriptingInterface.cpp b/interface/src/scripting/WindowScriptingInterface.cpp index 6579366cf8..f0ae221566 100644 --- a/interface/src/scripting/WindowScriptingInterface.cpp +++ b/interface/src/scripting/WindowScriptingInterface.cpp @@ -123,7 +123,7 @@ void WindowScriptingInterface::setPreviousBrowseLocation(const QString& location /// \return QScriptValue file path as a string if one was selected, otherwise `QScriptValue::NullValue` QScriptValue WindowScriptingInterface::browse(const QString& title, const QString& directory, const QString& nameFilter) { QString path = directory; - if (path == "") { + if (path.isEmpty()) { path = getPreviousBrowseLocation(); } #ifndef Q_OS_WIN @@ -144,7 +144,7 @@ QScriptValue WindowScriptingInterface::browse(const QString& title, const QStrin /// \return QScriptValue file path as a string if one was selected, otherwise `QScriptValue::NullValue` QScriptValue WindowScriptingInterface::save(const QString& title, const QString& directory, const QString& nameFilter) { QString path = directory; - if (path == "") { + if (path.isEmpty()) { path = getPreviousBrowseLocation(); } #ifndef Q_OS_WIN