From 52ef935acb850c755b6c2afe3db10b0d93e072b4 Mon Sep 17 00:00:00 2001
From: Cristian Luis Duarte <cristian.duarte.mb@gmail.com>
Date: Mon, 23 Apr 2018 21:43:27 -0300
Subject: [PATCH] Android - Search - Ripple effect on items and rounded corners
 using CardView

---
 android/app/build.gradle                      |  1 +
 .../app/src/main/res/drawable/domain_bg.xml   | 10 ---
 .../app/src/main/res/layout/activity_home.xml |  2 +-
 .../app/src/main/res/layout/domain_view.xml   | 67 +++++++++++--------
 android/app/src/main/res/values/colors.xml    |  4 +-
 android/app/src/main/res/values/dimens.xml    |  1 +
 6 files changed, 43 insertions(+), 42 deletions(-)
 delete mode 100644 android/app/src/main/res/drawable/domain_bg.xml

diff --git a/android/app/build.gradle b/android/app/build.gradle
index b2b3bcd772..c63f481f8c 100644
--- a/android/app/build.gradle
+++ b/android/app/build.gradle
@@ -104,6 +104,7 @@ dependencies {
     implementation 'com.android.support:design:26.1.0'
     implementation 'com.android.support:appcompat-v7:26.1.0'
     compile 'com.android.support:recyclerview-v7:26.1.0'
+    compile 'com.android.support:cardview-v7:26.1.0'
 
     compile 'com.squareup.retrofit2:retrofit:2.4.0'
     compile 'com.squareup.retrofit2:converter-gson:2.4.0'
diff --git a/android/app/src/main/res/drawable/domain_bg.xml b/android/app/src/main/res/drawable/domain_bg.xml
deleted file mode 100644
index d30d6413e1..0000000000
--- a/android/app/src/main/res/drawable/domain_bg.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:top="1dp" android:left="12dp" android:bottom="6dp" android:right="12dp">
-        <shape android:shape="rectangle">
-            <solid android:color="@color/backgroundDark" />
-            <corners android:radius="4dp"/>
-        </shape>
-    </item>
-
-</layer-list>
\ No newline at end of file
diff --git a/android/app/src/main/res/layout/activity_home.xml b/android/app/src/main/res/layout/activity_home.xml
index ea24faf823..c399ac16ec 100644
--- a/android/app/src/main/res/layout/activity_home.xml
+++ b/android/app/src/main/res/layout/activity_home.xml
@@ -18,7 +18,7 @@
             android:id="@+id/toolbar"
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
-            android:background="?attr/colorPrimary"
+            android:background="?attr/colorPrimaryDark"
             android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar" />
 
         <include layout="@layout/content_home" />
diff --git a/android/app/src/main/res/layout/domain_view.xml b/android/app/src/main/res/layout/domain_view.xml
index ebcc831f05..2c2a36665f 100644
--- a/android/app/src/main/res/layout/domain_view.xml
+++ b/android/app/src/main/res/layout/domain_view.xml
@@ -1,35 +1,44 @@
 <?xml version="1.0" encoding="utf-8"?>
-<android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<android.support.v7.widget.CardView xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="170dp"
-    android:paddingLeft="14dp"
-    android:paddingRight="14dp"
-    android:paddingTop="4dp"
-    android:paddingBottom="4dp"
-    android:background="@drawable/domain_bg">
-    <ImageView
-        android:id="@+id/domainThumbnail"
-        android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:scaleType="centerCrop"
-        app:srcCompat="@android:drawable/ic_menu_gallery" />
+    android:layout_marginStart="14dp"
+    android:layout_marginEnd="14dp"
+    android:layout_marginTop="4dp"
+    android:layout_marginBottom="4dp"
+    android:foreground="@drawable/rippleable"
+    android:clickable="true"
+    android:focusable="true"
+    android:elevation="0dp"
+    app:cardElevation="0dp"
+    app:cardCornerRadius="@dimen/item_corner_radius">
 
-    <TextView
-        android:id="@+id/domainName"
+    <android.support.constraint.ConstraintLayout
         android:layout_width="match_parent"
-        android:layout_height="60dp"
-        android:fontFamily="@font/raleway_semibold"
-        android:paddingStart="10dp"
-        android:paddingEnd="10dp"
-        android:gravity="center_vertical"
-        android:text=""
-        android:textSize="21sp"
-        android:textColor="@color/white_opaque"
-        android:background="@color/domainTextBg"
-        app:layout_constraintBottom_toBottomOf="parent"
-        app:layout_constraintLeft_toLeftOf="parent" />
-<!--android:layout_marginBottom="14dp"
-        android:layout_marginStart="10dp"-->
-</android.support.constraint.ConstraintLayout>
\ No newline at end of file
+        android:layout_height="match_parent">
+
+        <ImageView
+            android:id="@+id/domainThumbnail"
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            android:scaleType="centerCrop"
+            app:srcCompat="@android:drawable/ic_menu_gallery" />
+
+        <TextView
+            android:id="@+id/domainName"
+            android:layout_width="match_parent"
+            android:layout_height="60dp"
+            android:fontFamily="@font/raleway_semibold"
+            android:paddingStart="10dp"
+            android:paddingEnd="10dp"
+            android:gravity="center_vertical"
+            android:text=""
+            android:textSize="21sp"
+            android:textColor="@color/white_opaque"
+            android:background="@color/black_060"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintLeft_toLeftOf="parent" />
+
+    </android.support.constraint.ConstraintLayout>
+</android.support.v7.widget.CardView>
\ No newline at end of file
diff --git a/android/app/src/main/res/values/colors.xml b/android/app/src/main/res/values/colors.xml
index 92e9f859ee..4dfc98d3ad 100644
--- a/android/app/src/main/res/values/colors.xml
+++ b/android/app/src/main/res/values/colors.xml
@@ -2,7 +2,7 @@
 <resources>
     <color name="white_opaque">#ffffff</color>
     <color name="colorPrimary">@color/backgroundLight</color>
-    <color name="colorPrimaryDark">#000000</color>
+    <color name="colorPrimaryDark">@color/backgroundDark</color>
     <color name="colorAccent">#54D7FD</color>
     <color name="backgroundEditText">#E3E3E3</color>
     <color name="editTextColor">#575757</color>
@@ -15,5 +15,5 @@
     <color name="editTextHint">#9e9e9e</color>
     <color name="menuOption">#F2F2F2</color>
     <color name="colorLoginError">#FF7171</color>
-    <color name="domainTextBg">#7F000000</color>
+    <color name="black_060">#99000000</color>
 </resources>
diff --git a/android/app/src/main/res/values/dimens.xml b/android/app/src/main/res/values/dimens.xml
index 440adcf6b9..fdf2141094 100644
--- a/android/app/src/main/res/values/dimens.xml
+++ b/android/app/src/main/res/values/dimens.xml
@@ -11,4 +11,5 @@
     <dimen name="text_size_subtitle_material_toolbar">12dp</dimen>
     <dimen name="button_horizontal_margin">12dp</dimen>
     <dimen name="edit_text_padding">8dp</dimen>
+    <dimen name="item_corner_radius">4dp</dimen>
 </resources>
\ No newline at end of file